starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

closeOnExit: graceful doesn't work right after moving a pane to a new tab #14962

New Issue
Closed
opened 2026-01-31 04:24:25 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 04:24:25 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Aug 25, 2021).

likely regressed in #10780

repro steps:

  • set "closeOnExit": "graceful" (I bet always would work too, but haven't checked)
  • split a pane.
  • In the first pane, run a command. Or just type input. Do anything really, or heck don't.
  • open the command palette and run mp -t 2, to move this pane to a new tab.
  • type exit

expected:
pane exits, and with it, the tab

actual:
image

This is a bug that's only present in 1.11+, but since movePane only exists in 1.11+, it's not technically a regression. If we can't get it fixed for 1.11, we can probably just service this. I don't think this is worth blocking over.

Originally created by @zadjii-msft on GitHub (Aug 25, 2021). likely regressed in #10780 **repro steps:** * set `"closeOnExit": "graceful"` (I bet `always` would work too, but haven't checked) * split a pane. * In the first pane, run a command. Or just type input. Do anything really, or heck don't. * open the command palette and run `mp -t 2`, to move this pane to a new tab. * type `exit` **expected:** pane exits, and with it, the tab **actual:** ![image](https://user-images.githubusercontent.com/18356694/130838930-7c2c8550-b775-4837-83a6-9bf27d5af483.png) This is a bug that's only present in 1.11+, but since `movePane` only exists in 1.11+, it's not technically a regression. If we can't get it fixed for 1.11, we can probably just service this. I don't think this is worth blocking over.
claunia commented 2026-01-31 04:24:27 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 25, 2021):

Huh. What other event handlers aren't getting hooked up? Could it be that Bell and the two focus trackers are also lost? Are we never calling Initialize?

@DHowett commented on GitHub (Aug 25, 2021): _Huh_. What other event handlers aren't getting hooked up? Could it be that Bell and the two focus trackers are also lost? Are we never calling Initialize?
claunia commented 2026-01-31 04:24:27 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 25, 2021):

No, we're calling _AttachEventHandlersToPane and all in AttachPane; perhaps we are not doing it in the "new tab with pane" case?

@DHowett commented on GitHub (Aug 25, 2021): No, we're calling `_AttachEventHandlersToPane` and all in `AttachPane`; perhaps we are not doing it in the "new tab with pane" case?
claunia commented 2026-01-31 04:24:27 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 25, 2021):

Yes, it looks like a pane converted into a new tab can't bell!

@DHowett commented on GitHub (Aug 25, 2021): Yes, it looks like a pane converted into a _new tab_ can't bell!
claunia commented 2026-01-31 04:24:27 +00:00
Author
Owner
Copy Link

@Rosefield commented on GitHub (Aug 25, 2021):

Oh, oops, I'll take a look at this.

@Rosefield commented on GitHub (Aug 25, 2021): Oh, oops, I'll take a look at this.
claunia commented 2026-01-31 04:24:28 +00:00
Author
Owner
Copy Link

@Rosefield commented on GitHub (Aug 25, 2021):

So, sanity checking,

  1. TabManagement calls InitializeTab https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/TabManagement.cpp#L228
  2. Which calls tab->Initialize https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/TabManagement.cpp#L103
  3. Which appears to call AttachEventHandlersToPane https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/TerminalTab.cpp#L210 (and is the same code path as creating a normal tab from a control)

Is this a problem with all moved panes, or just ones moved to new tabs? Admittedly one of the reasons I adopted wt in the first place was so I could turn the bell off, so I never would have noticed it missing. :)

@Rosefield commented on GitHub (Aug 25, 2021): So, sanity checking, 1. TabManagement calls InitializeTab https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/TabManagement.cpp#L228 2. Which calls tab->Initialize https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/TabManagement.cpp#L103 3. Which appears to call `AttachEventHandlersToPane` https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/TerminalTab.cpp#L210 (and is the same code path as creating a normal tab from a control) Is this a problem with all moved panes, or just ones moved to new tabs? Admittedly one of the reasons I adopted wt in the first place was so I could turn the bell off, so I never would have noticed it missing. :)
claunia commented 2026-01-31 04:24:28 +00:00
Author
Owner
Copy Link

@PankajBhojwani commented on GitHub (Aug 25, 2021):

Is this a problem with all moved panes, or just ones moved to new tabs?

Just ones moved to new tabs I think! Did a quick trace and it seems TerminalPage::_MovePane calls _CreateNewTabFromPane, which does not attach any event handlers to the pane Ignore that, it does call Initialize hm

@PankajBhojwani commented on GitHub (Aug 25, 2021): > Is this a problem with all moved panes, or just ones moved to new tabs? <del>Just ones moved to new tabs I think! Did a quick trace and it seems `TerminalPage::_MovePane` calls `_CreateNewTabFromPane`, which does not attach any event handlers to the pane </del> Ignore that, it does call `Initialize` hm
claunia commented 2026-01-31 04:24:28 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 31, 2021):

:tada:This issue was addressed in #11039, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.🎉

Handy links:

@ghost commented on GitHub (Aug 31, 2021): :tada:This issue was addressed in #11039, which has now been successfully released as `Windows Terminal Preview v1.11.2421.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.11.2421.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Triage Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14962
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?