starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

move-pane -t (existing tab) now crashes #14967

New Issue
Closed
opened 2026-01-31 04:24:34 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 04:24:34 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Aug 25, 2021).

Originally assigned to: @zadjii-msft on GitHub.

This may have regressed with #10982 or other Pane changes, since I don't believe the original code from @Rosefield was broken.

Originally created by @DHowett on GitHub (Aug 25, 2021). Originally assigned to: @zadjii-msft on GitHub. This may have regressed with #10982 or other Pane changes, since I don't believe the original code from @Rosefield was broken.
claunia commented 2026-01-31 04:24:38 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 25, 2021):

@zadjii-msft unlike the other one (#11035), this one I will mark blocking 😄

@DHowett commented on GitHub (Aug 25, 2021): @zadjii-msft unlike the other one (#11035), this one I will mark blocking :smile:
claunia commented 2026-01-31 04:24:38 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 25, 2021):

Call stack puts us in IControl::Focus, which might make it related to #10978?

@DHowett commented on GitHub (Aug 25, 2021): Call stack puts us in `IControl::Focus`, which might make it related to #10978?
claunia commented 2026-01-31 04:24:39 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 25, 2021):

@zadjii-msft okay, this only happens when I use commandline mode to mp -t directly, because doing ExecuteCommandLine does another ProcessStartupActions . . .

@DHowett commented on GitHub (Aug 25, 2021): @zadjii-msft okay, this only happens when I use commandline mode to `mp -t` directly, because doing `ExecuteCommandLine` does another `ProcessStartupActions` . . .
claunia commented 2026-01-31 04:24:39 +00:00
Author
Owner
Copy Link

@Rosefield commented on GitHub (Aug 25, 2021):

In my attempts to reproduce, it looks like the issue is when you move the last pane from a tab to another tab, and GetActiveControl returns null because there is no longer a control on the tab being destroyed.

This follows from my decision to null out the member here: https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/TerminalTab.cpp#L531. The cheap fix is to just wrap the _GetActiveControl with a if (const auto control = _GetActiveControl()) ..., but the better one is probably to change those lines since I bet they violate some expectations about when a control should exist, like seen here.

@Rosefield commented on GitHub (Aug 25, 2021): In my attempts to reproduce, it looks like the issue is when you move the last pane from a tab to another tab, and GetActiveControl returns null because there is no longer a control on the tab being destroyed. This follows from my decision to null out the member here: https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalApp/TerminalTab.cpp#L531. The cheap fix is to just wrap the `_GetActiveControl` with a `if (const auto control = _GetActiveControl()) ...`, but the better one is probably to change those lines since I bet they violate some expectations about when a control should exist, like seen here.
claunia commented 2026-01-31 04:24:40 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 31, 2021):

:tada:This issue was addressed in #11040, which has now been successfully released as Windows Terminal Preview v1.10.2383.0.🎉

Handy links:

@ghost commented on GitHub (Aug 31, 2021): :tada:This issue was addressed in #11040, which has now been successfully released as `Windows Terminal Preview v1.10.2383.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.10.2383.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 04:24:40 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 31, 2021):

:tada:This issue was addressed in #11040, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.🎉

Handy links:

@ghost commented on GitHub (Aug 31, 2021): :tada:This issue was addressed in #11040, which has now been successfully released as `Windows Terminal Preview v1.11.2421.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.11.2421.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14967
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?