starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

1.11: scrolling at all breaks the URL pattern buffer (no URLs work) #14983

New Issue
Closed
opened 2026-01-31 04:25:03 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 04:25:03 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Aug 26, 2021).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version (or Windows build number)

1.11

Other Software

No response

Steps to reproduce

Emit a URL
Scroll -- even downwards off the bottom of the screen where you can't scroll

Expected Behavior

No response

Actual Behavior

URLs stop hovering!

Originally created by @DHowett on GitHub (Aug 26, 2021). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version (or Windows build number) 1.11 ### Other Software _No response_ ### Steps to reproduce Emit a URL Scroll -- even downwards off the bottom of the screen where you can't scroll ### Expected Behavior _No response_ ### Actual Behavior URLs stop hovering!
claunia commented 2026-01-31 04:25:05 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 26, 2021):

I knew there was no way that #9955 was totally done 😋

@zadjii-msft commented on GitHub (Aug 26, 2021): I knew there was no way that #9955 was totally done 😋
claunia commented 2026-01-31 04:25:05 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 26, 2021):

guh Even just scrolling the wheel (even if there's nowhere to scroll) will break this!

EDIT: Investigation notes:

  • The wheel will get us into this state without ever firing Terminal::UpdatePatternsUnderLock

c20eb9dad has most of a fix in it

@zadjii-msft commented on GitHub (Aug 26, 2021): _guh_ Even just scrolling the wheel (even if there's nowhere to scroll) will break this! EDIT: Investigation notes: * The wheel will get us into this state without ever firing `Terminal::UpdatePatternsUnderLock` c20eb9dad has most of a fix in it
claunia commented 2026-01-31 04:25:05 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 26, 2021):

In #9820, in TermControl::_ScrollPositionChanged, there was still a call to _updatePatternLocations->Run();. (TermControl.cpp:1655 on the right) https://github.com/microsoft/terminal/pull/9820/files#diff-c10bb023995e88dac6c1d786129284c454c2df739ea547ce462129dc86dc2697R1654

#10051 didn't change this

In #10187 I moved the _updatePatternLocations throttled func from termcontrol to controlcore. Places it existed before:

  • TermControl::_coreReceivedOutput: already matched by ControlCore::_connectionOutputHandler
  • TermControl::_ScrollbarChangeHandler
  • TermControl::_ScrollPositionChanged

There's an existing call in ControlCore::_terminalScrollPositionChanged.

I added a call to Run() to ControlCore::UserScrollViewport in c20eb9d.

I believe TermControl::_ScrollbarChangeHandler -> ControlCore::UserScrollViewport, and TermControl::_ScrollPositionChanged -> ControlCore::_terminalScrollPositionChanged

@zadjii-msft commented on GitHub (Aug 26, 2021): In #9820, in `TermControl::_ScrollPositionChanged`, there was still a call to `_updatePatternLocations->Run();`. (TermControl.cpp:1655 on the right) https://github.com/microsoft/terminal/pull/9820/files#diff-c10bb023995e88dac6c1d786129284c454c2df739ea547ce462129dc86dc2697R1654 #10051 didn't change this In #10187 I moved the `_updatePatternLocations` throttled func from termcontrol to controlcore. Places it existed before: * [x] `TermControl::_coreReceivedOutput`: already matched by ControlCore::_connectionOutputHandler * [ ] `TermControl::_ScrollbarChangeHandler` * [ ] `TermControl::_ScrollPositionChanged` There's an existing call in `ControlCore::_terminalScrollPositionChanged`. I added a call to `Run()` to `ControlCore::UserScrollViewport` in c20eb9d. I believe `TermControl::_ScrollbarChangeHandler` -> `ControlCore::UserScrollViewport`, and `TermControl::_ScrollPositionChanged` -> `ControlCore::_terminalScrollPositionChanged`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Issue-Bug Product-Terminal Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14983
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?