starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

GA ConHost and ReadConsoleOutputAttribute vs. ReadConsoleOutput #14985

New Issue
Closed
opened 2026-01-31 04:25:05 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 04:25:05 +00:00
Owner
Copy Link

Originally created by @vefatica on GitHub (Aug 26, 2021).

Windows Terminal version (or Windows build number)

Microsoft Windows 10 Pro for Workstations 10.0.19043.1165 (2009, 21H1)

Other Software

home-made test exe

Steps to reproduce

With the current general audience ConHost.exe, using ESC[28;2;r;g;bm and a color that corresponds to one of the 16 basic ones, write a character to to the console and compare the attributes given by ReadConsoleOutputAttribute and ReadConsoleOutput.

Expected Behavior

Both functions will give the same attributes.

Actual Behavior

ReadConsoleOutput gives the correct attributes, ReadConsoleOutputAttribute does not (see test below). This is appapently fixed in my latest version of OpenConsole.exe (from WindowsTerminal: 1.10.1933.0) (also see below).

When is this fix likely to get into the general audience ConHost.exe?

And, if someone has the time, please describe the process by which changes in OpenConsole.exe make their way into ConHost.exe.

Tests: with ConHost.exe,
image

with OpenConsole.exe,
image

Originally created by @vefatica on GitHub (Aug 26, 2021). ### Windows Terminal version (or Windows build number) Microsoft Windows 10 Pro for Workstations 10.0.19043.1165 (2009, 21H1) ### Other Software home-made test exe ### Steps to reproduce With the current general audience ConHost.exe, using ESC[28;2;r;g;bm and a color that corresponds to one of the 16 basic ones, write a character to to the console and compare the attributes given by ReadConsoleOutputAttribute and ReadConsoleOutput. ### Expected Behavior Both functions will give the same attributes. ### Actual Behavior ReadConsoleOutput gives the correct attributes, ReadConsoleOutputAttribute does not (see test below). This is appapently fixed in my latest version of OpenConsole.exe (from WindowsTerminal: 1.10.1933.0) (also see below). When is this fix likely to get into the general audience ConHost.exe? And, if someone has the time, please describe the process by which changes in OpenConsole.exe make their way into ConHost.exe. Tests: with ConHost.exe, ![image](https://user-images.githubusercontent.com/61856645/131001155-9d5c3fde-0cb2-45c1-a729-93cad7ae4c02.png) with OpenConsole.exe, ![image](https://user-images.githubusercontent.com/61856645/131000762-253f0be3-6c99-4aa4-abb6-3546046fe0d5.png)
claunia added the Resolution-Duplicate label 2026-01-31 04:25:05 +00:00
claunia commented 2026-01-31 04:25:06 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 26, 2021):

This is, at its heart, a /duplicate of #5940 (hey! I see you commented on that one, too 😄).

Every couple of weeks (time permitting), I merge the changes from this repository's main branch into an internal mirror's inbox branch¹. Once I do that, a tool called git2git migrates the tree from that internal mirror into a directory on my team's branch in the Windows repository.

Some weeks later, that branch's content has made its way to main, which is approximately where insider builds come from.

¹ the inbox branch is mirrored out to this repository as well; you can see where it points pretty easily.

@DHowett commented on GitHub (Aug 26, 2021): This is, at its heart, a /duplicate of #5940 (hey! I see you commented on that one, too :smile:). Every couple of weeks (time permitting), I merge the changes from this repository's `main` branch into an internal mirror's `inbox` branch¹. Once I do that, a tool called `git2git` migrates the tree from that internal mirror into a directory on my team's branch in the Windows repository. Some weeks later, that branch's content has made its way to `main`, which is approximately where insider builds come from. ¹ the `inbox` branch is mirrored out to this repository as well; you can see where it points pretty easily.
claunia commented 2026-01-31 04:25:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 26, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Aug 26, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 04:25:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 26, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Aug 26, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 04:25:07 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Aug 26, 2021):

Thanks @DHowett . I actually thought I had asked it before and only searched my own posts.

I didn't mean insider builds. One could call this a bug. How/when might it be fixed in the general audience ConHost.exe.

@vefatica commented on GitHub (Aug 26, 2021): Thanks @DHowett . I actually thought I had asked it before and only searched my own posts. I didn't mean insider builds. One could call this a bug. How/when might it be fixed in the general audience ConHost.exe.
claunia commented 2026-01-31 04:25:07 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Aug 26, 2021):

It will be fixed in the general audience conhost.exe when the insider builds are released to the general audience. We have no special license for fixing tiny incompatibilities in cumulative servicing updates, and so almost all conhost changes have to wait until the next "big update" of Windows.

@DHowett commented on GitHub (Aug 26, 2021): It will be fixed in the general audience conhost.exe when the insider builds are released to the general audience. We have no special license for fixing tiny incompatibilities in cumulative servicing updates, and so almost all conhost changes have to wait until the next "big update" of Windows.
claunia commented 2026-01-31 04:25:07 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Aug 26, 2021):

Thanks again. Is it possible to search for my own contributions to issues created by others?

@vefatica commented on GitHub (Aug 26, 2021): Thanks again. Is it possible to search for my own contributions to issues created by others?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#14985
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?