starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Settings that are floats like acrylicOpacity don't round trip correctly #15010

New Issue
Open
opened 2026-01-31 04:25:59 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 04:25:59 +00:00
Owner
Copy Link

Originally created by @shanselman on GitHub (Aug 30, 2021).

Windows Terminal version (or Windows build number)

1.11.2372.0

Other Software

Just a terminal bug, nothing else

Steps to reproduce

Edit settings.json manually and set "acrylicOpacity": 0.7 while Terminal is running.

Now go to the Terminal Settings UI and change something else. Note that acrylicOpacity is now 0.69999999999999996

image

Expected Behavior

I expected floats to roundtrip with JSON numbers

Actual Behavior

0.7 turned into "acrylicOpacity": 0.69999999999999996,

Originally created by @shanselman on GitHub (Aug 30, 2021). ### Windows Terminal version (or Windows build number) 1.11.2372.0 ### Other Software Just a terminal bug, nothing else ### Steps to reproduce Edit settings.json manually and set "acrylicOpacity": 0.7 while Terminal is running. Now go to the Terminal Settings UI and change something else. Note that acrylicOpacity is now 0.69999999999999996 ![image](https://user-images.githubusercontent.com/2892/131270280-0fc272f5-dafa-4106-aec7-f646a9564e06.png) ### Expected Behavior I expected floats to roundtrip with JSON numbers ### Actual Behavior 0.7 turned into "acrylicOpacity": 0.69999999999999996,
claunia added the Area-SettingsIssue-BugPriority-3Product-Terminal labels 2026-01-31 04:26:00 +00:00
claunia commented 2026-01-31 04:26:00 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Aug 30, 2021):

Technically this is the same issue as #1398. That was initially "fixed" by PR #2475, which simply stopped serializing settings. But I'm assuming the problem returned once we introduced the new Settings UI, so there was a need for the serializing again.

@j4james commented on GitHub (Aug 30, 2021): Technically this is the same issue as #1398. That was initially "fixed" by PR #2475, which simply stopped serializing settings. But I'm assuming the problem returned once we introduced the new Settings UI, so there was a need for the serializing again.
claunia commented 2026-01-31 04:26:01 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 8, 2021):

Yea, that's probably not right. I wonder what other settings we have that are floats like this. I'm about to blow away acrylicOpacity as a float in #603, but we'll need to do something about the others.

@zadjii-msft commented on GitHub (Sep 8, 2021): Yea, that's probably not right. I wonder what other settings we have that are floats like this. I'm about to blow away `acrylicOpacity` as a float in #603, but we'll need to do something about the others.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15010
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?