Unzipped install, comment "disabledProfileSources", save, crash #15043

Open
opened 2026-01-31 04:26:49 +00:00 by claunia · 14 comments
Owner

Originally created by @vefatica on GitHub (Sep 1, 2021).

Windows Terminal version (or Windows build number)

Microsoft Windows 10 Pro for Workstations 10.0.19043.1165 (2009, 21H1) WindowsTerminal: 1.11.2421.0WindowsTerminal: 1.10.2383.0

Other Software

No response

Steps to reproduce

In either WT (1.10) or WTPreview (1.11), installed by just unzipping, open settings.json from the settings UI. Comment these lines (here, just the Azure line is sufficient):

//"disabledProfileSources": 
//[
//    "Windows.Terminal.Wsl",
//    "Windows.Terminal.Azure",
//    "Windows.Terminal.PowershellCore"
//],

Save the file.

Expected Behavior

Nothing to speak of. This is how the properly (msix) installed ones behave.

Actual Behavior

WindowsTerminal disappears.

Faulting application name: WindowsTerminal.exe, version: 1.11.2108.30001, time stamp: 0x612d15d9
Faulting module name: KERNELBASE.dll, version: 10.0.19041.1151, time stamp: 0x891df6d3
Exception code: 0xc000027b
Fault offset: 0x000000000010bd3e

Originally created by @vefatica on GitHub (Sep 1, 2021). ### Windows Terminal version (or Windows build number) Microsoft Windows 10 Pro for Workstations 10.0.19043.1165 (2009, 21H1) WindowsTerminal: 1.11.2421.0WindowsTerminal: 1.10.2383.0 ### Other Software _No response_ ### Steps to reproduce In either WT (1.10) or WTPreview (1.11), installed by just unzipping, open settings.json from the settings UI. Comment these lines (here, just the Azure line is sufficient): //"disabledProfileSources": //[ // "Windows.Terminal.Wsl", // "Windows.Terminal.Azure", // "Windows.Terminal.PowershellCore" //], Save the file. ### Expected Behavior Nothing to speak of. This is how the properly (msix) installed ones behave. ### Actual Behavior WindowsTerminal disappears. Faulting application name: WindowsTerminal.exe, version: 1.11.2108.30001, time stamp: 0x612d15d9 Faulting module name: KERNELBASE.dll, version: 10.0.19041.1151, time stamp: 0x891df6d3 Exception code: 0xc000027b Fault offset: 0x000000000010bd3e
Author
Owner

@zadjii-msft commented on GitHub (Oct 20, 2021):

maybe relevant? Just saw this scrolling through the jsoncpp backlog and thought of this issue. Looking over it again, probably not.

https://github.com/open-source-parsers/jsoncpp/issues/1238

@zadjii-msft commented on GitHub (Oct 20, 2021): _maybe_ relevant? Just saw this scrolling through the jsoncpp backlog and thought of this issue. Looking over it again, probably not. https://github.com/open-source-parsers/jsoncpp/issues/1238
Author
Owner

@zadjii-msft commented on GitHub (Feb 17, 2022):

Hey just a thought, could you share your whole settings.json file? I feel like this might stealthily be #11545, depending on where those props are in the file

@zadjii-msft commented on GitHub (Feb 17, 2022): Hey just a thought, could you share your whole [settings.json file](https://github.com/microsoft/terminal/wiki/Frequently-Asked-Questions-(FAQ)#where-can-i-find-the-settings-file)? I feel like this might stealthily be #11545, depending on where those props are in the file
Author
Owner

@vefatica commented on GitHub (Feb 17, 2022):

Here's my settings file.
wt_settings.zip

I just tried with the latest (1.12 and 1.13). It's the same, they disappear when the file is saved. I have local DMP files (from today) if you want them.

@vefatica commented on GitHub (Feb 17, 2022): Here's my settings file. [wt_settings.zip](https://github.com/microsoft/terminal/files/8090047/wt_settings.zip) I just tried with the latest (1.12 and 1.13). It's the same, they disappear when the file is saved. I have local DMP files (from today) if you want them.
Author
Owner

@zadjii-msft commented on GitHub (Feb 18, 2022):

Yea I'm definitely gonna want to see the crash dumps. Merely commenting out those lines doesn't crash unpackaged over here with 1.13.10395. Even with a fresh state.json I couldn't get this to crash.

@zadjii-msft commented on GitHub (Feb 18, 2022): Yea I'm definitely gonna want to see the crash dumps. Merely commenting out those lines doesn't crash unpackaged over here with 1.13.10395. Even with a fresh `state.json` I couldn't get this to crash.
Author
Owner

@vefatica commented on GitHub (Feb 18, 2022):

Here they are.
20220217.zip

@vefatica commented on GitHub (Feb 18, 2022): Here they are. [20220217.zip](https://github.com/microsoft/terminal/files/8098346/20220217.zip)
Author
Owner

@vefatica commented on GitHub (Feb 18, 2022):

P.S., The crashes left openconsole.exe running. The shell (TCC) terminated.

@vefatica commented on GitHub (Feb 18, 2022): P.S., The crashes left openconsole.exe running. The shell (TCC) terminated.
Author
Owner

@zadjii-msft commented on GitHub (Feb 18, 2022):

That is super weird that commenting put those lines crashes there. The crash is just like, down in XAML land, just on a Tick.

Both are the same failure hash, 424eb58f-9a25-e96c-5271-738d8d92a22a. That unfortunately repros across a huge swath of applications. MSFT:18519410 is tracking this. From the internal bug:

Looks like an issue accessing a resource, which might be an app bug or a bug in how it is using WinUI 2.x.

Which I guess makes sense, for unpackaged install. I wonder if it's trying to find an error message but not being able to look it up. Nothing in !xamlstowed. Definitely a spike in these hits in December, but seemingly none before that? I'd bet that's just due to old data getting cleaned out.

@zadjii-msft commented on GitHub (Feb 18, 2022): That is super weird that commenting put those lines crashes there. The crash is just like, down in XAML land, just on a Tick. Both are the same failure hash, 424eb58f-9a25-e96c-5271-738d8d92a22a. That unfortunately repros across a huge swath of applications. MSFT:18519410 is tracking this. From the internal bug: > Looks like an issue accessing a resource, which might be an app bug or a bug in how it is using WinUI 2.x. Which I guess makes sense, for unpackaged install. I wonder if it's trying to find an error message but not being able to look it up. Nothing in `!xamlstowed`. Definitely a spike in these hits in December, but seemingly none before that? I'd bet that's just due to old data getting cleaned out.
Author
Owner

@vefatica commented on GitHub (Feb 18, 2022):

Hmmm! There seems to be some undefined behavior.

I updated to 1.13.10395.0 and 1.12.10393.0. First I tried the preview. The results were the same as before the update (and as describer earlier). Then I tried the stable version. When I told the editor to save, I simultaneously got a message box from WT saying it couldn't save because another app had the file open AND a message box from the editor that the file had been changed outside the editor (do I want to reload it). I said yes to the reload and (I think) the commented lines had been removed (there was no crash). Then I restored settings.json to the one I posted yesterday and, for a few tries, I could not reproduce ANYTHING I saw before (everything seemed OK). A few tries later, I'm back to square one ... both versions crash when I comment the lines and save the file.

@vefatica commented on GitHub (Feb 18, 2022): Hmmm! There seems to be some undefined behavior. I updated to 1.13.10395.0 and 1.12.10393.0. First I tried the preview. The results were the same as before the update (and as describer earlier). Then I tried the stable version. When I told the editor to save, I simultaneously got a message box from WT saying it couldn't save because another app had the file open AND a message box from the editor that the file had been changed outside the editor (do I want to reload it). I said yes to the reload and (I think) the commented lines had been removed (there was no crash). Then I restored settings.json to the one I posted yesterday and, for a few tries, I could not reproduce ANYTHING I saw before (everything seemed OK). A few tries later, I'm back to square one ... both versions crash when I comment the lines and save the file.
Author
Owner

@zadjii-msft commented on GitHub (Feb 18, 2022):

What editor are you using?

I simultaneously got a message box from WT saying it couldn't save because another app had the file open

I don't recall us ever adding that warning, but maybe I'm wrong? You have a screenshot of that warning?

@zadjii-msft commented on GitHub (Feb 18, 2022): What editor are you using? > I simultaneously got a message box from WT saying it couldn't save because another app had the file open I don't recall us ever adding that warning, but maybe I'm wrong? You have a screenshot of that warning?
Author
Owner

@vefatica commented on GitHub (Feb 18, 2022):

I use TextPad v7.6.4/64. I have no screen shot since I can't repro the message box. I'll try a few more times.

@vefatica commented on GitHub (Feb 18, 2022): I use TextPad v7.6.4/64. I have no screen shot since I can't repro the message box. I'll try a few more times.
Author
Owner

@vefatica commented on GitHub (Feb 18, 2022):

F7 saves the file in TextPad ... maybe I saw the caret-browsing message box (and without really looking at it, assumed it was a "couldn't save" message).

@vefatica commented on GitHub (Feb 18, 2022): F7 saves the file in TextPad ... maybe I saw the caret-browsing message box (and without really looking at it, assumed it was a "couldn't save" message).
Author
Owner

@vefatica commented on GitHub (Feb 18, 2022):

This is really crazy. I have no idea how I did it, but I was in a situation where I couldn't repro any crash (both versions and yesterday's settings.json, several instances). I deleted state.json (that's all I did!) and the crashes returned. How do I get state.json back?

@vefatica commented on GitHub (Feb 18, 2022): This is really crazy. I have no idea how I did it, but I was in a situation where I couldn't repro any crash (both versions and yesterday's settings.json, several instances). I deleted state.json (that's all I did!) and the crashes returned. How do I get state.json back?
Author
Owner

@lhecker commented on GitHub (Aug 30, 2023):

It's been quite a while, and we haven't gotten to this bug yet unfortunately: Did this issue still happen to you lately?

@lhecker commented on GitHub (Aug 30, 2023): It's been quite a while, and we haven't gotten to this bug yet unfortunately: Did this issue still happen to you lately?
Author
Owner

@vefatica commented on GitHub (Aug 31, 2023):

I just tried it. There was no crash, but the all the commented lines were removed from the file. Funny ... those profiles still (no longer disabled?) appear in "Settings" they don't appear in the drop-down menu.

@vefatica commented on GitHub (Aug 31, 2023): I just tried it. There was no crash, but the all the commented lines were removed from the file. Funny ... those profiles still (no longer disabled?) appear in "Settings" they **don't** appear in the drop-down menu.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15043