starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Switching tab as part of running multiple actions does not focus tab immediately #15047

New Issue
Closed
opened 2026-01-31 04:26:57 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 04:26:57 +00:00
Owner
Copy Link

Originally created by @Rosefield on GitHub (Sep 1, 2021).

Windows Terminal version (or Windows build number)

dev/main, but also potentially preview through commandline

Other Software

No response

Steps to reproduce

Trying to use the multipleActions action with this command (trying to update the docs)

        { "name": "Create My Layout", "command": { 
            "action": "multipleActions",
            "actions": [
                // Create a new tab with 3 panes
                { "action": "newTab", "tabTitle": "Work", "colorScheme": "One Half Dark" },
                { "action": "splitPane", "split": "vertical", "profile": "Windows PowerShell", "tabTitle": "Work", "colorScheme": "Campbell Powershell", },
                { "action": "splitPane", "split": "horizontal", "profile": "Windows PowerShell", "tabTitle": "Work", "colorScheme": "Campbell Powershell", },
                // Create a second tab
                { "action": "newTab", "tabTitle": "Misc"},
                // Go back to the first tab and zoom the first pane
                { "action": "prevTab", "tabSwitcherMode": "disabled"},
                { "action": "moveFocus", "direction": "first"},
                "togglePaneZoom"
                ]
            }}

Results in not zooming or focusing the correct pane.

Expected Behavior

The first new tab will be focused, and the first pane on it should be zoomed.

Actual Behavior

The first new tab is focused, but the last created pane is focused and nothing is zoomed because the activeTab is still the 2nd tab even after prevTab is run until the event loop catches up.

Originally created by @Rosefield on GitHub (Sep 1, 2021). ### Windows Terminal version (or Windows build number) dev/main, but also potentially preview through commandline ### Other Software _No response_ ### Steps to reproduce Trying to use the `multipleActions` action with this command (trying to update the docs) ``` { "name": "Create My Layout", "command": { "action": "multipleActions", "actions": [ // Create a new tab with 3 panes { "action": "newTab", "tabTitle": "Work", "colorScheme": "One Half Dark" }, { "action": "splitPane", "split": "vertical", "profile": "Windows PowerShell", "tabTitle": "Work", "colorScheme": "Campbell Powershell", }, { "action": "splitPane", "split": "horizontal", "profile": "Windows PowerShell", "tabTitle": "Work", "colorScheme": "Campbell Powershell", }, // Create a second tab { "action": "newTab", "tabTitle": "Misc"}, // Go back to the first tab and zoom the first pane { "action": "prevTab", "tabSwitcherMode": "disabled"}, { "action": "moveFocus", "direction": "first"}, "togglePaneZoom" ] }} ``` Results in not zooming or focusing the correct pane. ### Expected Behavior The first new tab will be focused, and the first pane on it should be zoomed. ### Actual Behavior The first new tab is focused, but the last created pane is focused and nothing is zoomed because the `activeTab` is still the 2nd tab even after `prevTab` is run until the event loop catches up.
claunia commented 2026-01-31 04:26:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 1, 2021):

You know, I hit this before. TerminalPage::_SelectTab has a special case for "Startup" to handle updating the selected tab without relying on XAML to propagate the events through. That might be part of the trick here.

@zadjii-msft commented on GitHub (Sep 1, 2021): You know, I hit this before. `TerminalPage::_SelectTab` has a special case for "Startup" to handle updating the selected tab without relying on XAML to propagate the events through. That might be part of the trick here.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Triage Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15047
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?