Profiles missing after resetting config #15054

Closed
opened 2026-01-31 04:27:06 +00:00 by claunia · 4 comments
Owner

Originally created by @ktremain on GitHub (Sep 2, 2021).

Originally assigned to: @zadjii-msft on GitHub.

Windows Terminal version (or Windows build number)

1.10.2383.0

Other Software

No response

Steps to reproduce

  1. have terminal ver 1.9 with default profiles including powershell/WSL/Azure shell
  2. upgrade to v1.10
  3. open settings.json
  4. delete contents of file and save
  5. reload terminal

as per notes at top of config file, i wanted to ensure that i had any new defaults now that v1.10 has been released
"..It should still be usable in newer versions, but newer versions might have additional
settings, help text, or changes that you will not see unless you clear this file
and let us generate a new one for you."

Expected Behavior

expected that all default profiles get regenerated

Actual Behavior

only "windows powershell" and "Command prompt" appear.

Also note that terminal did infact launch "powershell" (v7.1.4) and had an empty dropdown in the "default profile" box in settings as what was launched did not have any profile.

I had to reset the app to restore all my profiles

Originally created by @ktremain on GitHub (Sep 2, 2021). Originally assigned to: @zadjii-msft on GitHub. ### Windows Terminal version (or Windows build number) 1.10.2383.0 ### Other Software _No response_ ### Steps to reproduce 1. have terminal ver 1.9 with default profiles including powershell/WSL/Azure shell 2. upgrade to v1.10 3. open settings.json 4. delete contents of file and save 5. reload terminal as per notes at top of config file, i wanted to ensure that i had any new defaults now that v1.10 has been released "..It should still be usable in newer versions, but newer versions might have additional settings, help text, or changes that you will not see unless you clear this file and let us generate a new one for you." ### Expected Behavior expected that all default profiles get regenerated ### Actual Behavior only "windows powershell" and "Command prompt" appear. Also note that terminal did infact launch "powershell" (v7.1.4) and had an empty dropdown in the "default profile" box in settings as what was launched did not have any profile. I had to reset the app to restore all my profiles
Author
Owner

@zadjii-msft commented on GitHub (Sep 2, 2021):

HMMMMMM This is a good point. In 1.11 (and backported to 1.10), we added the ability to just delete dynamic profiles from the settings, and have them not auto-regenerate. But if you totally blow away the settings file, that's kinda a different case now.

@DHowett @lhecker for discussion: if settings.json is totally empty, or missing, should we clear out state.json too? Or is that just a bad heuristic? Is there a reason we would want to keep state.json even if they blow away their settings?

@zadjii-msft commented on GitHub (Sep 2, 2021): HMMMMMM This is a good point. In 1.11 (and backported to 1.10), we added the ability to just delete dynamic profiles from the settings, and have them not auto-regenerate. But if you totally blow away the settings file, that's kinda a different case now. @DHowett @lhecker for discussion: if `settings.json` is _totally empty_, or missing, should we clear out `state.json` too? Or is that just a bad heuristic? Is there a reason we would want to keep `state.json` even if they blow away their settings?
Author
Owner

@lhecker commented on GitHub (Sep 2, 2021):

@DHowett @lhecker for discussion: if settings.json is totally empty, or missing, should we clear out state.json too?

Sounds good to me actually.

@lhecker commented on GitHub (Sep 2, 2021): > @DHowett @lhecker for discussion: if settings.json is totally empty, or missing, should we clear out state.json too? Sounds good to me actually.
Author
Owner

@carlos-zamora commented on GitHub (Oct 6, 2021):

@zadjii-msft Is there anything left to do here after merging that docs change?

@carlos-zamora commented on GitHub (Oct 6, 2021): @zadjii-msft Is there anything left to do here after merging that docs change?
Author
Owner

@zadjii-msft commented on GitHub (Oct 6, 2021):

Oh we were going to change the Terminal so that when we encounter a missing or empty settings.json, we'll also make sure to manually clear out state.json. That way any state from the previous settings instance isn't used accidentally.

@zadjii-msft commented on GitHub (Oct 6, 2021): Oh we were going to change the Terminal so that when we encounter a missing or empty `settings.json`, we'll also make sure to manually clear out `state.json`. That way any state from the previous settings instance isn't used accidentally.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15054