starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Settings]: The 'Open JSON File' element's ControlType requires valid values for SizeOfSet and PositionInSet. #15096

New Issue
Closed
opened 2026-01-31 04:28:25 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 04:28:25 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Sep 6, 2021).

Windows Terminal version (or Windows build number)

1.10.2383.0

Other Software

Test Environment:
OS: Windows 11 Version 21H2 (OS Build 22000.168)
Screen Reader: Narrator
Tool: Accessibility Insights for Windows Version 1.1.1689.01

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using "Ctrl + ',' ".
  3. Run Accessibility insights for Window on Settings page and Observe the issue.

User Experience: -> Priority 2
Screen Reader user are impacted here as incorrect position is announced for control which will confuse user.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value

Attachments:
The 'Open JSON File' element's ControlType requires valid values for SizeOfSet and PositionInSet..zip

Expected Behavior

The 'Open JSON File' element's ControlType requires valid values for SizeOfSet and PositionInSet.

Actual Behavior

The 'Open JSON File' element's ControlType doesn't have valid values for SizeOfSet and PositionInSet. Screen Reader announce 'Open JSON file 11 of 11' which is incorrect.

Originally created by @ghost on GitHub (Sep 6, 2021). ### Windows Terminal version (or Windows build number) 1.10.2383.0 ### Other Software **Test Environment:** OS: Windows 11 Version 21H2 (OS Build 22000.168) Screen Reader: Narrator Tool: Accessibility Insights for Windows Version 1.1.1689.01 ### Steps to reproduce **Repro Steps:** 1. Open Windows Terminal. 2. Open Settings page using "Ctrl + ',' ". 3. Run Accessibility insights for Window on Settings page and Observe the issue. **User Experience:** -> _Priority 2_ Screen Reader user are impacted here as incorrect position is announced for control which will confuse user. **Guideline Reference:** https://www.w3.org/WAI/WCAG21/Understanding/name-role-value **Attachments:** [The 'Open JSON File' element's ControlType requires valid values for SizeOfSet and PositionInSet..zip](https://github.com/microsoft/terminal/files/7115533/The.Open.JSON.File.element.s.ControlType.requires.valid.values.for.SizeOfSet.and.PositionInSet.zip) ### Expected Behavior The 'Open JSON File' element's ControlType requires valid values for SizeOfSet and PositionInSet. ### Actual Behavior The 'Open JSON File' element's ControlType doesn't have valid values for SizeOfSet and PositionInSet. Screen Reader announce 'Open JSON file 11 of 11' which is incorrect.
claunia commented 2026-01-31 04:28:28 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Dec 27, 2021):

Bug Update in Dec Test Pass: Issue Still repro as Screen Reader is only announcing name as 'Open JSON file' when user navigate to 'Open JSON file' control using down arrow key.

@ghost commented on GitHub (Dec 27, 2021): **Bug Update in Dec Test Pass:** Issue Still repro as Screen Reader is only announcing name as 'Open JSON file' when user navigate to 'Open JSON file' control using down arrow key.
claunia commented 2026-01-31 04:28:28 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jan 26, 2022):

I think this might be an external issue, if it's still even considered an issue at all?

Here's some background...

SizeOfSet and PositionInSet have now changed

The 'Open JSON File' element's ControlType doesn't have valid values for SizeOfSet and PositionInSet. Screen Reader announce 'Open JSON file 11 of 11' which is incorrect.

Not sure when this was introduced, but on 15a047512, I'm not seeing SizeOfSet and PositionInSet both being 11. Instead, Accessibility Insights is telling me Property does not exist.

What do other apps do

Edge - vertical tabs

Interesting! The "New tab" button there experiences the same behavior.

XAML Controls Gallery

The "Settings" item (which is located in the footer) is marked SizeOfSet: 1 and PositionInSet: 1.

What is the correct behavior here?

In Windows Terminal's settings UI, I'm seeing the navigation view items organized into three sets:

  • Set 1 includes "Startup" through "Actions"
  • Set 2 includes "Defaults", all of the profiles, and "Add a new profile"
  • Set 3 includes "Open JSON file"

@v-rpundir What's the correct behavior here?

  1. [Current behavior] keep SizeOfSet and PositionInSet as undefined. Note that this matches Edge's vertical tabs.
  2. [Match XAML Controls Gallery] SizeOfSet and PositionInSet should both be 1
  3. [Everything is wrong?] The three sets above should all be one contiguous set

CC @DHowett @zadjii-msft for thoughts

@carlos-zamora commented on GitHub (Jan 26, 2022): I think this might be an external issue, if it's still even considered an issue at all? Here's some background... ### `SizeOfSet` and `PositionInSet` have now changed > The 'Open JSON File' element's ControlType doesn't have valid values for SizeOfSet and PositionInSet. Screen Reader announce 'Open JSON file 11 of 11' which is incorrect. Not sure when this was introduced, but on 15a047512, I'm not seeing `SizeOfSet` and `PositionInSet` both being `11`. Instead, Accessibility Insights is telling me `Property does not exist`. ### What do other apps do #### Edge - vertical tabs Interesting! The "New tab" button there experiences the same behavior. #### XAML Controls Gallery The "Settings" item (which is located in the footer) is marked `SizeOfSet: 1` and `PositionInSet: 1`. ### What is the correct behavior here? In Windows Terminal's settings UI, I'm seeing the navigation view items organized into three sets: - Set 1 includes "Startup" through "Actions" - Set 2 includes "Defaults", all of the profiles, and "Add a new profile" - Set 3 includes "Open JSON file" @v-rpundir What's the correct behavior here? 1. [Current behavior] keep `SizeOfSet` and `PositionInSet` as undefined. Note that this matches Edge's vertical tabs. 2. [Match XAML Controls Gallery] `SizeOfSet` and `PositionInSet` should both be `1` 3. [Everything is wrong?] The three sets above should all be one contiguous set CC @DHowett @zadjii-msft for thoughts
claunia commented 2026-01-31 04:28:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 27, 2022):

Hi @carlos-zamora

This is correct behavior as it is universal throughout Windows Apps.
Case 2: [Match XAML Controls Gallery] SizeOfSet and PositionInSet should both be 1

Below one is current situation, but Screen Reader is still announcing incorrect position & AI is giving Error:
For Case 1: [Current behavior] keep SizeOfSet and PositionInSet as undefined. Note that this matches Edge's vertical tabs.
image

Thanks :):

@ghost commented on GitHub (Jan 27, 2022): Hi @carlos-zamora This is correct behavior as it is universal throughout Windows Apps. **Case 2: [Match XAML Controls Gallery] SizeOfSet and PositionInSet should both be 1** Below one is current situation, but Screen Reader is still announcing incorrect position & AI is giving Error: For Case 1: [Current behavior] keep SizeOfSet and PositionInSet as undefined. Note that this matches Edge's vertical tabs. <img width="594" alt="image" src="https://user-images.githubusercontent.com/86412703/151294165-a1aaef76-7e91-4427-b42a-702bfc6a7fc5.png"> Thanks :):
claunia commented 2026-01-31 04:28:29 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jan 28, 2022):

@v-rpundir Thanks!

I tried setting fixing SizeOfSet and PositionInSet manually. That's not working.

I've reached out to the XAML team here, as this is an upstream issue that we are blocked by. We're going to have to tag this one as a "tracking external" bug.

@carlos-zamora commented on GitHub (Jan 28, 2022): @v-rpundir Thanks! I tried setting fixing `SizeOfSet` and `PositionInSet` manually. That's not working. I've reached out to the XAML team [here](https://github.com/microsoft/microsoft-ui-xaml/issues/1971#issuecomment-1024621245), as this is an upstream issue that we are blocked by. We're going to have to tag this one as a "tracking external" bug.
claunia commented 2026-01-31 04:28:29 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jan 28, 2022):

Nevermind! Worked with the XAML team and found something that works. This'll be fixed by #12286.

@carlos-zamora commented on GitHub (Jan 28, 2022): Nevermind! Worked with the XAML team and found something that works. This'll be fixed by #12286.
claunia commented 2026-01-31 04:28:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 7, 2022):

Closing as fixed in Windows Terminal Preview Version: 1.13.10336.0

@ghost commented on GitHub (Feb 7, 2022): Closing as fixed in Windows Terminal Preview Version: 1.13.10336.0
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11ySev2 A11yWCAG Area-Accessibility Area-SettingsUI HCL-E+D HCL-WindowsTerminal Issue-Bug Priority-2 Product-Terminal Resolution-Fix-Committed Tracking-External WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15096
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?