starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Some color conflicts with PS and PWSH coloring of command line args #15132

New Issue
Closed
opened 2026-01-31 04:29:27 +00:00 by claunia · 11 comments
claunia commented 2026-01-31 04:29:27 +00:00
Owner
Copy Link

Originally created by @vefatica on GitHub (Sep 7, 2021).

Windows Terminal version (or Windows build number)

Microsoft Windows 10 Pro for Workstations 10.0.19043.1165 (2009, 21H1) Windows Terminal Preview 1.11.2421.0

Other Software

Powershell, PWSH

Steps to reproduce

In WT, Powershell or PWSH, with "One Half Light" or "Solarized Light", type a command with a decimal number as an argument.

Expected Behavior

The decimal number argument is visible.

Actual Behavior

The argument is not visible. I imagine PS/PWSH isn't scheme-aware and is giving it a color equal to the background color. And I imagine it's not WT's problem.

BTW, WT doesn't automatically find PWSH (Powershell 7), does it?

Originally created by @vefatica on GitHub (Sep 7, 2021). ### Windows Terminal version (or Windows build number) Microsoft Windows 10 Pro for Workstations 10.0.19043.1165 (2009, 21H1) Windows Terminal Preview 1.11.2421.0 ### Other Software Powershell, PWSH ### Steps to reproduce In WT, Powershell or PWSH, with "One Half Light" or "Solarized Light", type a command with a decimal number as an argument. ### Expected Behavior The decimal number argument is visible. ### Actual Behavior The argument is not visible. I imagine PS/PWSH isn't scheme-aware and is giving it a color equal to the background color. And I imagine it's not WT's problem. BTW, WT doesn't automatically find PWSH (Powershell 7), does it?
claunia added the Resolution-Duplicate label 2026-01-31 04:29:27 +00:00
claunia commented 2026-01-31 04:29:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 7, 2021):

DAYS SINCE I'VE REGRETTED SHIPPING SOLARIZED: 126 0

@zadjii-msft commented on GitHub (Sep 7, 2021): ### [DAYS SINCE I'VE REGRETTED SHIPPING SOLARIZED: ~~126~~ 0](https://github.com/microsoft/terminal/issues/10027#issuecomment-831900824)
claunia commented 2026-01-31 04:29:28 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 7, 2021):

While I weep about Solarized . . .

BTW, WT doesn't automatically find PWSH (Powershell 7), does it?

It should, if it is installed in a normal place. Knowing you (and the wild things you do), you probably have it installed to Q:\ somewhere.

@DHowett commented on GitHub (Sep 7, 2021): While I weep about Solarized . . . > BTW, WT doesn't automatically find PWSH (Powershell 7), does it? It should, _if_ it is installed in a normal place. Knowing you (and the wild things you do), you probably have it installed to `Q:\` somewhere.
claunia commented 2026-01-31 04:29:28 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Sep 7, 2021):

Knowing you (and the wild things you do), you probably have it installed to Q:\ somewhere.

Yup, I do things like that, but I think I accepted the default location. It's in

v:\> which pwsh
pwsh is an external : C:\Program Files\PowerShell\7\pwsh.EXE

WT didn't/doesn't find it (that is, doesn't create a profile for it).

@vefatica commented on GitHub (Sep 7, 2021): > Knowing you (and the wild things you do), you probably have it installed to Q:\ somewhere. Yup, I do things like that, but I think I accepted the default location. It's in ``` v:\> which pwsh pwsh is an external : C:\Program Files\PowerShell\7\pwsh.EXE ``` WT didn't/doesn't find it (that is, doesn't create a profile for it).
claunia commented 2026-01-31 04:29:28 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Sep 7, 2021):

hmmmm. have you put it in disabledProfileSources?

@DHowett commented on GitHub (Sep 7, 2021): hmmmm. have you put it in `disabledProfileSources`?
claunia commented 2026-01-31 04:29:29 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Sep 7, 2021):

I have these.

    "disabledProfileSources": 
    [
        "Windows.Terminal.Wsl",
        "Windows.Terminal.Azure",
        "Windows.Terminal.PowershellCore"
    ],

I mentioned in another thread (two weeks ago, no respones) that if I'm using an unzipped-only install of WT[P] and I go from the settings UI to settings.json and comment those six lines, WT disappears when I save it in the editor.

@vefatica commented on GitHub (Sep 7, 2021): I have these. ``` "disabledProfileSources": [ "Windows.Terminal.Wsl", "Windows.Terminal.Azure", "Windows.Terminal.PowershellCore" ], ``` I mentioned in another thread (two weeks ago, no respones) that if I'm using an unzipped-only install of WT[P] and I go from the settings UI to settings.json and comment those six lines, WT disappears when I save it in the editor.
claunia commented 2026-01-31 04:29:29 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Sep 7, 2021):

Does "Windows.Terminal.PowershellCore" refer to both Powershells? I put something like that in settings.json when I first got WT. long before Powershell 7. But I didn't create a specific one after installing PWSH.

@vefatica commented on GitHub (Sep 7, 2021): Does `"Windows.Terminal.PowershellCore"` refer to both Powershells? I put something like that in settings.json when I first got WT. long before Powershell 7. But I didn't create a specific one after installing PWSH.
claunia commented 2026-01-31 04:29:29 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 8, 2021):

Does "Windows.Terminal.PowershellCore" refer to both Powershells?

The "Windows.Terminal.PowershellCore" generator is for all(?) versions of pwsh.exe, but not the powershell.exe (PowerShell 5) that ships with Windows.

In general, Solarized is just a bad scheme, and we feel bad for shipping it, and it shouldn't be used with PowerShell. We're gonna make it better in /dup #2638, and hopefully just silently remove it in /dup #6997

@zadjii-msft commented on GitHub (Sep 8, 2021): > Does `"Windows.Terminal.PowershellCore"` refer to both Powershells? The `"Windows.Terminal.PowershellCore"` generator is for all(?) versions of `pwsh.exe`, but not the powershell.exe (PowerShell 5) that ships with Windows. <hr> In general, Solarized is just a bad scheme, and we feel bad for shipping it, and it shouldn't be used with PowerShell. We're gonna make it better in /dup #2638, and hopefully just silently remove it in /dup #6997
claunia commented 2026-01-31 04:29:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Sep 8, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Sep 8, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 04:29:29 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Sep 8, 2021):

What would one put in "disabledProfileSources" to disable the powershell.exe one? The docs mention only these:

"Windows.Terminal.Wsl", "Windows.Terminal.Azure", and/or "Windows.Terminal.PowershellCore"

A quick question ... WT redraws the viewport and history upon an OSC4/10/11/12(that's nice). If I'm sending 19 of them would I gain anything by putting them all in a big string and calling WriteConsoleW only once (as opposed to doing them one at a time in a loop)?

Thanks!

@vefatica commented on GitHub (Sep 8, 2021): What would one put in "disabledProfileSources" to disable the powershell.exe one? The docs mention only these: `"Windows.Terminal.Wsl", "Windows.Terminal.Azure", and/or "Windows.Terminal.PowershellCore"` A quick question ... WT redraws the viewport and history upon an OSC4/10/11/12(that's nice). If I'm sending 19 of them would I gain anything by putting them all in a big string and calling WriteConsoleW only once (as opposed to doing them one at a time in a loop)? Thanks!
claunia commented 2026-01-31 04:29:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 8, 2021):

The powershell.exe profile isn't dynamic, it's a hardcoded default profile. You'll have to set hidden: true on that one manually.

A quick question ... WT redraws the viewport and history upon an OSC4/10/11/12(that's nice). If I'm sending 19 of them would I gain anything by putting them all in a big string and calling WriteConsoleW only once (as opposed to doing them one at a time in a loop)?

Maybe, but probably not? ConPTY and Terminal both throttle frames, so at the end of the day, the screen's only going to get updated once per 1/60th of a second, so there's only a marginal chance that the frame actually gets called in the middle of that output.

@zadjii-msft commented on GitHub (Sep 8, 2021): The `powershell.exe` profile isn't _dynamic_, it's a hardcoded default profile. You'll have to set `hidden: true` on that one manually. > A quick question ... WT redraws the viewport and history upon an OSC4/10/11/12(that's nice). If I'm sending 19 of them would I gain anything by putting them all in a big string and calling WriteConsoleW only once (as opposed to doing them one at a time in a loop)? Maybe, but probably not? ConPTY and Terminal both throttle frames, so at the end of the day, the screen's only going to get updated once per 1/60th of a second, so there's only a marginal chance that the frame actually gets called in the middle of that output.
claunia commented 2026-01-31 04:29:30 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Sep 8, 2021):

Aha! So it's not updated with every OSC (I should have figured that it was done at regular intervals). Thanks!

@vefatica commented on GitHub (Sep 8, 2021): Aha! So it's not updated with every OSC (I should have figured that it was done at regular intervals). Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15132
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?