starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

initialCols (and initialRows) have an off-by-padding error #1515

New Issue
Closed
opened 2026-01-30 22:29:21 +00:00 by claunia · 6 comments
claunia commented 2026-01-30 22:29:21 +00:00
Owner
Copy Link

Originally created by @adeolemon on GitHub (Jun 4, 2019).

Environment

Windows build number: 10.0.18908.1000
Windows Terminal version (if applicable): 880272c7483a3bb6893dbec3725d0eb7375ab78a

Steps to reproduce

  1. Set initialCols to 16
  2. Launch a new Terminal
  3. echo 0123456789abcdef

Expected behavior

echo's output oughtta fit in one line

Actual behavior

0123456789abcde
f
Originally created by @adeolemon on GitHub (Jun 4, 2019). # Environment ``` Windows build number: 10.0.18908.1000 Windows Terminal version (if applicable): 880272c7483a3bb6893dbec3725d0eb7375ab78a ``` # Steps to reproduce 0. Set `initialCols` to `16` 0. Launch a new Terminal 0. `echo 0123456789abcdef` # Expected behavior `echo`'s output oughtta fit in one line # Actual behavior ``` 0123456789abcde f ```
claunia added the Help WantedArea-SettingsIssue-BugNeeds-Tag-FixProduct-Terminal labels 2026-01-30 22:29:21 +00:00
claunia commented 2026-01-30 22:29:22 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 5, 2019):

Yea this is definitely wrong:
image

The area that you'd think is the rightmost column is actually the scrollbar. That space is always there, even if the scrollbar isn't expanded. That's maybe where I'd look to this being wrong.

@zadjii-msft commented on GitHub (Jun 5, 2019): Yea this is definitely wrong: ![image](https://user-images.githubusercontent.com/18356694/58961505-e040b480-876e-11e9-9172-4ecd4ebde10c.png) The area that you'd think is the rightmost column is actually the scrollbar. That space is always there, even if the scrollbar isn't expanded. That's maybe where I'd look to this being wrong.
claunia commented 2026-01-30 22:29:22 +00:00
Author
Owner
Copy Link

@Summon528 commented on GitHub (Jun 5, 2019):

The problem here is: what's the intended behavior for the hidden scroll bar. Is it intended to cover some text when expanded or is it intended to always have a reserved space? If it is (2) then the fix will be pretty easy, if it's (1) then we might need to modify the view tree

Edit: NVM I thought we had an always show scrollbar option

@Summon528 commented on GitHub (Jun 5, 2019): The problem here is: what's the intended behavior for the hidden scroll bar. Is it intended to cover some text when expanded or is it intended to always have a reserved space? If it is (2) then the fix will be pretty easy, if it's (1) then we might need to modify the view tree Edit: NVM I thought we had an always show scrollbar option
claunia commented 2026-01-30 22:29:22 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 5, 2019):

I think the scrollbar space is always supposed to be reserved (ie case number 2). We tried implementing a alwaysShowScrollbar option before we released as open-source, however, the UWP ScrollBar doesn't actually support a scrollbar styled like that. We'd have to roll our own implementation if we wanted that.

@zadjii-msft commented on GitHub (Jun 5, 2019): I think the scrollbar space is always supposed to be reserved (ie case number 2). We tried implementing a alwaysShowScrollbar option before we released as open-source, however, the UWP ScrollBar doesn't actually support a scrollbar styled like that. We'd have to roll our own implementation if we wanted that.
claunia commented 2026-01-30 22:29:23 +00:00
Author
Owner
Copy Link

@Summon528 commented on GitHub (Jun 5, 2019):

Weird enough I can't repro this anymore, although I think I did nothing. ( I can repro with padding set but I think that is intended? )

@Summon528 commented on GitHub (Jun 5, 2019): Weird enough I can't repro this anymore, although I think I did nothing. ( I can repro with padding set but I think that is intended? )
claunia commented 2026-01-30 22:29:23 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 5, 2019):

Ahhh, that's probably it. I have 2 padding on all sides set too. That's definitely not by design - we should be accounting for the amount of padding when calculating the initial window size.

@zadjii-msft commented on GitHub (Jun 5, 2019): Ahhh, that's probably it. I have 2 padding on all sides set too. That's definitely not by design - we should be accounting for the amount of padding when calculating the initial window size.
claunia commented 2026-01-30 22:29:23 +00:00
Author
Owner
Copy Link

@adeolemon commented on GitHub (Jun 5, 2019):

Yep, padding here too: "padding": "2, 2, 2, 2"

@adeolemon commented on GitHub (Jun 5, 2019): Yep, padding here too: `"padding": "2, 2, 2, 2"`
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Help Wanted Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1515
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?