starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

More detailed error on keybinding errors #15203

New Issue
Closed
opened 2026-01-31 04:31:21 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 04:31:21 +00:00
Owner
Copy Link

Originally created by @joca-bt on GitHub (Sep 14, 2021).

After updating I got an error message saving my settings:

error message

It would be helpful if the error message showed either the actions or the keybindings causing the error. Otherwise the user has to guess.

Originally created by @joca-bt on GitHub (Sep 14, 2021). After updating I got an error message saving my settings: <img width="368" alt="error message" src="https://user-images.githubusercontent.com/1297942/133312489-2bc42d00-ce0c-4a71-a132-ff8f53e096a7.png"> It would be helpful if the error message showed either the actions or the keybindings causing the error. Otherwise the user has to guess.
claunia commented 2026-01-31 04:31:23 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 14, 2021):

After updating

Curious, usually I wouldn't expect this to happen on an update. Could you share your settings.json and Terminal version? I'm curious myself what param became required.

@zadjii-msft commented on GitHub (Sep 14, 2021): > After updating Curious, usually I wouldn't expect this to happen on an update. Could you share your `settings.json` and Terminal version? I'm curious myself what param became required.
claunia commented 2026-01-31 04:31:23 +00:00
Author
Owner
Copy Link

@joca-bt commented on GitHub (Sep 14, 2021):

Version: 1.10.2383.0

I only noticed when updating to 1.10 but I believe it started happening after updating to 1.09. I originally defined the keybindings using 1.08 or 1.07, I don't remember which one.

The offending keybindings:

        { "command": { "action": "findMatch", "direction": "next" }, "keys": "ctrl+shift+s" },
        { "command": { "action": "findMatch", "direction": "prev" }, "keys": "ctrl+shift+r" },
@joca-bt commented on GitHub (Sep 14, 2021): Version: 1.10.2383.0 I only noticed when updating to 1.10 but I believe it started happening after updating to 1.09. I originally defined the keybindings using 1.08 or 1.07, I don't remember which one. The offending keybindings: ``` { "command": { "action": "findMatch", "direction": "next" }, "keys": "ctrl+shift+s" }, { "command": { "action": "findMatch", "direction": "prev" }, "keys": "ctrl+shift+r" }, ```
claunia commented 2026-01-31 04:31:24 +00:00
Author
Owner
Copy Link

@joca-bt commented on GitHub (Sep 14, 2021):

By "when updating" I mean "I updated the terminal, restarted it, and then saved my current settings to check if everything was alright and got that message".

@joca-bt commented on GitHub (Sep 14, 2021): By "when updating" I mean "I updated the terminal, restarted it, and then saved my current settings to check if everything was alright and got that message".
claunia commented 2026-01-31 04:31:24 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 14, 2021):

Weird. I just copy pasted those two into a fresh 1.10 and saved the settings, then rebooted the terminal, and the warning didn't appear (either on hot-reload or reboot).

@zadjii-msft commented on GitHub (Sep 14, 2021): Weird. I just copy pasted those two into a fresh 1.10 and saved the settings, then rebooted the terminal, and the warning didn't appear (either on hot-reload or reboot).
claunia commented 2026-01-31 04:31:25 +00:00
Author
Owner
Copy Link

@joca-bt commented on GitHub (Sep 14, 2021):

Close all terminals, replace your settings.json with the code from below, launch a new terminal, and then save settings.

{
    "$schema": "https://aka.ms/terminal-profiles-schema/",

    "defaultProfile": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",

    "profiles":
    {
        "list":
        [
            {
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "name": "Command Prompt"
            }
        ]
    },

    "actions":
    [
        { "command": "find", "keys": "ctrl+f" },
        { "command": { "action": "findMatch", "direction": "next" }, "keys": "ctrl+shift+s" },
        { "command": { "action": "findMatch", "direction": "prev" }, "keys": "ctrl+shift+r" }
    ]
}
@joca-bt commented on GitHub (Sep 14, 2021): Close all terminals, replace your `settings.json` with the code from below, launch a new terminal, and then save settings. ``` { "$schema": "https://aka.ms/terminal-profiles-schema/", "defaultProfile": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}", "profiles": { "list": [ { "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}", "name": "Command Prompt" } ] }, "actions": [ { "command": "find", "keys": "ctrl+f" }, { "command": { "action": "findMatch", "direction": "next" }, "keys": "ctrl+shift+s" }, { "command": { "action": "findMatch", "direction": "prev" }, "keys": "ctrl+shift+r" } ] } ```
claunia commented 2026-01-31 04:31:25 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 14, 2021):

and then save settings.

YEP that'll do it

image

we're not re-serializing findMatch args correctly. Thanks!

@zadjii-msft commented on GitHub (Sep 14, 2021): > and then save settings. YEP that'll do it ![image](https://user-images.githubusercontent.com/18356694/133323912-f50729c6-a979-45f1-9c82-0638b48d5ef6.png) we're not re-serializing `findMatch` args correctly. Thanks!
claunia commented 2026-01-31 04:31:25 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 4, 2021):

:tada:This issue was addressed in #11233, which has now been successfully released as Windows Terminal v1.10.2714.0.🎉

Handy links:

@ghost commented on GitHub (Oct 4, 2021): :tada:This issue was addressed in #11233, which has now been successfully released as `Windows Terminal v1.10.2714.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.10.2714.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 04:31:26 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 4, 2021):

:tada:This issue was addressed in #11233, which has now been successfully released as Windows Terminal Preview v1.11.2731.0.🎉

Handy links:

@ghost commented on GitHub (Oct 4, 2021): :tada:This issue was addressed in #11233, which has now been successfully released as `Windows Terminal Preview v1.11.2731.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.11.2731.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Help Wanted Issue-Bug Needs-Triage Priority-1 Product-Terminal Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15203
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?