Pasting does not clear the rendered selection #15210

Closed
opened 2026-01-31 04:31:30 +00:00 by claunia · 10 comments
Owner

Originally created by @carlos-zamora on GitHub (Sep 14, 2021).

Windows Terminal version (or Windows build number)

1.10.2383.0

Other Software

None

Steps to reproduce

  1. Create a selection
  2. execute paste keybinding

Expected Behavior

Paste should clear the selection and inject the pasted text.

Actual Behavior

The text is pasted, but the selection is not cleared.

Interestingly, executing the copy action (with ctrl+c, for example) passes the keybinding through. This suggests that the selection was cleared, but we're not telling the renderer to TriggerSelection() on a paste operation.

Originally created by @carlos-zamora on GitHub (Sep 14, 2021). ### Windows Terminal version (or Windows build number) 1.10.2383.0 ### Other Software None ### Steps to reproduce 1. Create a selection 2. execute `paste` keybinding ### Expected Behavior Paste should clear the selection and inject the pasted text. ### Actual Behavior The text is pasted, but the selection is not cleared. Interestingly, executing the copy action (with <kbd>ctrl+c</kbd>, for example) passes the keybinding through. This suggests that the selection was cleared, but we're not telling the renderer to `TriggerSelection()` on a paste operation.
Author
Owner

@carlos-zamora commented on GitHub (Sep 14, 2021):

NOTE: This affects Stable and Preview so we should make sure to apply the fix to both.

@carlos-zamora commented on GitHub (Sep 14, 2021): NOTE: This affects Stable and Preview so we should make sure to apply the fix to both.
Author
Owner

@fischerdouglas commented on GitHub (Sep 17, 2021):

Hello @carlos-zamora !

I'm using 1.11.2421.0

I tried to reproduce the issue, and I wasn't able to...

I tried with CTR+V , CTR+SHFT+V , SHIFT+INSERT
I also tried with tabs of Powershell7, Powershell5, WSL Ubuntu.

@fischerdouglas commented on GitHub (Sep 17, 2021): Hello @carlos-zamora ! I'm using 1.11.2421.0 I tried to reproduce the issue, and I wasn't able to... I tried with CTR+V , CTR+SHFT+V , SHIFT+INSERT I also tried with tabs of Powershell7, Powershell5, WSL Ubuntu.
Author
Owner

@carlos-zamora commented on GitHub (Sep 17, 2021):

I'm still able to repro the issue on 1.11.2421.
I have paste bound to ctrl+v
bug demo
.

@carlos-zamora commented on GitHub (Sep 17, 2021): I'm still able to repro the issue on 1.11.2421. I have `paste` bound to <kbd>ctrl+v</kbd> ![bug demo](https://user-images.githubusercontent.com/11050425/133851607-aaa952e6-15aa-444d-8f20-0603337abfbe.gif) .
Author
Owner

@DHowett commented on GitHub (Sep 17, 2021):

I'd like to be totally clear on this. How are you pasting, @carlos-zamora?

@DHowett commented on GitHub (Sep 17, 2021): I'd like to be totally clear on this. How are you pasting, @carlos-zamora?
Author
Owner

@carlos-zamora commented on GitHub (Sep 17, 2021):

I'd like to be totally clear on this. How are you pasting, @carlos-zamora?

ctrl+v which is bound to the paste action.

@carlos-zamora commented on GitHub (Sep 17, 2021): > I'd like to be totally clear on this. How are you pasting, @carlos-zamora? <kbd>ctrl+v</kbd> which is bound to the `paste` action.
Author
Owner

@fischerdouglas commented on GitHub (Sep 20, 2021):

image

WindowsTerminalActionPasteRemovingSelection

image

Same is reproduced Powershell 5, Command Prompt, WSL Ubuntu.

@fischerdouglas commented on GitHub (Sep 20, 2021): ![image](https://user-images.githubusercontent.com/7989601/133990595-0ccb3426-2a73-4234-a4ea-b2ca39395608.png) ![WindowsTerminalActionPasteRemovingSelection](https://user-images.githubusercontent.com/7989601/133990556-e6ae85ff-84a8-40f2-9ddd-84a7bbcc1e40.gif) ![image](https://user-images.githubusercontent.com/7989601/133991212-17510d7b-076a-4c3e-ac17-95415a2b6668.png) Same is reproduced Powershell 5, Command Prompt, WSL Ubuntu.
Author
Owner

@zadjii-msft commented on GitHub (Sep 20, 2021):

gh-11227

I can definitely repro this on 1.12

@zadjii-msft commented on GitHub (Sep 20, 2021): ![gh-11227](https://user-images.githubusercontent.com/18356694/134003536-a66df915-872c-4a43-8a4e-96093b620eac.gif) I can definitely repro this on 1.12
Author
Owner

@ghost commented on GitHub (Oct 4, 2021):

:tada:This issue was addressed in #11286, which has now been successfully released as Windows Terminal v1.10.2714.0.🎉

Handy links:

@ghost commented on GitHub (Oct 4, 2021): :tada:This issue was addressed in #11286, which has now been successfully released as `Windows Terminal v1.10.2714.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.10.2714.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (Oct 4, 2021):

:tada:This issue was addressed in #11286, which has now been successfully released as Windows Terminal Preview v1.11.2731.0.🎉

Handy links:

@ghost commented on GitHub (Oct 4, 2021): :tada:This issue was addressed in #11286, which has now been successfully released as `Windows Terminal Preview v1.11.2731.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.11.2731.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (Oct 20, 2021):

:tada:This issue was addressed in #11286, which has now been successfully released as Windows Terminal Preview v1.12.2922.0.🎉

Handy links:

@ghost commented on GitHub (Oct 20, 2021): :tada:This issue was addressed in #11286, which has now been successfully released as `Windows Terminal Preview v1.12.2922.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.12.2922.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15210