starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Settings]: Radio buttons are not associated with its main label throughout the settings page. #15235

New Issue
Closed
opened 2026-01-31 04:32:18 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 04:32:18 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Sep 16, 2021).

Windows Terminal version (or Windows build number)

1.10.2383.0

Other Software

Test Environment:
OS: Windows 11 Version 21H2 (OS Build 22000.168)
Screen Reader: Narrator
Tool: Accessibility Insight for Windows

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using "Ctrl + ',' ".
  3. Open Narrator using 'Win + Ctrl+ Enter' key.
  4. Navigate through all radio groups through Settings page and observe the issue.

User Experience:
Screen Reader user are impacted here as they will not be able to know the exact purpose of radio buttons as main label is not announced to them.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships

Attachments:
Radio buttons are not associated with its main label..zip

Expected Behavior

Radio buttons should be associated with its main label throughout the Settings page. i.e. For 'Default' radio button with group label 'Launch mode' Screen Reader should announce 'Launch mode group Default radio button selected 1 of 5'

Actual Behavior

Radio buttons is not associated with its main label throughout the Settings page. i.e. For 'Default' radio button with group label 'Launch mode' Screen Reader is announcing 'Default radio button selected 1 of 5'

Observation: Same issue repro with NVDA Screen Reader.

Originally created by @ghost on GitHub (Sep 16, 2021). ### Windows Terminal version (or Windows build number) 1.10.2383.0 ### Other Software Test Environment: OS: Windows 11 Version 21H2 (OS Build 22000.168) Screen Reader: Narrator Tool: Accessibility Insight for Windows ### Steps to reproduce Repro Steps: 1. Open Windows Terminal. 2. Open Settings page using "Ctrl + ',' ". 3. Open Narrator using 'Win + Ctrl+ Enter' key. 3. Navigate through all radio groups through Settings page and observe the issue. **User Experience:** Screen Reader user are impacted here as they will not be able to know the exact purpose of radio buttons as main label is not announced to them. **Guideline Reference:** https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships **Attachments:** [Radio buttons are not associated with its main label..zip](https://github.com/microsoft/terminal/files/7176480/Radio.buttons.are.not.associated.with.its.main.label.zip) ### Expected Behavior Radio buttons should be associated with its main label throughout the Settings page. i.e. For 'Default' radio button with group label 'Launch mode' Screen Reader should announce 'Launch mode group Default radio button selected 1 of 5' ### Actual Behavior Radio buttons is not associated with its main label throughout the Settings page. i.e. For 'Default' radio button with group label 'Launch mode' Screen Reader is announcing 'Default radio button selected 1 of 5' Observation: Same issue repro with NVDA Screen Reader.
claunia commented 2026-01-31 04:32:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 5, 2021):

This looks like #9567 which is actually tracked by the upstream https://github.com/microsoft/microsoft-ui-xaml/issues/3183. @v-rpundir can you confirm?

@zadjii-msft commented on GitHub (Oct 5, 2021): This looks like #9567 which is actually tracked by the upstream https://github.com/microsoft/microsoft-ui-xaml/issues/3183. @v-rpundir can you confirm?
claunia commented 2026-01-31 04:32:20 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 6, 2021):

@zadjii-msft Yeah it is similar to #9567 but the Upstream bug is closed as fixed now.

@ghost commented on GitHub (Oct 6, 2021): @zadjii-msft Yeah it is similar to #9567 but the Upstream bug is closed as fixed now.
claunia commented 2026-01-31 04:32:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 6, 2021):

Looks like the upstream bug was fixed in https://github.com/microsoft/microsoft-ui-xaml/pull/5094 which was in WinUI 2.6.1, so hopefully the 1.12 builds of the Terminal (which moved to WinUI 2.7) should have the fix.

Looks like it's still not grouping them though:
image

Maybe there's something else we need to do to manually combine these now.

@zadjii-msft commented on GitHub (Oct 6, 2021): Looks like the upstream bug was fixed in https://github.com/microsoft/microsoft-ui-xaml/pull/5094 which was in WinUI 2.6.1, so hopefully the 1.12 builds of the Terminal (which moved to WinUI 2.7) should have the fix. Looks like it's still not grouping them though: ![image](https://user-images.githubusercontent.com/18356694/136196083-515ffb9b-e051-4a36-8d3f-c64faf372a9f.png) Maybe there's something else we need to do to manually combine these now.
claunia commented 2026-01-31 04:32:21 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 6, 2021):

Looks like it's still not grouping them though:

I suspect we need to do something special with SettingContainer, assuming that this is using it

@DHowett commented on GitHub (Oct 6, 2021): > Looks like it's still not grouping them though: I suspect we need to do something special with SettingContainer, _assuming that this is using it_
claunia commented 2026-01-31 04:32:21 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 27, 2022):

@v-rpundir I believe this was fixed in Preview v1.12.2922.0/Stable v1.11.2921.0, could you confirm?

@zadjii-msft commented on GitHub (Jan 27, 2022): @v-rpundir I believe this was fixed in `Preview v1.12.2922.0`/`Stable v1.11.2921.0`, could you confirm?
claunia commented 2026-01-31 04:32:21 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 27, 2022):

Closing as the bug as fixed in Windows Terminal Preview Version: 1.12.3472.0

@ghost commented on GitHub (Jan 27, 2022): Closing as the bug as fixed in Windows Terminal Preview Version: 1.12.3472.0
claunia commented 2026-01-31 04:32:21 +00:00
Author
Owner
Copy Link

@Priyanka-Chauhan123 commented on GitHub (Jan 8, 2024):

Closing the bug as UI has been changed.

@Priyanka-Chauhan123 commented on GitHub (Jan 8, 2024): Closing the bug as UI has been changed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11ySev3 A11yTTValidated A11yWCAG Area-Accessibility HCL-E+D HCL-WindowsTerminal In-PR Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15235
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?