starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Code Health: duplicate end of statement semicolon #1532

New Issue
Closed
opened 2026-01-30 22:29:40 +00:00 by claunia · 1 comment
claunia commented 2026-01-30 22:29:40 +00:00
Owner
Copy Link

Originally created by @dlong11 on GitHub (Jun 6, 2019).

Originally assigned to: @adiviness on GitHub.

Very Minor cleanup. duplicate end of statement semicolon

  • src\host\conareainfo.cpp(187): 
    SMALL_RECT OldRegion = _caInfo.rcViewCaWindow;;
  • src\host\consoleInformation.cpp(388): 
    ci.Attributes = GenerateLegacyAttributes(attr);;
  • src\interactivity\base\InteractivityFactory.cpp(349): 
    NTSTATUS status = ApiDetector::DetectNtUserWindow(&level);;
  • src\interactivity\win32\screenInfoUiaProvider.cpp(534): 
    HRESULT hr = S_OK;;
  • src\interactivity\win32\UiaTextRange.cpp(151): 
    UiaTextRange* range = nullptr;;

src\host\conareainfo.cpp(187): SMALL_RECT OldRegion = _caInfo.rcViewCaWindow;;
src\host\consoleInformation.cpp(388): ci.Attributes = GenerateLegacyAttributes(attr);;
src\interactivity\base\InteractivityFactory.cpp(349): NTSTATUS status = ApiDetector::DetectNtUserWindow(&level);;
src\interactivity\win32\screenInfoUiaProvider.cpp(534): HRESULT hr = S_OK;;
src\interactivity\win32\UiaTextRange.cpp(151): UiaTextRange* range = nullptr;;

Found in the clang-format PR #1141

Originally created by @dlong11 on GitHub (Jun 6, 2019). Originally assigned to: @adiviness on GitHub. Very Minor cleanup. duplicate end of statement semicolon * [x] `src\host\conareainfo.cpp(187)`: ```c++ SMALL_RECT OldRegion = _caInfo.rcViewCaWindow;; ``` * [x] `src\host\consoleInformation.cpp(388)`: ```c++ ci.Attributes = GenerateLegacyAttributes(attr);; ``` * [x] `src\interactivity\base\InteractivityFactory.cpp(349)`: ```c++ NTSTATUS status = ApiDetector::DetectNtUserWindow(&level);; ``` * [x] `src\interactivity\win32\screenInfoUiaProvider.cpp(534)`: ```c++ HRESULT hr = S_OK;; ``` * [x] `src\interactivity\win32\UiaTextRange.cpp(151)`: ```c++ UiaTextRange* range = nullptr;; ``` src\host\conareainfo.cpp(187): SMALL_RECT OldRegion = _caInfo.rcViewCaWindow;; src\host\consoleInformation.cpp(388): ci.Attributes = GenerateLegacyAttributes(attr);; src\interactivity\base\InteractivityFactory.cpp(349): NTSTATUS status = ApiDetector::DetectNtUserWindow(&level);; src\interactivity\win32\screenInfoUiaProvider.cpp(534): HRESULT hr = S_OK;; src\interactivity\win32\UiaTextRange.cpp(151): UiaTextRange* range = nullptr;; Found in the clang-format PR #1141
claunia added the Product-ConhostIssue-TaskNeeds-Tag-FixArea-CodeHealth labels 2026-01-30 22:29:40 +00:00
claunia commented 2026-01-30 22:29:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 22, 2021):

Hey look, these have all been cleaned up already. Neat! Probably by clang-format.

@zadjii-msft commented on GitHub (Nov 22, 2021): Hey look, these have all been cleaned up already. Neat! Probably by clang-format.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Task Needs-Tag-Fix Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1532
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?