starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

#7422 may have regressed - click on the top pixel of a tab when maximized #15320

New Issue
Open
opened 2026-01-31 04:34:56 +00:00 by claunia · 16 comments
claunia commented 2026-01-31 04:34:56 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Sep 22, 2021).

From discussion on a0670cb6b3

Interestingly, the compensation for GH #10746 might have caused 10746 to stop functioning by pushing the application body down one more pixel. I can't get the tab bar hit targets at the top of the screen when maximized to work any longer.

@DHowett If you've got a repro for that, can you fix that again? I checked out this PR when it was first opened to make sure that one was still fixed, but I guess I didn't have my monitors in the very peculiar config that repro'd #7422 in the first place.

This might also be the #11294 issue, but unlikely Dustin had the MUX commit at the time.

This also applies to the new tab dropdown combo button.

Originally created by @zadjii-msft on GitHub (Sep 22, 2021). From discussion on a0670cb6b3e57dde525af1a04563e94ce80b5390 > Interestingly, the compensation for GH #10746 might have caused 10746 to stop functioning by pushing the application body down one more pixel. I can't get the tab bar hit targets at the top of the screen when maximized to work any longer. > @DHowett If you've got a repro for that, can you fix that again? I checked out this PR when it was first opened to make sure that one was still fixed, but I guess I didn't have my monitors in the very peculiar config that repro'd #7422 in the first place. This might also be the #11294 issue, but unlikely Dustin had the MUX commit at the time. ---- This also applies to the new tab dropdown combo button.
claunia commented 2026-01-31 04:34:58 +00:00
Author
Owner
Copy Link

@sigprof commented on GitHub (Nov 13, 2021):

I see a problematic behavior which does not exactly match #7422 — for me the minimize/maximize/close buttons behave normally, but anything on the tab bar (including the new tab button and the dropdown arrow) cannot be activated when clicking exactly at the top of the screen when the window is maximized. Clicks in the problem area above the tab bar seem to be completely ignored (a double click does not result in restoring the window size, a right click does not show the window menu or anything else).

System information:

  • Windows Terminal Preview 1.12.2931.0
    • Note that the release version (Windows Terminal 1.11.2921.0) does not exhibit the problematic behavior — in that version clicks at the top of the screen work as expected.
  • Windows 10 21H1 (19043.1348, Windows Feature Experience Pack 120.2212.3920.0)
  • A single 4K monitor (Iiyama XUB2792UHSU, 3860 × 2160, scaling set to 200%)
  • Task bar at the right edge of the screen (width set to minimum possible, which is 124 px in my config)
@sigprof commented on GitHub (Nov 13, 2021): I see a problematic behavior which does not exactly match #7422 — for me the minimize/maximize/close buttons behave normally, but anything on the tab bar (including the new tab button and the dropdown arrow) cannot be activated when clicking exactly at the top of the screen when the window is maximized. Clicks in the problem area above the tab bar seem to be completely ignored (a double click does not result in restoring the window size, a right click does not show the window menu or anything else). System information: * Windows Terminal Preview 1.12.2931.0 * Note that the release version (Windows Terminal 1.11.2921.0) does not exhibit the problematic behavior — in that version clicks at the top of the screen work as expected. * Windows 10 21H1 (19043.1348, Windows Feature Experience Pack 120.2212.3920.0) * A single 4K monitor (Iiyama XUB2792UHSU, 3860 × 2160, scaling set to 200%) * Task bar at the right edge of the screen (width set to minimum possible, which is 124 px in my config)
claunia commented 2026-01-31 04:34:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 14, 2022):

@kzshantonu what does your display layout look like in the Settings app, under System>Display?

@zadjii-msft commented on GitHub (Feb 14, 2022): @kzshantonu what does your display layout look like in the Settings app, under System>Display?
claunia commented 2026-01-31 04:34:59 +00:00
Author
Owner
Copy Link

@kzshantonu commented on GitHub (Feb 14, 2022):

@zadjii-msft 150% scale, 2160x1440

@kzshantonu commented on GitHub (Feb 14, 2022): @zadjii-msft 150% scale, 2160x1440
claunia commented 2026-01-31 04:35:00 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 14, 2022):

Sorry, could you send me an actual screenshot of the little preview on that page? The last time this regressed, the actual alignment of the monitors was an influencing factor (which was insane). I just wanted to try and get a read if that would be an issue this time too.

@zadjii-msft commented on GitHub (Feb 14, 2022): Sorry, could you send me an actual screenshot of the little preview on that page? The last time this regressed, the actual alignment of the monitors was an influencing factor (which was insane). I just wanted to try and get a read if that would be an issue this time too.
claunia commented 2026-01-31 04:35:01 +00:00
Author
Owner
Copy Link

@kzshantonu commented on GitHub (Feb 14, 2022):

@zadjii-msft Single display

ApplicationFrameHost_tAqxD3oKll
@kzshantonu commented on GitHub (Feb 14, 2022): @zadjii-msft Single display <img width="711" alt="ApplicationFrameHost_tAqxD3oKll" src="https://user-images.githubusercontent.com/7745374/153964408-9e310187-ff9a-4921-b391-2211bc1fe785.png">
claunia commented 2026-01-31 04:35:01 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 15, 2022):

Welp. That's easier to set up the repro for, but alas I'm not seeing that. Any chance you've got the "auto hide taskbar" setting enabled?

@zadjii-msft commented on GitHub (Feb 15, 2022): Welp. That's easier to set up the repro for, but alas I'm not seeing that. Any chance you've got the "auto hide taskbar" setting enabled?
claunia commented 2026-01-31 04:35:02 +00:00
Author
Owner
Copy Link

@kzshantonu commented on GitHub (Feb 15, 2022):

@zadjii-msft no. But I do have a vertical left taskbar, since forever

@kzshantonu commented on GitHub (Feb 15, 2022): @zadjii-msft no. But I do have a vertical left taskbar, since forever
claunia commented 2026-01-31 04:35:03 +00:00
Author
Owner
Copy Link

@djp101 commented on GitHub (Sep 27, 2022):

Windows 11 Terminal Preview 1.16.2642.0 has this issue.
Resolution: 1920x1200
Scale: 150%
Orientation: Landscape

@djp101 commented on GitHub (Sep 27, 2022): Windows 11 Terminal Preview 1.16.2642.0 has this issue. Resolution: 1920x1200 Scale: 150% Orientation: Landscape
claunia commented 2026-01-31 04:35:04 +00:00
Author
Owner
Copy Link

@CactusPie commented on GitHub (Feb 8, 2023):

Same issue here
Windows 10 22H2
Terminal Version: 1.15.3465.0
Resolution: 1920x1080
Scale: 150%
Orientation: Landscape
Taskbar auto-hide is NOT enabled

The problem did not occur on one of the older versions, though unfortunately I can't remember which one it was

Edit: Still occurs on version 1.16.10261.0
My environment is multi monitor, the other two monitors use the same resolution, but with 100% scale - the problem doesn't occur on the other monitors.

@CactusPie commented on GitHub (Feb 8, 2023): Same issue here Windows 10 22H2 Terminal Version: 1.15.3465.0 Resolution: 1920x1080 Scale: 150% Orientation: Landscape Taskbar auto-hide is NOT enabled The problem did not occur on one of the older versions, though unfortunately I can't remember which one it was Edit: Still occurs on version 1.16.10261.0 My environment is multi monitor, the other two monitors use the same resolution, but with 100% scale - the problem doesn't occur on the other monitors.
claunia commented 2026-01-31 04:35:05 +00:00
Author
Owner
Copy Link

@djp101 commented on GitHub (Feb 8, 2023):

This issue also happens with the "plus" icon to open a new tab in Windows Terminal Version 1.15.3466.0, the "clickable" area should stretch up to top of the window border.

@djp101 commented on GitHub (Feb 8, 2023): This issue also happens with the "plus" icon to open a new tab in Windows Terminal Version 1.15.3466.0, the "clickable" area should stretch up to top of the window border.
claunia commented 2026-01-31 04:35:06 +00:00
Author
Owner
Copy Link

@LukeDearden commented on GitHub (Feb 20, 2023):

Same issue here
Windows 10 something or other
Terminal Version: 1.17.1023
Resolution: 1920x1080
Scale: 100%
Orientation: Landscape
Taskbar auto-hide is NOT enabled

Seems like it might be related to multiple monitors and their alignment in Display settings

like this there is a tiny gap
image

like this seems OK

image

@LukeDearden commented on GitHub (Feb 20, 2023): Same issue here Windows 10 something or other Terminal Version: 1.17.1023 Resolution: 1920x1080 Scale: 100% Orientation: Landscape Taskbar auto-hide is NOT enabled Seems like it might be related to multiple monitors and their alignment in Display settings like this there is a tiny gap ![image](https://user-images.githubusercontent.com/6813601/220124009-330b9d9f-ffd3-4f88-baac-a0c21bf37081.png) like this seems OK ![image](https://user-images.githubusercontent.com/6813601/220124193-e302887d-de27-4dad-bf1f-f8ef7df90de9.png)
claunia commented 2026-01-31 04:35:06 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 13, 2023):

72d0566fa6/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (L533-L559)

If I manually change that adjustment from -1 to -2, this seems to always work. Why though? What godforsaken rounding is causing this? And is this something that's silly and needs to be like, -3 at 250% scaling?

AND

just undoing the +1 as noted in a0670cb6b3 (commitcomment-56270857) didn't seem to change this at all.

@zadjii-msft commented on GitHub (Apr 13, 2023): https://github.com/microsoft/terminal/blob/72d0566fa6d681291799e59a69168fc0483d8277/src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp#L533-L559 If I manually change that adjustment from -1 to -2, this seems to always work. Why though? What godforsaken rounding is causing this? And is this something that's silly and needs to be like, -3 at 250% scaling? AND just undoing the +1 as noted in https://github.com/microsoft/terminal/commit/a0670cb6b3e57dde525af1a04563e94ce80b5390#commitcomment-56270857 didn't seem to change this at all.
claunia commented 2026-01-31 04:35:06 +00:00
Author
Owner
Copy Link

@vadimkantorov commented on GitHub (Apr 27, 2023):

Just hit this again (terminal Version: 1.16.10262.0), but don't think that my UI is 150% scaled

Not only I can't click, the topmost window pixel hover even stops highlighting the tab under the mouse cursor

@vadimkantorov commented on GitHub (Apr 27, 2023): Just hit this again (terminal Version: 1.16.10262.0), but don't think that my UI is 150% scaled Not only I can't click, the topmost window pixel hover even stops highlighting the tab under the mouse cursor
claunia commented 2026-01-31 04:35:07 +00:00
Author
Owner
Copy Link

@gknispel-australdx commented on GitHub (Jul 15, 2023):

If I understand this issue correctly it seems I'm affected by it too. I can't select tabs when the windows is maximized by clicking on the top line of the screen. I've got a 4k (3840x2400) 15.6 inches 16/10 screen configured with a scaling factor of 225%. I even thought it never worked until I recently used terminal on a low DPI screen, where it worked correctly.

@gknispel-australdx commented on GitHub (Jul 15, 2023): If I understand this issue correctly it seems I'm affected by it too. I can't select tabs when the windows is maximized by clicking on the top line of the screen. I've got a 4k (3840x2400) 15.6 inches 16/10 screen configured with a scaling factor of 225%. I even thought it never worked until I recently used terminal on a low DPI screen, where it worked correctly.
claunia commented 2026-01-31 04:35:07 +00:00
Author
Owner
Copy Link

@patricknelson commented on GitHub (Jan 16, 2025):

I noticed this when moving to a new computer. I have two laptops side by side, both running the exact same version of Windows 11 with the exact same monitors, the same scaling set to 175% and resolution of 3840 x 2160. They even share the exact same Windows Terminal settings.json file.

Old comp:
Windows: 10.0.22631.4602
Terminal: 1.21.3231.0

New comp (affected):
Windows: 10.0.22631.4602
Terminal: 1.12.10983.0 (older)

I used winget update terminal to update to the latest version and the issue now appears to be gone. 🎉

@patricknelson commented on GitHub (Jan 16, 2025): I noticed this when moving to a new computer. I have two laptops side by side, both running the exact same version of Windows 11 with the exact same monitors, the same scaling set to 175% and resolution of 3840 x 2160. They even share the exact same Windows Terminal `settings.json` file. **Old comp:** Windows: 10.0.22631.4602 Terminal: 1.**21**.3231.0 **New comp (affected):** Windows: 10.0.22631.4602 Terminal: 1.**12**.10983.0 _(older)_ I used `winget update terminal` to update to the latest version and the issue now appears to be gone. 🎉
claunia commented 2026-01-31 04:35:07 +00:00
Author
Owner
Copy Link

@vadimkantorov commented on GitHub (Aug 29, 2025):

Currently for me clicking on the top pixel of a tab when maximized - works fine. But clicking on the topmost pixel of buttons +V does not work in 1.22.12111.0

@vadimkantorov commented on GitHub (Aug 29, 2025): Currently for me clicking on the top pixel of a tab when maximized - works fine. But clicking on the topmost pixel of buttons `+V` does not work in 1.22.12111.0
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Bug Needs-Repro Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15320
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?