starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Keybinding editor could be clearer #15357

New Issue
Open
opened 2026-01-31 04:36:11 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 04:36:11 +00:00
Owner
Copy Link

Originally created by @elsaco on GitHub (Sep 27, 2021).

Windows Terminal version (or Windows build number)

Windows Terminal Preview Version: 1.11.2421.0

Other Software

No response

Steps to reproduce

  • open terminal settings
  • in "Actions" add a new command

Expected Behavior

  • new command edit working

Actual Behavior

new command edit not working

This is an example trying to add the first drop-down option "Break into the debugger". The intended key cord was "alt+shift+b". Notice how "a", "l", "t" are echoed in the entry box, then when trying to add "+" it just show "shift+plus":

https://user-images.githubusercontent.com/3933920/134908242-c3c6dc01-eae0-477c-b28a-4586eda3d9a2.mp4

Originally created by @elsaco on GitHub (Sep 27, 2021). ### Windows Terminal version (or Windows build number) Windows Terminal Preview Version: 1.11.2421.0 ### Other Software _No response_ ### Steps to reproduce - open terminal settings - in "Actions" add a new command ### Expected Behavior - new command edit working ### Actual Behavior new command edit not working This is an example trying to add the first drop-down option "Break into the debugger". The intended key cord was "alt+shift+b". Notice how "a", "l", "t" are echoed in the entry box, then when trying to add "+" it just show "shift+plus": https://user-images.githubusercontent.com/3933920/134908242-c3c6dc01-eae0-477c-b28a-4586eda3d9a2.mp4
claunia added the Issue-TaskProduct-TerminalArea-SettingsUI labels 2026-01-31 04:36:11 +00:00
claunia commented 2026-01-31 04:36:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 27, 2021):

Ah okay I see what's going on here. That's not a text entry field, you're supposed to just press the key chord you want to bind. So as you're typing alt, it's showing those keys one at a time. I think we've got an open issue already for making that more clear - something @carlos-zamora can link if he likes.

@zadjii-msft commented on GitHub (Sep 27, 2021): Ah okay I see what's going on here. That's not a text entry field, you're supposed to just press the key chord you want to bind. So as you're typing <kbd>a</kbd><kbd>l</kbd><kbd>t</kbd>, it's showing those keys one at a time. I think we've got an open issue already for making that more clear - something @carlos-zamora can link if he likes.
claunia commented 2026-01-31 04:36:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 27, 2021):

I'm reopening this to track the discussion we had as a team:

  • this box should automatically stop being in "edit mode" as soon as a non-modifier vkey is pressed
  • When modifiers are pressed/released in edit mode, then the box should show ctrl+shift+, and update in realtime

that'll help make this clearer

@zadjii-msft commented on GitHub (Sep 27, 2021): I'm reopening this to track the discussion we had as a team: * this box should automatically stop being in "edit mode" as soon as a non-modifier vkey is pressed * When modifiers are pressed/released in edit mode, then the box should show `ctrl+shift+`, and update in realtime that'll help make this clearer
claunia commented 2026-01-31 04:36:12 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 5, 2021):

@lhecker and I had a discussion about this weeks ago, and I think we never filed an issue for it.

Thanks!

@DHowett commented on GitHub (Oct 5, 2021): @lhecker and I had a discussion about this weeks ago, and I think we never filed an issue for it. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15357
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?