starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Schema type in "backgroundImage" property needs proper formatting #15363

New Issue
Closed
opened 2026-01-31 04:36:17 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 04:36:17 +00:00
Owner
Copy Link

Originally created by @elsaco on GitHub (Sep 28, 2021).

Windows Terminal version (or Windows build number)

1.11.2421.0

Other Software

No response

Steps to reproduce

  • open "doc/cascadia/profiles.schema.json"
  • inspect property beginning at line 1441
  • check type on line 1445

Expected Behavior

No response

Actual Behavior

  • type on line 1445 need fixing, see arrow

      "backgroundImage": {
    "description": "Sets the file location of the image to draw over the window background.",
    "oneOf": [
      {
        "type": ["string", null]  <-- null needs to be double quoted
      },
      {
        "enum": [
          "desktopWallpaper"
        ]
      }
Originally created by @elsaco on GitHub (Sep 28, 2021). ### Windows Terminal version (or Windows build number) 1.11.2421.0 ### Other Software _No response_ ### Steps to reproduce - open "doc/cascadia/profiles.schema.json" - inspect property beginning at line 1441 - check type on line 1445 ### Expected Behavior _No response_ ### Actual Behavior - type on line 1445 need fixing, see arrow "backgroundImage": { "description": "Sets the file location of the image to draw over the window background.", "oneOf": [ { "type": ["string", null] <-- null needs to be double quoted }, { "enum": [ "desktopWallpaper" ] }
claunia added the Needs-TriageResolution-Fix-CommittedNeeds-Tag-Fix labels 2026-01-31 04:36:17 +00:00
claunia commented 2026-01-31 04:36:18 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 28, 2021):

Huh, I suppose it does: http://json-schema.org/understanding-json-schema/reference/null.html#null

I'd bet that's not the only one.

@zadjii-msft commented on GitHub (Sep 28, 2021): Huh, I suppose it does: http://json-schema.org/understanding-json-schema/reference/null.html#null I'd bet that's not the only one.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Needs-Triage Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15363
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?