starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.12] Setting opacity as profiles.defaults doesn't work #15375

New Issue
Closed
opened 2026-01-31 04:36:45 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 04:36:45 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Sep 28, 2021).

Originally assigned to: @zadjii-msft on GitHub.

discovered in the 1.12 bug bash on 9/28

"profiles": 
    {
        "defaults": 
        {
            "opacity": 90
        },
        "list": 
        [
            {
                "commandline": "powershell.exe",
                "experimental.retroTerminalEffect": true,
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "hidden": false,
                "name": "Windows PowerShell",
                "opacity": 10,
                "unfocusedAppearance": 
                {
                    "colorScheme": "Solarized Light"
                }
            },
            {
                "commandline": "cmd.exe",
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "hidden": false,
                "name": "Command Prompt"
            },

CMD should be 90% opaque, it's 100%. We're thinking this was a bad merge, since other appearance settings work in the defaults.

Probably regressed in #11184

Originally created by @zadjii-msft on GitHub (Sep 28, 2021). Originally assigned to: @zadjii-msft on GitHub. _discovered in the 1.12 bug bash on 9/28_ ```jsonc "profiles": { "defaults": { "opacity": 90 }, "list": [ { "commandline": "powershell.exe", "experimental.retroTerminalEffect": true, "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}", "hidden": false, "name": "Windows PowerShell", "opacity": 10, "unfocusedAppearance": { "colorScheme": "Solarized Light" } }, { "commandline": "cmd.exe", "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}", "hidden": false, "name": "Command Prompt" }, ``` CMD should be 90% opaque, it's 100%. We're thinking this was a bad merge, since other appearance settings work in the `defaults`. Probably regressed in #11184
claunia commented 2026-01-31 04:36:47 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 28, 2021):

  • settings.baseLayerProfile = Profile::FromJson(defaultsObject); does find the opacity in the settings

Oh boy I bet it's this block

        _Opacity = appearance.HasOpacity() ?
                       appearance.Opacity() :
                       UseAcrylic() ?
                       .5 :
                       1.0;
@zadjii-msft commented on GitHub (Sep 28, 2021): * `settings.baseLayerProfile = Profile::FromJson(defaultsObject);` does find the opacity in the settings Oh boy I bet it's this block ```c++ _Opacity = appearance.HasOpacity() ? appearance.Opacity() : UseAcrylic() ? .5 : 1.0; ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Needs-Triage Priority-1 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15375
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?