starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.12] Split pane on parent loses opacity? #15381

New Issue
Open
opened 2026-01-31 04:36:56 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 04:36:56 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Sep 28, 2021).

discovered in the 1.12 bug bash on 9/28, but probably not blocking

Split pane on parent loses opacity? (bad merge?)
Repro steps:

  1. Have multiple panes open
  2. MoveFocus to parent pane
  3. SplitPane
    Behavior: new pane has transparency, but old panes lost it
Originally created by @zadjii-msft on GitHub (Sep 28, 2021). _discovered in the 1.12 bug bash on 9/28, but probably not blocking_ Split pane on parent loses opacity? (bad merge?) Repro steps: 1. Have multiple panes open 1. MoveFocus to parent pane 1. SplitPane Behavior: new pane has transparency, but old panes lost it
claunia commented 2026-01-31 04:36:58 +00:00
Author
Owner
Copy Link

@Rosefield commented on GitHub (Sep 29, 2021):

Ah, this is probably that GetFocusedProfile tries to get the profile off the actually focused pane instead of leaf control. I can fix this quickly.

Edit: Well, it was not the problem I thought it was, and deleting the newly split pane restores the opacity to the original panes, so I don't know what might be causing this.

@Rosefield commented on GitHub (Sep 29, 2021): Ah, this is probably that `GetFocusedProfile` tries to get the profile off the actually focused pane instead of leaf control. I can fix this quickly. Edit: Well, it was not the problem I thought it was, and deleting the newly split pane restores the opacity to the original panes, so I don't know what might be causing this.
claunia commented 2026-01-31 04:36:58 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 28, 2022):

(note to self, still repros in 1.17 selfhost. Might want to knock out at the same time as #14260 even though the two are unrelated)

@zadjii-msft commented on GitHub (Nov 28, 2022): (note to self, still repros in 1.17 selfhost. Might want to knock out at the same time as #14260 even though the two are unrelated)
claunia commented 2026-01-31 04:36:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 29, 2022):

There's a Background that's not getting removed. That's the issue. If you manually decrease the opacity of the pane down to 0, you'll see a weird grey color fill the pane (possibly just the inactive border color).

Probably one of those Pane backgrounds that we insert for the sake of the animation and then remove when the animation is completed - I bet that's wacky when a parent pane is selected.

b6b1ff8b2c/src/cascadia/TerminalApp/Pane.cpp (L89-L91)

This line is sus - removing it fixes the bug, but re-introduces "transparent background as the pane animates in". Hmm.

@zadjii-msft commented on GitHub (Nov 29, 2022): There's a `Background` that's not getting removed. That's the issue. If you manually decrease the opacity of the pane down to 0, you'll see a weird grey color fill the pane (possibly just the inactive border color). Probably one of those Pane backgrounds that we insert for the sake of the animation and then remove when the animation is completed - I bet that's wacky when a parent pane is selected. https://github.com/microsoft/terminal/blob/b6b1ff8b2cfea71d45ba5345ec7a4af9f07dc66d/src/cascadia/TerminalApp/Pane.cpp#L89-L91 This line is sus - removing it fixes the bug, but re-introduces "transparent background as the pane animates in". Hmm.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Bug Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15381
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?