starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Bug: Quake mode (globalSummon) animation with dropdownDuration=0 #15403

New Issue
Open
opened 2026-01-31 04:37:37 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 04:37:37 +00:00
Owner
Copy Link

Originally created by @SnirBroshi on GitHub (Sep 30, 2021).

Windows Terminal version (or Windows build number)

1.10.2383.0

Other Software

Windows 1909 (build 18363), might be relevant for repro since it's about the actual window.

Steps to reproduce

Add the following action to settings.json under "actions":

{ "keys": "win+`", "command": { "action": "globalSummon", "name": "_quake", "dropdownDuration": 0 } },

First press Win+` to launch the quake window.

Then press it again to hide, and another time to show the quake window, and notice the show/hide animations.

Expected Behavior

Both the hide and show animations should be instant, no animation should play and the window should appear and disappear instantly.

Actual Behavior

The hide animation works as expected, but the show animation is no longer a reveal from above but rather a zoom out and pan (to top left) for some reason.

Changing "dropdownDuration" to 1 instead of 0 works as expected, a workaround.

If it doesn't repro for you, perhaps the Windows version is important.

Originally created by @SnirBroshi on GitHub (Sep 30, 2021). ### Windows Terminal version (or Windows build number) 1.10.2383.0 ### Other Software Windows 1909 (build 18363), might be relevant for repro since it's about the actual window. ### Steps to reproduce Add the following action to `settings.json` under `"actions"`: ```json { "keys": "win+`", "command": { "action": "globalSummon", "name": "_quake", "dropdownDuration": 0 } }, ``` First press <kbd>Win</kbd>+<kbd>`</kbd> to launch the quake window. Then press it again to hide, and another time to show the quake window, and notice the show/hide animations. ### Expected Behavior Both the hide and show animations should be instant, no animation should play and the window should appear and disappear instantly. ### Actual Behavior The hide animation works as expected, but the show animation is no longer a reveal from above but rather a zoom out and pan (to top left) for some reason. Changing `"dropdownDuration"` to 1 instead of 0 works as expected, a workaround. If it doesn't repro for you, perhaps the Windows version is important.
claunia commented 2026-01-31 04:37:38 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 30, 2021):

Do you have your taskbar on the top or left?

IIRC that "zoom and pan" animation is just the normal windows "hide window" animation. That being said, I don't see those on Win11 with my

        {
            "command": 
            {
                "action": "globalSummon",
                "monitor": "any"
            },
            "keys": "win+sc(41)"
        },

keybinding, so maybe there's something that did change from 10->11

@zadjii-msft commented on GitHub (Sep 30, 2021): Do you have your taskbar on the top or left? IIRC that "zoom and pan" animation is just the normal windows "hide window" animation. That being said, I don't see those on Win11 with my ```json { "command": { "action": "globalSummon", "monitor": "any" }, "keys": "win+sc(41)" }, ``` keybinding, so maybe there's something that did change from 10->11
claunia commented 2026-01-31 04:37:39 +00:00
Author
Owner
Copy Link

@SnirBroshi commented on GitHub (Sep 30, 2021):

Your keybinding doesn't set dropdownDuration to 0, which is the only time the bug happens

My taskbar is on the bottom btw. The pan & zoom directions are affected by the taskbar location, but the animation still exists on all four sides

@SnirBroshi commented on GitHub (Sep 30, 2021): Your keybinding doesn't set `dropdownDuration` to 0, which is the only time the bug happens My taskbar is on the bottom btw. The pan & zoom directions are affected by the taskbar location, but the animation still exists on all four sides
claunia commented 2026-01-31 04:37:39 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 30, 2021):

37e8769b37/src/cascadia/TerminalSettingsModel/ActionArgs.h (L1641)

the default dropdown duration is 0, so you don't actually need to explicitly set it to 0

@zadjii-msft commented on GitHub (Sep 30, 2021): https://github.com/microsoft/terminal/blob/37e8769b3706402706d62f19202554080796b3e3/src/cascadia/TerminalSettingsModel/ActionArgs.h#L1641 the default dropdown duration is 0, so you don't actually need to explicitly set it to 0
claunia commented 2026-01-31 04:37:39 +00:00
Author
Owner
Copy Link

@SnirBroshi commented on GitHub (Sep 30, 2021):

Yeah, leaving it unset gives the same result.

I'd guess that this part of the code is the culprit. I did not disable animations in the OS settings btw.
74f11b8203/src/cascadia/WindowsTerminal/IslandWindow.cpp (L1381-L1395)

@SnirBroshi commented on GitHub (Sep 30, 2021): Yeah, leaving it unset gives the same result. I'd guess that this part of the code is the culprit. I did not disable animations in the OS settings btw. https://github.com/microsoft/terminal/blob/74f11b8203a3f297372630e164b7b4d51f82d83e/src/cascadia/WindowsTerminal/IslandWindow.cpp#L1381-L1395
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Windowing Help Wanted Issue-Bug Needs-Repro Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15403
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?