starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[1.12] Fix vertical alignment of elevated shield #15450

New Issue
Closed
opened 2026-01-31 04:38:58 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 04:38:58 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Oct 5, 2021).

Originally assigned to: @zadjii-msft on GitHub.

It doesn't really optically line up with anything, and the bottom padding is very small.

image

Originally created by @DHowett on GitHub (Oct 5, 2021). Originally assigned to: @zadjii-msft on GitHub. It doesn't really optically line up with anything, and the bottom padding is very small. ![image](https://user-images.githubusercontent.com/189190/136043552-dc25b907-e960-4dfd-9d9f-733814460943.png)
claunia commented 2026-01-31 04:39:00 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 5, 2021):

Oh I know what's the issue here. I know why this feels off:

        <mux:TabView.TabStripFooter>
            <mux:SplitButton x:Name="NewTabButton"
                             x:Uid="NewTabSplitButton"
                             HorizontalAlignment="Left"
                             VerticalAlignment="Stretch"
                             BorderThickness="0"
                             Click="OnNewTabButtonClick"
                             Content="&#xE710;"
                             FontFamily="Segoe MDL2 Assets"
                             FontSize="12"
                             FontWeight="SemiLight"
                             UseLayoutRounding="true">

The Footer we're using has a button inside it, and that button has some padding inside it for it's icon. That's why it feels off.

@zadjii-msft commented on GitHub (Oct 5, 2021): Oh I know what's the issue here. I know why this feels off: ```xaml <mux:TabView.TabStripFooter> <mux:SplitButton x:Name="NewTabButton" x:Uid="NewTabSplitButton" HorizontalAlignment="Left" VerticalAlignment="Stretch" BorderThickness="0" Click="OnNewTabButtonClick" Content="&#xE710;" FontFamily="Segoe MDL2 Assets" FontSize="12" FontWeight="SemiLight" UseLayoutRounding="true"> ``` The Footer we're using has a _button_ inside it, and that button has some padding inside it for it's icon. That's why it feels off.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Triage Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15450
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?