starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

"Incomplete" color schemes are rejected as if they don't exist (possibly only if in fragment) #15482

New Issue
Open
opened 2026-01-31 04:39:51 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 04:39:51 +00:00
Owner
Copy Link

Originally created by @Diablo-D3 on GitHub (Oct 7, 2021).

Windows Terminal version (or Windows build number)

1.11.2421.0, 1.10.2383.0

Other Software

No response

Steps to reproduce

Use a color scheme that is "incomplete" in a fragment, use the scheme name's in your default profile.

Example:

{
  "schemes": [
    {
      "name": "Test",
      "background": "#000000",
      "foreground": "#000000",
      "black": "#002b36",
      "red": "#6a4d53",
      "green": "#468666",
      "yellow": "#75896c",
      "blue": "#002b36",
      "magenta": "#6a4d53",
      "cyan": "#468666",
      "white": "#75896c",
      "brightBlack": "#002b36",
      "brightRed": "#002b36",
      "brightGreen": "#002b36",
      "brightYellow": "#002b36",
      "brightBlue": "#002b36",
      "brightMagenta": "#002b36",
      "brightCyan": "#002b36",
      "brightWhite": "#002b36"
    }
  ]
}

Drop in %LOCALAPPDATA\Microsoft\Windows Terminal\Fragments\Test\Test.json, and change settings.json's defaults: colorScheme to Test. Launch WT, get greatly misleading warning.

Notice the use of #11456 here. Else, everything seems to be listed as per the documentation on schemes.

Change "Magenta" to "Purple" on both lines, and watch the fragment suddenly be discoverable and work.

Also note: the colors in this scheme are garbage on purpose, if they're ugly, its working.

Expected Behavior

Either working behavior (with the missing colors replaced with Campbell's) and/or a warning specifically telling me what is wrong with the scheme. At no point should WT tell the user that the scheme doesn't exist without any other warnings that specifically state the scheme was found, but is incomplete.

Actual Behavior

On launch with incomplete scheme in fragment, but specified in settings.json

image

Notice the lack of saying the color scheme exists, but misses elements; it just claims it never existed ever, which leads to a day long wild goose chase.

Originally created by @Diablo-D3 on GitHub (Oct 7, 2021). ### Windows Terminal version (or Windows build number) 1.11.2421.0, 1.10.2383.0 ### Other Software _No response_ ### Steps to reproduce Use a color scheme that is "incomplete" in a fragment, use the scheme name's in your default profile. Example: ``` { "schemes": [ { "name": "Test", "background": "#000000", "foreground": "#000000", "black": "#002b36", "red": "#6a4d53", "green": "#468666", "yellow": "#75896c", "blue": "#002b36", "magenta": "#6a4d53", "cyan": "#468666", "white": "#75896c", "brightBlack": "#002b36", "brightRed": "#002b36", "brightGreen": "#002b36", "brightYellow": "#002b36", "brightBlue": "#002b36", "brightMagenta": "#002b36", "brightCyan": "#002b36", "brightWhite": "#002b36" } ] } ``` Drop in `%LOCALAPPDATA\Microsoft\Windows Terminal\Fragments\Test\Test.json`, and change `settings.json`'s `defaults: colorScheme` to `Test`. Launch WT, get greatly misleading warning. Notice the use of #11456 here. Else, everything seems to be listed as per the documentation on schemes. Change "Magenta" to "Purple" on both lines, and watch the fragment suddenly be discoverable and work. Also note: the colors in this scheme are garbage on purpose, if they're ugly, its working. ### Expected Behavior Either working behavior (with the missing colors replaced with Campbell's) and/or a warning *specifically* telling me what is wrong with the scheme. At no point should WT tell the user that the scheme doesn't exist without any other warnings that specifically state the scheme was found, but is incomplete. ### Actual Behavior On launch with incomplete scheme in fragment, but specified in `settings.json` ![image](https://user-images.githubusercontent.com/448731/136465303-3d2e75dc-a361-4fb3-b129-440bceb7c272.png) Notice the lack of saying the color scheme exists, but misses elements; it just claims it never existed ever, which leads to a day long wild goose chase.
claunia commented 2026-01-31 04:39:52 +00:00
Author
Owner
Copy Link

@SufyaanKhateeb commented on GitHub (Oct 16, 2023):

If no one is assigned, maybe I look into this.

@SufyaanKhateeb commented on GitHub (Oct 16, 2023): If no one is assigned, maybe I look into this.
claunia commented 2026-01-31 04:39:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 16, 2023):

@SufyaanKhateeb Go right ahead ☺️

@zadjii-msft commented on GitHub (Oct 16, 2023): @SufyaanKhateeb Go right ahead ☺️
claunia commented 2026-01-31 04:39:52 +00:00
Author
Owner
Copy Link

@SufyaanKhateeb commented on GitHub (Oct 29, 2023):

While building the application I am running into

  D:\Windows Kits\10\Include\10.0.22621.0\shared\TraceLoggingActivity.h(439,1): fatal  error C1060: compiler is out of heap space (compiling source file Ne
wTabMenuTests.cpp) [C:\Users\sufya\OneDrive\Desktop\Sufyaan\windows-terminal\src\cascadia\LocalTests_SettingsModel\SettingsModel.LocalTests.vcxproj]
  D:\Windows Kits\10\Include\10.0.22621.0\shared\TraceLoggingActivity.h(847,1): fatal  error C1060: compiler is out of heap space (compiling source file Se
rializationTests.cpp) [C:\Users\sufya\OneDrive\Desktop\Sufyaan\windows-terminal\src\cascadia\LocalTests_SettingsModel\SettingsModel.LocalTests.vcxproj]

How much memory space does this require for building?

@SufyaanKhateeb commented on GitHub (Oct 29, 2023): While building the application I am running into ``` D:\Windows Kits\10\Include\10.0.22621.0\shared\TraceLoggingActivity.h(439,1): fatal error C1060: compiler is out of heap space (compiling source file Ne wTabMenuTests.cpp) [C:\Users\sufya\OneDrive\Desktop\Sufyaan\windows-terminal\src\cascadia\LocalTests_SettingsModel\SettingsModel.LocalTests.vcxproj] D:\Windows Kits\10\Include\10.0.22621.0\shared\TraceLoggingActivity.h(847,1): fatal error C1060: compiler is out of heap space (compiling source file Se rializationTests.cpp) [C:\Users\sufya\OneDrive\Desktop\Sufyaan\windows-terminal\src\cascadia\LocalTests_SettingsModel\SettingsModel.LocalTests.vcxproj] ``` How much memory space does this require for building?
claunia commented 2026-01-31 04:39:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 30, 2023):

Like, at least 4GB. The precompiled header files for XAML are outrageously big, and they need to be entirely stuffed into memory all at once.

@zadjii-msft commented on GitHub (Oct 30, 2023): Like, at least 4GB. The precompiled header files for XAML are outrageously big, and they need to be entirely stuffed into memory all at once.
claunia commented 2026-01-31 04:39:53 +00:00
Author
Owner
Copy Link

@MaximilianMeiler commented on GitHub (Jan 24, 2024):

First-time contributor here - I'm interested in working on this issue. I'll try to get the environment set up - perhaps the error should be expanded to include what sections of which schemes are missing?

@MaximilianMeiler commented on GitHub (Jan 24, 2024): First-time contributor here - I'm interested in working on this issue. I'll try to get the environment set up - perhaps the error should be expanded to include what sections of which schemes are missing?
claunia commented 2026-01-31 04:39:53 +00:00
Author
Owner
Copy Link

@SufyaanKhateeb commented on GitHub (Jan 25, 2024):

Yes, you can go ahead. I didn't get time to check it out.

@SufyaanKhateeb commented on GitHub (Jan 25, 2024): Yes, you can go ahead. I didn't get time to check it out.
claunia commented 2026-01-31 04:39:53 +00:00
Author
Owner
Copy Link

@MaximilianMeiler commented on GitHub (Feb 3, 2024):

image

I've set up my development environment (including an installation of the Windows 10.0.22621.0 SDK), but am still getting this error on launch. I'm not able to find the "retarget solution" option for the OpenConsole file and have tried a few workarounds, to no success - any aid would be appreciated.

@MaximilianMeiler commented on GitHub (Feb 3, 2024): ![image](https://github.com/microsoft/terminal/assets/113135205/8d3b90a1-e940-403f-9448-08015148c25f) I've set up my development environment (including an installation of the Windows 10.0.22621.0 SDK), but am still getting this error on launch. I'm not able to find the "retarget solution" option for the OpenConsole file and have tried a few workarounds, to no success - any aid would be appreciated.
claunia commented 2026-01-31 04:39:53 +00:00
Author
Owner
Copy Link

@MaximilianMeiler commented on GitHub (Feb 5, 2024):

I was able to solve the above issue by un/reinstalling my SDKs and performing a repair on Visual Studio. However, i'm now getting a different error when attempting to build with powershell:
image

Attempting to build with the command prompt gives the powershell version error as well.

As before, any assistance is appreciated.

Edit: Now I'm getting the "error NETSDK1004: Assets file not found. Run a NuGet package restore to generate this file." error instead.

@MaximilianMeiler commented on GitHub (Feb 5, 2024): I was able to solve the above issue by un/reinstalling my SDKs and performing a repair on Visual Studio. However, i'm now getting a different error when attempting to build with powershell: ![image](https://github.com/microsoft/terminal/assets/113135205/36d4ef98-f9f2-438b-a367-006e6988bcd9) Attempting to build with the command prompt gives the powershell version error as well. As before, any assistance is appreciated. Edit: Now I'm getting the "error NETSDK1004: Assets file not found. Run a NuGet package restore to generate this file." error instead.
claunia commented 2026-01-31 04:39:54 +00:00
Author
Owner
Copy Link

@minigithubo commented on GitHub (Sep 13, 2025):

Hi, I'd like to work on this issue. Could you please assign it to me?

@minigithubo commented on GitHub (Sep 13, 2025): Hi, I'd like to work on this issue. Could you please assign it to me?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings good first issue Help Wanted Issue-Bug Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15482
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?