"Magenta" is called "Purple" in WT #15484

Closed
opened 2026-01-31 04:39:53 +00:00 by claunia · 8 comments
Owner

Originally created by @Diablo-D3 on GitHub (Oct 7, 2021).

Windows Terminal version (or Windows build number)

All versions

Other Software

No response

Steps to reproduce

Terminal calls "Magenta" by the wrong name, instead it is called "Purple".

Expected Behavior

The expected behavior is calling it "Magenta" instead of "Purple".

Actual Behavior

Terminal calls the color in question "Purple", instead of "Magenta".

Originally created by @Diablo-D3 on GitHub (Oct 7, 2021). ### Windows Terminal version (or Windows build number) All versions ### Other Software _No response_ ### Steps to reproduce Terminal calls "Magenta" by the wrong name, instead it is called "Purple". ### Expected Behavior The expected behavior is calling it "Magenta" instead of "Purple". ### Actual Behavior Terminal calls the color in question "Purple", instead of "Magenta".
Author
Owner

@Diablo-D3 commented on GitHub (Oct 7, 2021):

I apologize for the simplicity of this report, but the form submission really doesn't cover trivial issues.

I also understand that it is possible nobody on the team wants to handle the GUI implications of handling non-English translations, but I would accept a proposed fix of the settings.json parser also accepting "Magenta" as a string, since it will now always have to also accept "Purple" to not break legacy configurations.

@Diablo-D3 commented on GitHub (Oct 7, 2021): I apologize for the simplicity of this report, but the form submission really doesn't cover trivial issues. I also understand that it is possible nobody on the team wants to handle the GUI implications of handling non-English translations, but I would accept a proposed fix of the settings.json parser also accepting "Magenta" as a string, since it will now always have to also accept "Purple" to not break legacy configurations.
Author
Owner

@Diablo-D3 commented on GitHub (Oct 8, 2021):

Incorrect. It is called magenta in the 8 and 16 color systems, and these are industry standard technical terms. Similarly, you do not say a printer uses cyan, purple, yellow, and black.

@Diablo-D3 commented on GitHub (Oct 8, 2021): Incorrect. It is called magenta in the 8 and 16 color systems, and these are industry standard technical terms. Similarly, you do not say a printer uses cyan, purple, yellow, and black.
Author
Owner

@zadjii-msft commented on GitHub (Oct 8, 2021):

Huh. No one else has complained about this since we shipped the Terminal more than 2 years ago now. I suppose we could also accept magenta as a key. Probably no harm in that.

@zadjii-msft commented on GitHub (Oct 8, 2021): Huh. No one else has complained about this since we shipped the Terminal more than 2 years ago now. I suppose we _could_ also accept magenta as a key. Probably no harm in that.
Author
Owner

@Diablo-D3 commented on GitHub (Oct 8, 2021):

@zadjii-msft I'm actually surprised no one has hit this particular issue. In my case, along with #11457, it may mean nobody has tried to automate porting color schemes to WT. Or, alternatively, they have, and none of their schemes worked, and they just gave up instead of figuring out why they didn't work.

@Diablo-D3 commented on GitHub (Oct 8, 2021): @zadjii-msft I'm actually surprised no one has hit this particular issue. In my case, along with #11457, it may mean nobody has tried to automate porting color schemes to WT. Or, alternatively, they have, and none of their schemes worked, and they just gave up instead of figuring out why they didn't work.
Author
Owner

@j4james commented on GitHub (Oct 8, 2021):

No one else has complained about this since we shipped the Terminal more than 2 years ago now

We have actually discussed this before, but didn't really commit to fixing it: https://github.com/microsoft/terminal/issues/2641#issuecomment-528348251

@j4james commented on GitHub (Oct 8, 2021): > No one else has complained about this since we shipped the Terminal more than 2 years ago now We have actually discussed this before, but didn't really commit to fixing it: https://github.com/microsoft/terminal/issues/2641#issuecomment-528348251
Author
Owner

@DHowett commented on GitHub (Oct 8, 2021):

/me goes off to register @MikeVsMike

Fair enough.

@DHowett commented on GitHub (Oct 8, 2021): /me goes off to register `@MikeVsMike` Fair enough.
Author
Owner

@Diablo-D3 commented on GitHub (Jun 11, 2022):

@matthewd673 Thanks for the fix.

@Diablo-D3 commented on GitHub (Jun 11, 2022): @matthewd673 Thanks for the fix.
Author
Owner

@ghost commented on GitHub (Jul 6, 2022):

:tada:This issue was addressed in #13261, which has now been successfully released as Windows Terminal Preview v1.15.186.🎉

Handy links:

@ghost commented on GitHub (Jul 6, 2022): :tada:This issue was addressed in #13261, which has now been successfully released as `Windows Terminal Preview v1.15.186`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.15.186) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15484