starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

GetConsoleWindow() returns nonsense instead of NULL in 1809 when there is no console. #1556

New Issue
Open
opened 2026-01-30 22:30:35 +00:00 by claunia · 0 comments
claunia commented 2026-01-30 22:30:35 +00:00
Owner
Copy Link

Originally created by @EricYoungdale on GitHub (Jun 8, 2019).

Up to and including 1803, a call to GetConsoleWindow() will return NULL if the process has no console. In 1809, it seems to just return some uninitialized variable instead.

The enclosed testcase demonstrates this. It launches a child using the CREATE_NO_WINDOW flag, and passing pipe handles as the std handles. The child reports back (via the pipe) to the launcher what it sees.

Expected behavior (both Win7 and 1803) give something like this:

Parent console handle is 00330654
child says: stdin handle is 000000FC
stdout handle is 00000108
stderr handle is 00000110
hConsole is 0000000F
Console hWnd handle is 00000000
Cannot get window class

The last two lines are the ones that are of the most interest. In 1809, we instead get:

Parent console handle is 00420AEE
child says: stdin handle is 0000029C
stdout handle is 000002A8
stderr handle is 000002B0
hConsole is 00000298
Console handle is 004035E8
Cannot get window class

The console handle that is obtained is non-zero, and it is not even a valid HWND.

testcase.zip

Originally created by @EricYoungdale on GitHub (Jun 8, 2019). Up to and including 1803, a call to GetConsoleWindow() will return NULL if the process has no console. In 1809, it seems to just return some uninitialized variable instead. The enclosed testcase demonstrates this. It launches a child using the CREATE_NO_WINDOW flag, and passing pipe handles as the std handles. The child reports back (via the pipe) to the launcher what it sees. Expected behavior (both Win7 and 1803) give something like this: Parent console handle is 00330654 child says: stdin handle is 000000FC stdout handle is 00000108 stderr handle is 00000110 hConsole is 0000000F Console hWnd handle is 00000000 Cannot get window class The last two lines are the ones that are of the most interest. In 1809, we instead get: Parent console handle is 00420AEE child says: stdin handle is 0000029C stdout handle is 000002A8 stderr handle is 000002B0 hConsole is 00000298 Console handle is 004035E8 Cannot get window class The console handle that is obtained is non-zero, and it is not even a valid HWND. [testcase.zip](https://github.com/microsoft/terminal/files/3268549/testcase.zip)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Server Issue-Bug Needs-Triage Product-Conhost Resolution-Fix-Available
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1556
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?