starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

JSON fails to parse with a trailing comment at the end of an array #15592

New Issue
Open
opened 2026-01-31 04:42:58 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 04:42:58 +00:00
Owner
Copy Link

Originally created by @elibarzilay on GitHub (Oct 20, 2021).

Windows Terminal version (or Windows build number)

1.10.2714.0

Other Software

No response

Steps to reproduce

In the settings file, put a comment at the end of an object with a comma after it.

This fails:

"actions": [
  {},
  // ...
],

Dropping either the , or the comment makes it work.

Expected Behavior

Should be parsed as usual since both terminating commas and comments are allowed, or forbid trailing commas (assuming that comments are a desired feature).

Actual Behavior

Settings could not be loaded from file. Check for syntax errors, including trailing commas.

Originally created by @elibarzilay on GitHub (Oct 20, 2021). ### Windows Terminal version (or Windows build number) 1.10.2714.0 ### Other Software _No response_ ### Steps to reproduce In the settings file, put a comment at the end of an object with a comma after it. This fails: "actions": [ {}, // ... ], Dropping either the `,` or the comment makes it work. ### Expected Behavior Should be parsed as usual since both terminating commas and comments are allowed, or forbid trailing commas (assuming that comments are a desired feature). ### Actual Behavior > Settings could not be loaded from file. Check for syntax errors, including trailing commas.
claunia commented 2026-01-31 04:42:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 20, 2021):

I suspect this is a jsoncpp bug. I know that they don't support a "trailing" comment, the comment has to be before some real value that it can attach the comment too. That being said, there's nothing open on their repo (or maybe I'm just bad at searching). We should probably drum up a minimal repro without the Terminal involved and post this upstream

@zadjii-msft commented on GitHub (Oct 20, 2021): I suspect this is a jsoncpp bug. I know that they don't support a "trailing" comment, the comment has to be before some real value that it can attach the comment too. That being said, there's [nothing open on their repo](https://github.com/open-source-parsers/jsoncpp/issues?q=is%3Aissue+trailing+comment+) (or maybe I'm just bad at searching). We should probably drum up a minimal repro without the Terminal involved and post this upstream
claunia commented 2026-01-31 04:43:00 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Jul 10, 2023):

I have a minimal repro example ready to go to file a bug at jsoncpp. But before I did, I did some searching and I cant find where trailing commas are permitted by the spec and most searches on StackOverflow indicate that they are not permitted.

https://stackoverflow.com/questions/201782/can-you-use-a-trailing-comma-in-a-json-object

From MDN:

image

Maybe a better error message could be produced?

@jamespack commented on GitHub (Jul 10, 2023): I have a minimal repro example ready to go to file a bug at jsoncpp. But before I did, I did some searching and I cant find where trailing commas are permitted by the spec and most searches on StackOverflow indicate that they are not permitted. https://stackoverflow.com/questions/201782/can-you-use-a-trailing-comma-in-a-json-object From MDN: <img width="649" alt="image" src="https://github.com/microsoft/terminal/assets/2086722/c445ca08-cc6a-4129-9669-e9241936bfd3"> Maybe a better error message could be produced?
claunia commented 2026-01-31 04:43:00 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Jul 10, 2023):

Still happy to open the issue if you think it'd be prudent :)

@jamespack commented on GitHub (Jul 10, 2023): Still happy to open the issue if you think it'd be prudent :)
claunia commented 2026-01-31 04:43:00 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Jul 10, 2023):

Many JSON parsers allow trailing commas as an extension to the spec, including jsoncpp with the allowTrailingCommas option. This is helpful, because trailing commas make editing and diffing JSON files easier.

@lhecker commented on GitHub (Jul 10, 2023): Many JSON parsers allow trailing commas as an extension to the spec, including jsoncpp with the `allowTrailingCommas` option. This is helpful, because trailing commas make editing and diffing JSON files easier.
claunia commented 2026-01-31 04:43:00 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Jul 10, 2023):

Right on. I will open an with them today then. Thanks for the clarification!

@jamespack commented on GitHub (Jul 10, 2023): Right on. I will open an with them today then. Thanks for the clarification!
claunia commented 2026-01-31 04:43:01 +00:00
Author
Owner
Copy Link

@jamespack commented on GitHub (Jul 10, 2023):

Here you go

https://github.com/open-source-parsers/jsoncpp/issues/1500

@jamespack commented on GitHub (Jul 10, 2023): Here you go https://github.com/open-source-parsers/jsoncpp/issues/1500
claunia commented 2026-01-31 04:43:01 +00:00
Author
Owner
Copy Link

@sba923 commented on GitHub (Sep 30, 2023):

Many JSON parsers allow trailing commas as an extension to the spec, including jsoncpp with the allowTrailingCommas option. This is helpful, because trailing commas make editing and diffing JSON files easier.

VScode doesn't like Windows Terminal's defaults.json:

image

@nguyen-dows does this deserve an issue?

@sba923 commented on GitHub (Sep 30, 2023): > Many JSON parsers allow trailing commas as an extension to the spec, including jsoncpp with the `allowTrailingCommas` option. This is helpful, because trailing commas make editing and diffing JSON files easier. VScode doesn't like Windows Terminal's `defaults.json`: ![image](https://github.com/microsoft/terminal/assets/12860484/89102bf7-4977-4c32-a7de-9117b22eed76) @nguyen-dows does this deserve an issue?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Help Wanted Issue-Bug Product-Terminal Resolution-External
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15592
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?