starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Developer Command Prompt profile does not work #15598

New Issue
Closed
opened 2026-01-31 04:43:04 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 04:43:04 +00:00
Owner
Copy Link

Originally created by @trippwill on GitHub (Oct 20, 2021).

Windows Terminal version (or Windows build number)

1.12.2922.0

Other Software

Visual Studio 2022 Preview
Visual Studio 2019

Steps to reproduce

Open WT.
Open a Developer Command Prompt profile

Expected Behavior

It to work correctly

Actual Behavior

image

Originally created by @trippwill on GitHub (Oct 20, 2021). ### Windows Terminal version (or Windows build number) 1.12.2922.0 ### Other Software Visual Studio 2022 Preview Visual Studio 2019 ### Steps to reproduce Open WT. Open a Developer Command Prompt profile ### Expected Behavior It to work correctly ### Actual Behavior ![image](https://user-images.githubusercontent.com/5862883/138150924-bbd69513-6b9d-451c-8c76-55578d52ff27.png)
claunia commented 2026-01-31 04:43:05 +00:00
Author
Owner
Copy Link

@trippwill commented on GitHub (Oct 20, 2021):

@heaths we seem to have a misplaced quotation mark somehwere

@trippwill commented on GitHub (Oct 20, 2021): @heaths we seem to have a misplaced quotation mark somehwere
claunia commented 2026-01-31 04:43:05 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 20, 2021):

OH NO.

@lhecker LR"("cmd.exe for sure emits a stray " in the string.

How did this pass testing?
d

@DHowett commented on GitHub (Oct 20, 2021): OH NO. @lhecker `LR"("cmd.exe` for sure emits a stray `"` in the string. How did this pass testing? d
claunia commented 2026-01-31 04:43:05 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 20, 2021):

This is a headlining feature for 1.12. We may want to literally back-to-back service it with the release ;P

@DHowett commented on GitHub (Oct 20, 2021): This is a headlining feature for 1.12. We may want to literally back-to-back service it with the release ;P
claunia commented 2026-01-31 04:43:06 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Oct 20, 2021):

I'm very sorry for this issue.
I failed to test my changes again after I changed the string literal to a raw string literal right before committing it. 😔

@lhecker commented on GitHub (Oct 20, 2021): I'm very sorry for this issue. I failed to test my changes again after I changed the string literal to a raw string literal right before committing it. 😔
claunia commented 2026-01-31 04:43:06 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Oct 20, 2021):

I deserve some of the blame here for rushing the change to completion.

@DHowett commented on GitHub (Oct 20, 2021): I deserve some of the blame here for rushing the change to completion.
claunia commented 2026-01-31 04:43:06 +00:00
Author
Owner
Copy Link

@heaths commented on GitHub (Oct 20, 2021):

Honestly, I saw that in code and had to look up what LR did (I was familiar with L) and the documentation shows it as well 😬:

image

Or is this just a case that one of them didn't have a trailing ")" and instead )"?

@heaths commented on GitHub (Oct 20, 2021): Honestly, I saw that in code and had to look up what `LR` did (I was familiar with `L`) and the [documentation](https://docs.microsoft.com/en-us/cpp/cpp/string-and-character-literals-cpp?view=msvc-160#:~:text=auto%20R2%20%3D%20%20LR%22(%22Hello%20%5C%20world%22)%22%3B) shows it as well 😬: <img width="420" alt="image" src="https://user-images.githubusercontent.com/1532486/138164963-99669823-1968-44e8-a0f6-c54dde40cadd.png"> Or is this just a case that one of them didn't have a trailing `")"` and instead `)"`?
claunia commented 2026-01-31 04:43:06 +00:00
Author
Owner
Copy Link

@lhecker commented on GitHub (Oct 20, 2021):

@heaths The usage is similar to the "heredoc" concept and the syntax is:
image

LR"(" Hello \ world")" for instance is the same as L"\"Hello \\ world\"".
If you want change the "delimiters" then you need to put them outside of the parentheses. For instance in our defaults.json we have:

{ "command": "quakeMode", "keys":"win+sc(41)" },

You couldn't put this line into a regular raw string literal because the )" would signal the end of it. So you need to write this for instance:

LR"#({ "command": "quakeMode", "keys":"win+sc(41)" },)#"

That way the end of the literal is only reached if the characters )#" are encountered.
Ending the literal in ")" wouldn't have fixed the issue unfortunately.

@lhecker commented on GitHub (Oct 20, 2021): @heaths The usage is similar to the ["heredoc"](https://en.wikipedia.org/wiki/Here_document) concept and the syntax is: ![image](https://user-images.githubusercontent.com/2256941/138165498-395766be-519d-4cf8-b4a7-fe4d4039f73f.png) `LR"(" Hello \ world")"` for instance is the same as `L"\"Hello \\ world\""`. If you want change the "delimiters" then you need to put them outside of the parentheses. For instance in our defaults.json we have: ```json { "command": "quakeMode", "keys":"win+sc(41)" }, ``` You couldn't put this line into a regular raw string literal because the `)"` would signal the end of it. So you need to write this for instance: ```cpp LR"#({ "command": "quakeMode", "keys":"win+sc(41)" },)#" ``` That way the end of the literal is only reached if the characters `)#"` are encountered. Ending the literal in `")"` wouldn't have fixed the issue unfortunately.
claunia commented 2026-01-31 04:43:06 +00:00
Author
Owner
Copy Link

@heaths commented on GitHub (Oct 20, 2021):

Thanks. I've been doing C/C++ for over 30 years - mostly targeting Windows - and had never run into these before. Good to know, and I can see plenty of use going forward rather than having to escape all over. I use heredocs in Go and other languages quite a bit. Definitely have their uses!

@heaths commented on GitHub (Oct 20, 2021): Thanks. I've been doing C/C++ for over 30 years - mostly targeting Windows - and had never run into these before. Good to know, and I can see plenty of use going forward rather than having to escape all over. I use heredocs in Go and other languages quite a bit. Definitely have their uses!
claunia commented 2026-01-31 04:43:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 21, 2021):

:tada:This issue was addressed in #11554, which has now been successfully released as Terminal Preview v1.12.2931.0.🎉

Handy links:

@ghost commented on GitHub (Oct 21, 2021): :tada:This issue was addressed in #11554, which has now been successfully released as `Terminal Preview v1.12.2931.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.12.2931.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Needs-Triage Priority-0 Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15598
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?