Error codes should show unsigned #15604

Closed
opened 2026-01-31 04:43:12 +00:00 by claunia · 5 comments
Owner

Originally created by @miniksa on GitHub (Oct 20, 2021).

Missed this in #11123...

image

That should be an unsigned value. Not a signed one.

Originally created by @miniksa on GitHub (Oct 20, 2021). Missed this in #11123... ![image](https://user-images.githubusercontent.com/18221333/138168320-58797ebc-d584-45c1-9946-431cfd0e1f05.png) That should be an unsigned value. Not a signed one.
Author
Owner

@zadjii-msft commented on GitHub (Oct 20, 2021):

🤣

@zadjii-msft commented on GitHub (Oct 20, 2021): 🤣
Author
Owner

@zadjii-msft commented on GitHub (Nov 1, 2021):

wait how the dickens do I get the negative return code?

image

@zadjii-msft commented on GitHub (Nov 1, 2021): wait how the dickens do I get the negative return code? ![image](https://user-images.githubusercontent.com/18356694/139667989-4f06f7f8-1e99-45f6-911f-a9a77e7980a8.png)
Author
Owner

@DHowett commented on GitHub (Nov 1, 2021):

I think you need a high-bit-set return from CreateProcess or CreatePseudoConsole (an early HRESULT-out, not a process exit)

Set a commandline to "\"cmd.exe" or something?

@DHowett commented on GitHub (Nov 1, 2021): I think you need a high-bit-set return from _CreateProcess or CreatePseudoConsole_ (an early HRESULT-out, not a process exit) Set a commandline to `"\"cmd.exe"` or something?
Author
Owner

@zadjii-msft commented on GitHub (Nov 1, 2021):

yea that'll do
image

@zadjii-msft commented on GitHub (Nov 1, 2021): yea that'll do ![image](https://user-images.githubusercontent.com/18356694/139710195-115f2032-db57-4d76-95e3-ee43ab0d6424.png)
Author
Owner

@ghost commented on GitHub (Dec 14, 2021):

:tada:This issue was addressed in #11667, which has now been successfully released as Windows Terminal Preview v1.12.3472.0.🎉

Handy links:

@ghost commented on GitHub (Dec 14, 2021): :tada:This issue was addressed in #11667, which has now been successfully released as `Windows Terminal Preview v1.12.3472.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.12.3472.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15604