starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[I want to work on] Improving Retro Effects & Enhancing Overall Framerate / Performance #15645

New Issue
Closed
opened 2026-01-31 04:44:16 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 04:44:16 +00:00
Owner
Copy Link

Originally created by @platypus-winterberry on GitHub (Oct 22, 2021).

Hello,

Windows Terminal version (or Windows build number)

1.12.2931.0

I want to work (code it myself**Contributing.md suggestion) on improving the Retro terminal effects and the general performance

Extending "Retro terminal effects":

Customization

-> Option to have scanlines, glitches, noise or custom shader

Improve the looks

Resources: https://github.com/Swordfish90/cool-retro-term
-> I WOULD LIKE the impact on my PC's resources to feel more lightweight
-> I WANT TO Add options for Frame rate configuration:
-> WITHOUT having shell dependencies that help me to optimize this
-> SO THAT I am able to take it with me anywhere e.g. custom shells, WSL , SSH, VIM etc
-> ADD the following configurable esthetic options:
- Scan lines,
- Burner effect
- CRT Screen-like bezel

I would also like to address one issue which I would like to see in Microsoft's terminal as I've seen it implemented in other terminals, changes which did help:

Frame rate Limitation
-> Frame rate limitation option: Adaptive FPS based on the throughput ( Terminal's memory-shock usage intake from the command that was ran as opposed to reading the computer's resources which may feel more heavy weight)

Performance improvements that are worth trying:
-> Word wrap tends to not go well with terminals, especially when esthetic additions such as Retro mode.
-> Having the option to change to Character Mode so when it reaches the end of a line and searches for a place to break does not take a memory impact
-> The user's custom configuration related to EOL on his computer/terminal/shell may result in a significant performance issue
-> Intel graphics driver may mess with the terminal's performance when the computer that have the battery settings configuration for auto graphics switching, connecting to an external monitor solves the issues( because it forces discrete graphics ) so having an option to force discrete graphics could be of use for users that do not specifically want to optimize battery life

Originally created by @platypus-winterberry on GitHub (Oct 22, 2021). Hello, # Windows Terminal version (or Windows build number) 1.12.2931.0 I want to work (code it myself**Contributing.md suggestion) on improving the **Retro terminal effects** and the general performance # Extending "Retro terminal effects": ## Customization -> Option to have scanlines, glitches, noise or custom shader ## Improve the looks Resources: https://github.com/Swordfish90/cool-retro-term -> I WOULD LIKE the impact on my PC's resources to feel more lightweight -> I WANT TO Add options for Frame rate configuration: -> WITHOUT having shell dependencies that help me to optimize this -> SO THAT I am able to take it with me anywhere e.g. custom shells, WSL , SSH, VIM etc -> ADD the following configurable esthetic options: - Scan lines, - Burner effect - CRT Screen-like bezel I would also like to address one issue which I would like to see in Microsoft's terminal as I've seen it implemented in other terminals, changes which did help: Frame rate Limitation -> Frame rate limitation option: Adaptive FPS based on the throughput ( Terminal's memory-shock usage intake from the command that was ran as opposed to reading the computer's resources which may feel more heavy weight) Performance improvements that are worth trying: -> Word wrap tends to not go well with terminals, especially when esthetic additions such as Retro mode. -> Having the option to change to Character Mode so when it reaches the end of a line and searches for a place to break does not take a memory impact -> The user's custom configuration related to EOL on his computer/terminal/shell may result in a significant performance issue -> Intel graphics driver may mess with the terminal's performance when the computer that have the battery settings configuration for auto graphics switching, connecting to an external monitor solves the issues( because it forces discrete graphics ) so having an option to force discrete graphics could be of use for users that do not specifically want to optimize battery life
claunia commented 2026-01-31 04:44:18 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 26, 2021):

Thanks for reaching out - lemme see if I can try and distill down some of these requests:

  • Option to have scanlines, glitches, noise or custom shader
  • configurable scanlines / burner effect
  • configurable bezel mode

This sounds like #7013 to me. We already allow you to write custom shaders for the Terminal, and you can do some wild stuff with them.

AND I dont want to have shell dependency

no worries, the pixel shader path is totally separate from the shell.

  • Framerate configuration
  • Framerate limitation option: Adaptive FPS based on the throughput

Right now the Terminal is hard capped at 60fps - that's something we're working on, I don't really want to spoil the fun. The pr is coming soontm, but I'm not sure it's my place to discuss that one more. We won't paint more often than 60fps, and we'll only paint a frame when there's actual output or something that changed on the screen.

You might also be interested in #7147 - right now the Terminal needs to invalidate & redraw everything when pixel shaders are enabled. That definitely causes a noticeable perf hit when they're enabled, especially on laptops. I had a branch where I tried fixing that, just never had the time to drive it home. It might also just be fixed by the secret rendering thing I mentioned above, hence why I shelved it.

Word wrap tends to mess with therminals
Having the option to change to Character Mode
So when it reaches the end of a line and searches for a place to break and depending on the code, every profile should have an option to configure the EOL expectation

This I'm not sure I follow - the console&terminal don't do anything special to "find" a place to wrap a line. We just wrap it at the last character in the line. We're not trying to find a word break or anything, that's silly.

Did I miss anything?

@zadjii-msft commented on GitHub (Oct 26, 2021): Thanks for reaching out - lemme see if I can try and distill down some of these requests: > * Option to have scanlines, glitches, noise or custom shader > * configurable scanlines / burner effect > * configurable bezel mode This sounds like #7013 to me. We already allow you to write custom shaders for the Terminal, and you can do [some wild stuff](https://twitter.com/iquilezles/status/1369777008339611652) with them. > AND I dont want to have shell dependency no worries, the pixel shader path is totally separate from the shell. > * Framerate configuration > * Framerate limitation option: Adaptive FPS based on the throughput Right now the Terminal is hard capped at 60fps - that's something we're working on, I don't really want to spoil the fun. The pr is coming soon<sup>tm</sup>, but I'm not sure it's my place to discuss that one more. We won't paint _more_ often than 60fps, and we'll only paint a frame when there's actual output or something that changed on the screen. You might also be interested in #7147 - right now the Terminal needs to invalidate & redraw everything when pixel shaders are enabled. That definitely causes a noticeable perf hit when they're enabled, especially on laptops. I had a branch where I tried fixing that, just never had the time to drive it home. It might also just be fixed by the _secret rendering thing_ I mentioned above, hence why I shelved it. > Word wrap tends to mess with therminals > Having the option to change to Character Mode > So when it reaches the end of a line and searches for a place to break and depending on the code, every profile should have an option to configure the EOL expectation This I'm not sure I follow - the console&terminal don't do anything special to "find" a place to wrap a line. We just wrap it at the last character in the line. We're not trying to find a word break or anything, that's silly. Did I miss anything?
claunia commented 2026-01-31 04:44:18 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 26, 2021):

Also,

we need to talk .... [crutkas: edited]

That comes across as a little derogatory - make sure when you want to contribute here to follow the code of conduct

@zadjii-msft commented on GitHub (Oct 26, 2021): Also, > we need to talk .... [crutkas: edited] That comes across as a little derogatory - make sure when you want to contribute here to follow the [code of conduct](https://opensource.microsoft.com/codeofconduct/)
claunia commented 2026-01-31 04:44:18 +00:00
Author
Owner
Copy Link

@crutkas commented on GitHub (Oct 26, 2021):

@assembly-guy I'm editing your post, you had a clear code of conduct violation.

Our GitHub is a safe spot for everyone and should make everyone feel welcome. Lets be positive and inclusive. Thanks for understanding.

@crutkas commented on GitHub (Oct 26, 2021): @assembly-guy I'm editing your post, you had a clear code of conduct violation. Our GitHub is a safe spot for everyone and should make everyone feel welcome. Lets be positive and inclusive. Thanks for understanding.
claunia commented 2026-01-31 04:44:18 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 3, 2021):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Nov 3, 2021): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 04:44:19 +00:00
Author
Owner
Copy Link

@platypus-winterberry commented on GitHub (Nov 3, 2021):

Hello @crutkas

I was away for holidays hence my belated response.

Sorry if the wording's reader impact came up as unwelcoming as opposed to what I initially intended which was a friendly dev joke as I was excited to see all the openness from your team's side - I guess it's not the time and place to yet get into jokes.

Should there be anything I still need to revise on my initial post, please let me know. I'm still up to working on the before mentioned improvements.

All the best,
Alex

@platypus-winterberry commented on GitHub (Nov 3, 2021): Hello @crutkas I was away for holidays hence my belated response. Sorry if the wording's reader impact came up as unwelcoming as opposed to what I initially intended which was a friendly dev joke as I was excited to see all the openness from your team's side - I guess it's not the time and place to yet get into jokes. Should there be anything I still need to revise on my initial post, please let me know. I'm still up to working on the before mentioned improvements. All the best, Alex
claunia commented 2026-01-31 04:44:19 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 3, 2021):

I'm still up to working on the before mentioned improvements.

Does #7013 and #7147 cover everything you're looking for? If so, then I'd start there

@zadjii-msft commented on GitHub (Nov 3, 2021): > I'm still up to working on the before mentioned improvements. Does #7013 and #7147 cover everything you're looking for? If so, then I'd start there
claunia commented 2026-01-31 04:44:19 +00:00
Author
Owner
Copy Link

@platypus-winterberry commented on GitHub (Nov 3, 2021):

Hello @zadjii-msft

Yep, that's mostly it 🎖️ - tried looking for other open issues but there are way too many and my search queries did not return what I wanted 👍

I take it that #4000 is the current open issue for esthetics? ( As seen in #7013 )

Thank you for this and please don't refrain to give me some feedback on my initial posting so I can improve in the future.

Stay safe,
Alex.

@platypus-winterberry commented on GitHub (Nov 3, 2021): Hello @zadjii-msft Yep, that's mostly it 🎖️ - tried looking for other open issues but there are way too many and my search queries did not return what I wanted 👍 I take it that #4000 is the current open issue for esthetics? ( As seen in #7013 ) Thank you for this and please don't refrain to give me some feedback on my initial posting so I can improve in the future. Stay safe, Alex.
claunia commented 2026-01-31 04:44:19 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 3, 2021):

Meh, #4000 is more for vscode-like extensions to the Terminal, whatever that might mean. At the time, I didn't think it would be so trivial to implement in the Terminal itself, so I was planning on relying on 3rd party code to handle that. Turns out, it was easier than we expected 😅

I'm going to close this as a /duplicate of #7147, since that's the only real remaining open issue for now. If you do figure out a fun way to do cool-retro-term like effects, then we'd probably accept that as a PR to our pixel shader samples.

@zadjii-msft commented on GitHub (Nov 3, 2021): Meh, #4000 is more for vscode-like extensions to the Terminal, whatever that might mean. At the time, I didn't think it would be so trivial to implement in the Terminal itself, so I was planning on relying on 3rd party code to handle that. Turns out, it was easier than we expected 😅 I'm going to close this as a /duplicate of #7147, since that's the only real remaining open issue for now. If you do figure out a fun way to do cool-retro-term like effects, then we'd probably accept that as a PR to our [pixel shader samples](https://github.com/microsoft/terminal/tree/main/samples/PixelShaders).
claunia commented 2026-01-31 04:44:19 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 3, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Nov 3, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Question Resolution-Answered Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15645
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?