starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add If then else in json schema for conditional logic #15675

New Issue
Closed
opened 2026-01-31 04:45:12 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 04:45:12 +00:00
Owner
Copy Link

Originally created by @Joel-Nickson on GitHub (Oct 24, 2021).

Description of the new feature/enhancement

It would be nice to have conditions in json as defined in json-schema.org

Proposed technical implementation details (optional)

settings.json
...
"if":{"startingDirectory": "C:\\WINDOWS\\system32"},
"then":{"startingDirectory": "%USERPROFILE%\\Desktop"},
"else":{"startingDirectory": "."},
...

Problem:

  • I have set the "startingDirectory": "." in the settings.json for now. In that case the
    wt starts up at "C:\WINDOWS\system32" if i start the terminal from the start Menu or using an Autohot-key or any other app that can create an instance of the wt (like opening from cmd or from sublime-text),
    and if I right click on a folder and open the terminal then I get the terminal in the current directory of the folder.

  • And if I set the "startingDirectory": "C:\Users\\Desktop" then I get the terminal in that directory always(except on opening using menubar in a folder) even if I want to open it on a current folder sometimes

Other use cases:

  • increase the size of the terminal when using the split-pane actions maybe like
"when": {"command": {"action":"splitPane"}},
"then":["initialCols": 180,"initialRows": 30]
  • or changing the background of the window based on the current time(if it was possible to read system time or any how)
Originally created by @Joel-Nickson on GitHub (Oct 24, 2021). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement It would be nice to have conditions in json as defined in [json-schema.org](https://json-schema.org/understanding-json-schema/reference/conditionals.html#if-then-else) <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) ```json settings.json ... "if":{"startingDirectory": "C:\\WINDOWS\\system32"}, "then":{"startingDirectory": "%USERPROFILE%\\Desktop"}, "else":{"startingDirectory": "."}, ... ``` Problem: - I have set the "startingDirectory": "." in the settings.json for now. In that case the wt starts up at "C:\\WINDOWS\\system32" if i start the terminal from the start Menu or using an Autohot-key or any other app that can create an instance of the wt (like opening from cmd or from sublime-text), and if I right click on a folder and open the terminal then I get the terminal in the current directory of the folder. - And if I set the "startingDirectory": "C:\\Users\\<user>\\Desktop" then I get the terminal in that directory always(except on opening using menubar in a folder) even if I want to open it on a current folder sometimes <!-- A clear and concise description of what you want to happen. --> Other use cases: - increase the size of the terminal when using the split-pane actions maybe like ```json "when": {"command": {"action":"splitPane"}}, "then":["initialCols": 180,"initialRows": 30] ``` - or changing the background of the window based on the current time(if it was possible to read system time or any how)
claunia commented 2026-01-31 04:45:14 +00:00
Author
Owner
Copy Link

@Joel-Nickson commented on GitHub (Oct 25, 2021):

Sadly, I am not a developer from ms.
This issue will be tracked by the bot and then will be reviewed by the maintainers or developers and they have the power to assign this to you, not me.
If you know know what you need to do then I am sure you can work on it once they approve.

@Joel-Nickson commented on GitHub (Oct 25, 2021): Sadly, I am not a developer from ms. This issue will be tracked by the bot and then will be reviewed by the maintainers or developers and they have the power to assign this to you, not me. If you know know what you need to do then I am sure you can work on it once they approve.
claunia commented 2026-01-31 04:45:14 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 25, 2021):

@Joel-Nickson Is this not something that the commandline wt -d .would solve? I'd worry about adding a lot of potential complexity here. This sounds like something that'd be neigh-impossible to hook up to the settings UI in a reasonable fashion.

increase the size of the terminal when using the split-pane actions

This sounds like a good use case for the multipleActions action (new in 1.12), combined with the setWindowPos action (which is on my personal backlog but I don't think I filed anywhere)

changing the background of the window based on the current time(if it was possible to read system time or any how)

Now, that one doesn't have a good alternate solution, but feels like a good extension idea (#4000)

@zadjii-msft commented on GitHub (Oct 25, 2021): @Joel-Nickson Is this not something that the commandline `wt -d .`would solve? I'd worry about adding a _lot_ of potential complexity here. This sounds like something that'd be neigh-impossible to hook up to the settings UI in a reasonable fashion. > increase the size of the terminal when using the split-pane actions This sounds like a good use case for the `multipleActions` action (new in 1.12), combined with the `setWindowPos` action (which is on my personal backlog but I don't think I filed anywhere) > changing the background of the window based on the current time(if it was possible to read system time or any how) Now, that one doesn't have a good alternate solution, but feels like a good extension idea (#4000)
claunia commented 2026-01-31 04:45:15 +00:00
Author
Owner
Copy Link

@Joel-Nickson commented on GitHub (Oct 25, 2021):

multipleActions action (new in 1.12), combined with the setWindowPos action

I can't wait for the wt v1.12 then

Is this not something that the commandline wt -d . would solve?

and yes, that solved my problem 1

@Joel-Nickson commented on GitHub (Oct 25, 2021): > `multipleActions` action (new in 1.12), combined with the `setWindowPos` action I can't wait for the wt v1.12 then > Is this not something that the commandline wt -d . would solve? and yes, that solved my problem 1
claunia commented 2026-01-31 04:45:15 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Oct 26, 2021):

Glad to hear it! I'm gonna close this for now since the underlying problem is solved. If we come up with more elaborate use cases, and a more well-defined design, we can reopen in the future. Thanks!

@zadjii-msft commented on GitHub (Oct 26, 2021): Glad to hear it! I'm gonna close this for now since the underlying problem is solved. If we come up with more elaborate use cases, and a more well-defined design, we can reopen in the future. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Question Needs-Attention Needs-Triage Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15675
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?