Crash when splitting non-focused window with settings tab opened #15718

Closed
opened 2026-01-31 04:46:30 +00:00 by claunia · 4 comments
Owner

Originally created by @scm-xbox on GitHub (Oct 27, 2021).

Windows Terminal version (or Windows build number)

(Windows 11) 10.0.22000.0 (Windows Terminal) 1.11.2921.0

Other Software

No response

Steps to reproduce

image

Open any number of tabs (reproduced with 1 and 2 tabs).
Open the settings tab last.
Keep the settings tab focused.
Attempt to split one of the other tabs.
Notice you're no longer running Windows Terminal.

Expected Behavior

Splitting a tab while the settings window is focused should either fail gracefully or work.

Actual Behavior

Slightly slower way to close windows terminal without being prompted.

Originally created by @scm-xbox on GitHub (Oct 27, 2021). ### Windows Terminal version (or Windows build number) (Windows 11) 10.0.22000.0 (Windows Terminal) 1.11.2921.0 ### Other Software _No response_ ### Steps to reproduce ![image](https://user-images.githubusercontent.com/22456091/139125881-be08deb3-a0ce-4654-826e-2a2f8cfa1831.png) Open any number of tabs (reproduced with 1 and 2 tabs). Open the settings tab last. Keep the settings tab focused. Attempt to split one of the other tabs. Notice you're no longer running Windows Terminal. ### Expected Behavior Splitting a tab while the settings window is focused should either fail gracefully or work. ### Actual Behavior Slightly slower way to close windows terminal without being prompted.
Author
Owner

@elsaco commented on GitHub (Oct 27, 2021):

Reproduced on WT Preview version 1.12.2931.0 also. Looks like it's trying to dereference a null pointer:

TerminalApp!DllGetActivationFactory+0x177bd:
00007ffe`3d7ba33d 488b01          mov     rax,qword ptr [rcx] ds:00000000`00000000=????????????????

Some more debug info:

PROCESS_NAME:  WindowsTerminal.exe

ERROR_CODE: (NTSTATUS) 0xc0000005 - The instruction at 0x%p referenced memory at 0x%p. The memory could not be %s.

SYMBOL_NAME:  TerminalApp!DllGetActivationFactory+177bd

MODULE_NAME: TerminalApp

IMAGE_NAME:  TerminalApp.dll

FAILURE_BUCKET_ID:  NULL_POINTER_READ_c0000005_TerminalApp.dll!DllGetActivationFactory

FAILURE_ID_HASH:  {9bda705a-f16f-9bbc-bccf-35fe46a5a46c}

Followup:     MachineOwner
@elsaco commented on GitHub (Oct 27, 2021): Reproduced on WT Preview version 1.12.2931.0 also. Looks like it's trying to dereference a null pointer: ``` TerminalApp!DllGetActivationFactory+0x177bd: 00007ffe`3d7ba33d 488b01 mov rax,qword ptr [rcx] ds:00000000`00000000=???????????????? ``` Some more debug info: ``` PROCESS_NAME: WindowsTerminal.exe ERROR_CODE: (NTSTATUS) 0xc0000005 - The instruction at 0x%p referenced memory at 0x%p. The memory could not be %s. SYMBOL_NAME: TerminalApp!DllGetActivationFactory+177bd MODULE_NAME: TerminalApp IMAGE_NAME: TerminalApp.dll FAILURE_BUCKET_ID: NULL_POINTER_READ_c0000005_TerminalApp.dll!DllGetActivationFactory FAILURE_ID_HASH: {9bda705a-f16f-9bbc-bccf-35fe46a5a46c} Followup: MachineOwner ```
Author
Owner

@PankajBhojwani commented on GitHub (Oct 27, 2021):

Thanks for catching this! Pushed a fix for it

@PankajBhojwani commented on GitHub (Oct 27, 2021): Thanks for catching this! Pushed a fix for it
Author
Owner

@ghost commented on GitHub (Dec 14, 2021):

:tada:This issue was addressed in #11635, which has now been successfully released as Windows Terminal Preview v1.12.3472.0.🎉

Handy links:

@ghost commented on GitHub (Dec 14, 2021): :tada:This issue was addressed in #11635, which has now been successfully released as `Windows Terminal Preview v1.12.3472.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.12.3472.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (Dec 14, 2021):

:tada:This issue was addressed in #11635, which has now been successfully released as Windows Terminal v1.11.3471.0.🎉

Handy links:

@ghost commented on GitHub (Dec 14, 2021): :tada:This issue was addressed in #11635, which has now been successfully released as `Windows Terminal v1.11.3471.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.11.3471.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15718