starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Infobar for "make terminal the default" doesn't remember it was dismissed upon new OS flight #15822

New Issue
Closed
opened 2026-01-31 04:49:24 +00:00 by claunia · 13 comments
claunia commented 2026-01-31 04:49:24 +00:00
Owner
Copy Link

Originally created by @asklar on GitHub (Nov 9, 2021).

Windows Terminal version (or Windows build number)

22496

Other Software

No response

Steps to reproduce

launch terminal, get the infobar about making Terminal de default console.
Close it, don't make it the default

get a new OS flight
launch terminal - same infobar shows up again

Expected Behavior

setting gets persisted

Actual Behavior

terminal insists

Originally created by @asklar on GitHub (Nov 9, 2021). ### Windows Terminal version (or Windows build number) 22496 ### Other Software _No response_ ### Steps to reproduce launch terminal, get the infobar about making Terminal de default console. Close it, don't make it the default get a new OS flight launch terminal - same infobar shows up again ### Expected Behavior setting gets persisted ### Actual Behavior terminal insists
claunia added the Needs-TriageNeeds-Tag-FixNeeds-Attention labels 2026-01-31 04:49:24 +00:00
claunia commented 2026-01-31 04:49:25 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 9, 2021):

@asklar can you share a copy of state.json from %LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState?

Closing the infobar should make us record that it was dismissed. This is not tracked per OS version or stored anywhere that the OS would clear on upgrade.

@DHowett commented on GitHub (Nov 9, 2021): @asklar can you share a copy of `state.json` from `%LOCALAPPDATA%\Packages\Microsoft.WindowsTerminal_8wekyb3d8bbwe\LocalState`? Closing the infobar should make us record that it was dismissed. This is not tracked per OS version or stored anywhere that the OS would clear on upgrade.
claunia commented 2026-01-31 04:49:26 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 9, 2021):

(This assumes that you are using Terminal Stable and not switching back and forth between Stable and Preview, and that you are not using unpackaged terminal -- since you did not include a Terminal version, I must assume the formermost.)

@DHowett commented on GitHub (Nov 9, 2021): (This assumes that you are using Terminal Stable and not switching back and forth between Stable and Preview, and that you are not using unpackaged terminal -- since you did not include a Terminal version, I must assume the formermost.)
claunia commented 2026-01-31 04:49:26 +00:00
Author
Owner
Copy Link

@asklar commented on GitHub (Nov 9, 2021):

Using Preview, version 1.11.2921.0

{
	"dismissedMessages" : 
	[
		"setAsDefault"
	],
	"generatedProfiles" : 
	[
		"{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
		"{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
		"{574e775e-4f2a-5b96-ac1e-a2962a402336}",
		"{b453ae62-4e3d-5e58-b989-0a998ec441b8}"
	]
}

This is after dismissing the message. I guess I should check the content of this file after the next flight?
or maybe app updates/installs are clearing the localstate folder?

@asklar commented on GitHub (Nov 9, 2021): Using Preview, version 1.11.2921.0 ``` { "dismissedMessages" : [ "setAsDefault" ], "generatedProfiles" : [ "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}", "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}", "{574e775e-4f2a-5b96-ac1e-a2962a402336}", "{b453ae62-4e3d-5e58-b989-0a998ec441b8}" ] } ``` This is after dismissing the message. I guess I should check the content of this file after the next flight? or maybe app updates/installs are clearing the localstate folder?
claunia commented 2026-01-31 04:49:26 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 9, 2021):

or maybe app updates/installs are clearing the localstate folder?

That would definitely be worth checking! That's where we keep our settings, as well. Have you noticed Terminal deleting all your settings across OS upgrades? Would you mind capturing a snapshot of that directory next time you flight?

@DHowett commented on GitHub (Nov 9, 2021): > or maybe app updates/installs are clearing the localstate folder? That would definitely be worth checking! That's where we keep our settings, as well. Have you noticed Terminal deleting all your settings across OS upgrades? Would you mind capturing a snapshot of that directory next time you flight?
claunia commented 2026-01-31 04:49:26 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 13, 2021):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Nov 13, 2021): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 04:49:26 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 16, 2021):

(I'll reopen this for another 7 days)

@DHowett commented on GitHub (Nov 16, 2021): (I'll reopen this for another 7 days)
claunia commented 2026-01-31 04:49:27 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 21, 2021):

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@ghost commented on GitHub (Nov 21, 2021): This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **4 days**. It will be closed if no further activity occurs **within 3 days of this comment**.
claunia commented 2026-01-31 04:49:27 +00:00
Author
Owner
Copy Link

@asklar commented on GitHub (Nov 21, 2021):

just hit this again, and this is the content now:

{
        "generatedProfiles" :
        [
                "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "{574e775e-4f2a-5b96-ac1e-a2962a402336}",
                "{63e31163-583f-5850-9c1e-24e227dd2da9}",
                "{b453ae62-4e3d-5e58-b989-0a998ec441b8}"
        ]
}
@asklar commented on GitHub (Nov 21, 2021): just hit this again, and this is the content now: ```json { "generatedProfiles" : [ "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}", "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}", "{574e775e-4f2a-5b96-ac1e-a2962a402336}", "{63e31163-583f-5850-9c1e-24e227dd2da9}", "{b453ae62-4e3d-5e58-b989-0a998ec441b8}" ] } ```
claunia commented 2026-01-31 04:49:27 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 22, 2021):

It is deeply concerning that your state is getting destroyed but your settings are not... or.. are they? Do you tend to change settings.json at all?

@DHowett commented on GitHub (Nov 22, 2021): It is deeply concerning that your state is getting destroyed but your settings are not... or.. are they? Do you tend to change `settings.json` at all?
claunia commented 2026-01-31 04:49:27 +00:00
Author
Owner
Copy Link

@asklar commented on GitHub (Nov 22, 2021):

I haven't changed the state in a while... the only change I remember making in the last few months is adding -nologo to pwsh since I don't want to be reminded of the "build du jour" every time

@asklar commented on GitHub (Nov 22, 2021): I haven't changed the state in a while... the only change I remember making in the last few months is adding `-nologo` to pwsh since I don't want to be reminded of the "build du jour" every time
claunia commented 2026-01-31 04:49:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 2, 2021):

An OS update shouldn't be clearing out things from %LOCALAPPDATA%, right? Yea of course not, the settings file doesn't get deleted. There's also no code that's shipped yet for blowing away the elevated version of that file, so it's not like I'm accidentally doing that...

Maybe this is the thing where we can't find the settings file, or find that it's empty, and then re-create the state. Trick is, why do we think we can't find it? (and why isn't anyone else on the team seeing this?)

@zadjii-msft commented on GitHub (Dec 2, 2021): An OS update shouldn't be clearing out things from `%LOCALAPPDATA%`, right? Yea of course not, the settings file doesn't get deleted. There's also no code that's shipped yet for blowing away the elevated version of that file, so it's not like I'm accidentally doing that... Maybe this is the thing where we can't find the settings file, or find that it's empty, and then re-create the state. Trick is, why do we think we can't find it? (and why isn't anyone else on the team seeing this?)
claunia commented 2026-01-31 04:49:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 5, 2022):

You know, we've shipped this warning for a few months now and we've only ever gotten this one report of it. That's super weird. the rest of the code around this has stabilized for a few releases now - is this still happening/?

@zadjii-msft commented on GitHub (Jul 5, 2022): You know, we've shipped this warning for a few months now and we've only ever gotten this one report of it. That's super weird. the rest of the code around this has stabilized for a few releases now - is this still happening/?
claunia commented 2026-01-31 04:49:28 +00:00
Author
Owner
Copy Link

@asklar commented on GitHub (Jul 5, 2022):

haven't seen this recently

@asklar commented on GitHub (Jul 5, 2022): haven't seen this recently
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Attention Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15822
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?