starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Clean up CreateFile loop in ReadUTF8File #15874

New Issue
Open
opened 2026-01-31 04:51:05 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 04:51:05 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Nov 12, 2021).

ReadUTF8File in the Settings library tries three times to read the settings file. If the size changes while it is being read, it'll try again.

Right now, the code looks like this (roughly):

while(tries) {
    open
    check permissions
    read in full
    check read size
}

It's expensive to open the file and check the permissions every time. Instead, we could:

open
check permissions
while (tries) {
    reset file pointer
    read in full
    check read size
}

That'll save us closing/reopening the file up to three times.

Originally created by @DHowett on GitHub (Nov 12, 2021). `ReadUTF8File` in the Settings library tries three times to read the settings file. If the size changes while it is being read, it'll try again. Right now, the code looks like this (roughly): ``` while(tries) { open check permissions read in full check read size } ``` It's expensive to open the file and check the permissions every time. Instead, we could: ``` open check permissions while (tries) { reset file pointer read in full check read size } ``` That'll save us closing/reopening the file up to three times.
claunia added the Area-SettingsIssue-TaskProduct-TerminalArea-CodeHealth labels 2026-01-31 04:51:06 +00:00
claunia commented 2026-01-31 04:51:07 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 12, 2021):

Though -- what if we fail to open the file because somebody has it locked? Wouldn't we want to retry some time later so as to not frag the user's settings as "invalid"? That suggests that we may want to retry opening it as well...

@DHowett commented on GitHub (Nov 12, 2021): Though -- what if we fail to open the file because somebody has it locked? Wouldn't we want to retry some time later so as to not frag the user's settings as "invalid"? That suggests that we _may_ want to retry opening it as well...
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Area-Settings Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15874
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?