starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Far Manager broken with commit 6742965bb8 #15917

New Issue
Closed
opened 2026-01-31 04:52:09 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 04:52:09 +00:00
Owner
Copy Link

Originally created by @igorkuzuro on GitHub (Nov 18, 2021).

Windows Terminal version

Dev

Windows build number

Microsoft Windows [Version 10.0.22494.1000]

Other Software

Far Manager 3.0 (v3.0.5919.2537 and previous builds)

Steps to reproduce

Just open Far Manager in Windows Terminal

Expected Behavior

Expected this normal Far manager display:

image

Actual Behavior

But...

image

Originally created by @igorkuzuro on GitHub (Nov 18, 2021). ### Windows Terminal version Dev ### Windows build number Microsoft Windows [Version 10.0.22494.1000] ### Other Software Far Manager 3.0 (v3.0.5919.2537 and previous builds) ### Steps to reproduce Just open Far Manager in Windows Terminal ### Expected Behavior Expected this normal Far manager display: ![image](https://user-images.githubusercontent.com/1778999/142399875-1b4725aa-0127-43b5-b6a3-af220faf7282.png) ### Actual Behavior But... ![image](https://user-images.githubusercontent.com/1778999/142398448-8d5f8e80-ad6c-42ef-a834-3f6d4cda0955.png)
claunia commented 2026-01-31 04:52:11 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 18, 2021):

6742965bb8 - hmm. Was Conpty using the C1 escape to format it's sequences? Is Far manager using that one maybe? Hmmm. @igorkuzuro Does this repro with an OpenConsole that's built from that commit as well? Or is this only a Terminal issue. Might narrow things down.

@zadjii-msft commented on GitHub (Nov 18, 2021): 6742965bb89f1391f4ac036e52bcf68f7db305f6 - hmm. Was Conpty using the C1 escape to format it's sequences? Is Far manager using that one maybe? Hmmm. @igorkuzuro Does this repro with an OpenConsole that's built from that commit as well? Or is this only a Terminal issue. Might narrow things down.
claunia commented 2026-01-31 04:52:11 +00:00
Author
Owner
Copy Link

@igorkuzuro commented on GitHub (Nov 18, 2021):

6742965 - hmm. Was Conpty using the C1 escape to format it's sequences? Is Far manager using that one maybe? Hmmm. @igorkuzuro Does this repro with an OpenConsole that's built from that commit as well? Or is this only a Terminal issue. Might narrow things down.

Of course I tried Terminal without this commit - everything works as expected... now will try OpenConsole with this commit

@igorkuzuro commented on GitHub (Nov 18, 2021): > [6742965](https://github.com/microsoft/terminal/commit/6742965bb89f1391f4ac036e52bcf68f7db305f6) - hmm. Was Conpty using the C1 escape to format it's sequences? Is Far manager using that one maybe? Hmmm. @igorkuzuro Does this repro with an OpenConsole that's built from that commit as well? Or is this only a Terminal issue. Might narrow things down. Of course I tried Terminal without this commit - everything works as expected... now will try OpenConsole with this commit
claunia commented 2026-01-31 04:52:11 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Nov 18, 2021):

(╯°□°）╯︵ ┻━┻

We can't win here. It looks like the same person that demanded we remove support for C1 controls was also responsible for making FarManager depend on C1 controls (c04740947d).

@j4james commented on GitHub (Nov 18, 2021): (╯°□°）╯︵ ┻━┻ We can't win here. It looks like the same person that demanded we remove support for C1 controls was also responsible for making FarManager depend on C1 controls (https://github.com/FarGroup/FarManager/commit/c04740947d79eacba6ab039d3803dd49dcd153bf).
claunia commented 2026-01-31 04:52:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 18, 2021):

Yo @alabuzhev, any idea what we should do here?

The Far commit is from 2019, so they've shipped with that for a while now.

I'm linking in #10310 for more context

@zadjii-msft commented on GitHub (Nov 18, 2021): Yo @alabuzhev, any idea what we _should_ do here? The Far commit is from 2019, so they've shipped with that for a while now. I'm linking in #10310 for more context
claunia commented 2026-01-31 04:52:12 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Nov 18, 2021):

It's also worth mentioning that this doesn't fail for an out-of-the-box install of FarManager as far as I can see. You've got to go into the Interface Settings and enable Use Virtual Terminal for rendering. But I'm assuming there may be a lot of people with that option already set.

@j4james commented on GitHub (Nov 18, 2021): It's also worth mentioning that this doesn't fail for an out-of-the-box install of FarManager as far as I can see. You've got to go into the _Interface Settings_ and enable _Use Virtual Terminal for rendering_. But I'm assuming there may be a lot of people with that option already set.
claunia commented 2026-01-31 04:52:12 +00:00
Author
Owner
Copy Link

@alabuzhev commented on GitHub (Nov 18, 2021):

Hmm, interesting.
So at some point \x9b became a control character and broken our output in some cases.
We replaced it with something else, but it also made it into the renderer instead of \033[ (I don't really remember why, probably it's leftovers from my experiments with understanding its meaning).

Then more characters became control, and now none of them, and that doesn't work anymore.

As @j4james mentioned, VT renderer is off by default, so it's probably not a big issue. We will fix it on our side and, since we release more often than WT, this hopefully won't be a problem anymore when the next WT version is released.

@alabuzhev commented on GitHub (Nov 18, 2021): Hmm, interesting. So at some point `\x9b` became a control character and broken our output in some cases. We replaced it with something else, but it also made it into the renderer instead of `\033[` (I don't really remember why, probably it's leftovers from my experiments with understanding its meaning). Then more characters became control, and now none of them, and that doesn't work anymore. As @j4james mentioned, VT renderer is off by default, so it's probably not a big issue. We will fix it on our side and, since we release more often than WT, this hopefully won't be a problem anymore when the next WT version is released.
claunia commented 2026-01-31 04:52:12 +00:00
Author
Owner
Copy Link

@igorkuzuro commented on GitHub (Nov 18, 2021):

Hmm, interesting. So at some point \x9b became a control character and broken our output in some cases. We replaced it with something else, but it also made it into the renderer instead of \033[ (I don't really remember why, probably it's leftovers from my experiments with understanding its meaning).

Then more characters became control, and now none of them, and that doesn't work anymore.

As @j4james mentioned, VT renderer is off by default, so it's probably not a big issue. We will fix it on our side and, since we release more often than WT, this hopefully won't be a problem anymore when the next WT version is released.

Yes, I don't remember when and why I start using VT renderer... when this option is off everything work as expected.

@igorkuzuro commented on GitHub (Nov 18, 2021): > Hmm, interesting. So at some point `\x9b` became a control character and broken our output in some cases. We replaced it with something else, but it also made it into the renderer instead of `\033[` (I don't really remember why, probably it's leftovers from my experiments with understanding its meaning). > > Then more characters became control, and now none of them, and that doesn't work anymore. > > As @j4james mentioned, VT renderer is off by default, so it's probably not a big issue. We will fix it on our side and, since we release more often than WT, this hopefully won't be a problem anymore when the next WT version is released. Yes, I don't remember when and why I start using VT renderer... when this option is off everything work as expected.
claunia commented 2026-01-31 04:52:13 +00:00
Author
Owner
Copy Link

@alabuzhev commented on GitHub (Nov 18, 2021):

Fixed in FarGroup/FarManager@54e95ad5c0

@alabuzhev commented on GitHub (Nov 18, 2021): Fixed in FarGroup/FarManager@54e95ad5c08bb2ac8d5cf6ed78992c4b92624918
claunia commented 2026-01-31 04:52:13 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 19, 2021):

Thanks! I'll close this one out as external (heh, as a /duplicate of 54e95ad5c0 which admittedly is a commit...) but keep an eye on it. @Igorkuzuro, thanks for running nightly/dev builds! We should really make them available to people. 😄

@DHowett commented on GitHub (Nov 19, 2021): Thanks! I'll close this one out as external (heh, as a /duplicate of https://github.com/FarGroup/FarManager/commit/54e95ad5c08bb2ac8d5cf6ed78992c4b92624918 which admittedly is a commit...) but keep an eye on it. @Igorkuzuro, thanks for running nightly/dev builds! We should really make them available to people. :smile:
claunia commented 2026-01-31 04:52:13 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 19, 2021):

Hi! We've identified this issue as a duplicate of one that exists on somebody else's Issue Tracker. Please make sure you subscribe to the referenced external issue for future updates. Thanks for your report!

@ghost commented on GitHub (Nov 19, 2021): Hi! We've identified this issue as a duplicate of one that exists on somebody else's Issue Tracker. Please make sure you subscribe to the referenced external issue for future updates. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Issue-Bug Needs-Tag-Fix Priority-1 Resolution-External Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15917
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?