starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 07:54:35 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

URL highlight issues with emoji #15944

New Issue
Closed
opened 2026-01-31 04:52:59 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 04:52:59 +00:00
Owner
Copy Link

Originally created by @ggnkua on GitHub (Nov 21, 2021).

Windows Terminal version

1.11.2921.0

Windows build number

10.0.19043.1348

Other Software

WSL 2 (using Ubuntu 20.04.2 LTS)

Steps to reproduce

Open a wsl2 and paste the following line:

😃👍🕹🕹️ http://microsoft.com

In my machine I get:

image

Notice the two spaces between // and microsoft.com. Sometimes those two spaces appear, some times they don't.

If I move the cursor and delete the two spaces, and then try to highlight the URL I get:

image

Trying to ctrl-click the URL gives:

image

Expected Behavior

The URL should appear without spaces, the URL should be underlined and clickable.

Actual Behavior

The URL failed to highlight properly, and when ctrl-clicking it, it produced the error shown in the last screenshot in "steps to reproduce"

Originally created by @ggnkua on GitHub (Nov 21, 2021). ### Windows Terminal version 1.11.2921.0 ### Windows build number 10.0.19043.1348 ### Other Software WSL 2 (using Ubuntu 20.04.2 LTS) ### Steps to reproduce Open a wsl2 and paste the following line: 😃👍🕹🕹️ http://microsoft.com In my machine I get: ![image](https://user-images.githubusercontent.com/5121492/142774913-f8035fcf-9d31-48d0-9169-6b6b12e2f0a0.png) Notice the two spaces between `//` and `microsoft.com`. Sometimes those two spaces appear, some times they don't. If I move the cursor and delete the two spaces, and then try to highlight the URL I get: ![image](https://user-images.githubusercontent.com/5121492/142774996-8cc140a4-1008-4c64-a0b8-100a00cf603f.png) Trying to ctrl-click the URL gives: ![image](https://user-images.githubusercontent.com/5121492/142775025-83bd973b-1e79-41f6-a54c-465235df9cd9.png) ### Expected Behavior The URL should appear without spaces, the URL should be underlined and clickable. ### Actual Behavior The URL failed to highlight properly, and when ctrl-clicking it, it produced the error shown in the last screenshot in "steps to reproduce"
claunia added the Resolution-Duplicate label 2026-01-31 04:52:59 +00:00
claunia commented 2026-01-31 04:53:01 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Nov 21, 2021):

This could probably be considered a duplicate of #8709. More fundamentally, though, I think the issue is that we can't handle characters outside the BMP which have a narrow width. I expect this will be solved by #8000.

@j4james commented on GitHub (Nov 21, 2021): This could probably be considered a duplicate of #8709. More fundamentally, though, I think the issue is that we can't handle characters outside the BMP which have a narrow width. I expect this will be solved by #8000.
claunia commented 2026-01-31 04:53:02 +00:00
Author
Owner
Copy Link

@ggnkua commented on GitHub (Nov 21, 2021):

Oh gosh, so it has been reported already. I tried searching for an open issue but I wasn't sure how to search for it.

Should we close this as duplicate or leave open?

@ggnkua commented on GitHub (Nov 21, 2021): Oh gosh, so it has been reported already. I tried searching for an open issue but I wasn't sure how to search for it. Should we close this as duplicate or leave open?
claunia commented 2026-01-31 04:53:02 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Nov 21, 2021):

Not to worry. Even if closed as a duplicate, it's good to have easily reproducible test cases like this to check whether a future fix is actually working as expected. One of the core devs will probably close this if they confirm it's definitely a dup.

@j4james commented on GitHub (Nov 21, 2021): Not to worry. Even if closed as a duplicate, it's good to have easily reproducible test cases like this to check whether a future fix is actually working as expected. One of the core devs will probably close this if they confirm it's definitely a dup.
claunia commented 2026-01-31 04:53:02 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 22, 2021):

No worries, this definitely looks like /dup #8709, thanks!

@zadjii-msft commented on GitHub (Nov 22, 2021): No worries, this definitely looks like /dup #8709, thanks!
claunia commented 2026-01-31 04:53:03 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 22, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Nov 22, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#15944
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?