Untie "active control" from "currently XAML-focused control" #1603

Closed
opened 2026-01-30 22:31:48 +00:00 by claunia · 3 comments
Owner

Originally created by @DHowett-MSFT on GitHub (Jun 11, 2019).

I think there are some issues in tying "active control" to "control currently focused in the XAML stack".. what do you think? Should we just holistically fix this all up by making active/focused not the same?

A tab should have a notion of its "active control", even if that control isn't currently focused. Right now, we have some problematic mixing of user intent and UI state that cause us to have tabs with no active control and tabs whose titles flicker when they become "focused" even though what's "active" hasn't changed.

Changes in which control is active can be propagated out through a single "ActiveTerminalChanged" event.

Originally created by @DHowett-MSFT on GitHub (Jun 11, 2019). > I think there are some issues in tying "active control" to "control currently focused in the XAML stack".. what do you think? Should we just holistically fix this all up by making active/focused not the same? A tab should have a notion of its "active control", even if that control isn't currently focused. Right now, we have some problematic mixing of user intent and UI state that cause us to have tabs with no active control and tabs whose titles flicker when they become "focused" even though what's "active" hasn't changed. Changes in which control is active can be propagated out through a single "ActiveTerminalChanged" event.
Author
Owner

@zadjii-msft commented on GitHub (Jul 8, 2019):

The bug reported in 1862 is super annoying, so this should definitely go in for 1.0.

@zadjii-msft commented on GitHub (Jul 8, 2019): The bug reported in 1862 is super annoying, so this should definitely go in for 1.0.
Author
Owner

@zadjii-msft commented on GitHub (Sep 17, 2019):

Another excellent manifestation of this problem: open another application, and the terminal with multiple tabs. Switch focus between the Terminal and the other app, by clicking specifically on the tabs. Eventually, the tab will lose it's title, because no control is focused:
image

@zadjii-msft commented on GitHub (Sep 17, 2019): Another excellent manifestation of this problem: open another application, and the terminal with multiple tabs. Switch focus between the Terminal and the other app, by clicking specifically on the tabs. Eventually, the tab will lose it's title, because no control is focused: ![image](https://user-images.githubusercontent.com/18356694/65050933-0ef92a00-d91d-11e9-8c9a-ad45520b44c0.png)
Author
Owner

@ghost commented on GitHub (Nov 26, 2019):

:tada:This issue was addressed in #3540, which has now been successfully released as Windows Terminal Preview v0.7.3291.0.🎉

Handy links:

@ghost commented on GitHub (Nov 26, 2019): :tada:This issue was addressed in #3540, which has now been successfully released as `Windows Terminal Preview v0.7.3291.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.7.3291.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1603