Settings tab scroll is lost after every save #16039

Closed
opened 2026-01-31 04:55:42 +00:00 by claunia · 5 comments
Owner

Originally created by @inlineHamed on GitHub (Dec 3, 2021).

Windows Terminal version

1.11.2921.0

Windows build number

10.0.22000.0

Other Software

No response

Steps to reproduce

  1. Open Settings tab (Ctrl + ,)
  2. Go to some profile from sidebar
  3. Vertically scroll to some position
  4. Hit 'Save' button

Expected Behavior

Just saving with no extra effect

Actual Behavior

The entire page flashes and the page scroll bar is reset at the top (It seems that a full refresh of page is happening).
It's more annoying if you want to change something not at the top of page (like background settings) and want to see the actual result and refine the settings many times.

Originally created by @inlineHamed on GitHub (Dec 3, 2021). ### Windows Terminal version 1.11.2921.0 ### Windows build number 10.0.22000.0 ### Other Software _No response_ ### Steps to reproduce 1) Open Settings tab (Ctrl + ,) 2) Go to some profile from sidebar 3) Vertically scroll to some position 4) Hit 'Save' button ### Expected Behavior Just saving with no extra effect ### Actual Behavior The entire page flashes and the page scroll bar is reset at the top (It seems that a full refresh of page is happening). It's more annoying if you want to change something not at the top of page (like background settings) and want to see the actual result and refine the settings many times.
Author
Owner

@zadjii-msft commented on GitHub (Dec 6, 2021):

This might not be too hard to fix. I believe that a ScrollViewer has a method for getting the current scroll position, so we should be able to persist that across saves.

@zadjii-msft commented on GitHub (Dec 6, 2021): This might not be too hard to fix. I believe that a ScrollViewer has a method for getting the current scroll position, so we _should_ be able to persist that across saves.
Author
Owner

@Jcabza008 commented on GitHub (Jan 31, 2022):

Hi, I wanted to start contributing to open source project and I found this one to be of great interest to me. I took a shot at this issue and submitted a PR #12296. I'd appreciate it if I could get some feedback on this. Thank you.

@Jcabza008 commented on GitHub (Jan 31, 2022): Hi, I wanted to start contributing to open source project and I found this one to be of great interest to me. I took a shot at this issue and submitted a PR #12296. I'd appreciate it if I could get some feedback on this. Thank you.
Author
Owner

@yashwantpradhan commented on GitHub (Oct 19, 2023):

I want to work on this issue. Please assign me this issue.

@yashwantpradhan commented on GitHub (Oct 19, 2023): I want to work on this issue. Please assign me this issue.
Author
Owner

@radu-cernatescu commented on GitHub (Nov 1, 2023):

Hello, I will take over this issue if no one is working on it. Please assign to me, thanks!

@radu-cernatescu commented on GitHub (Nov 1, 2023): Hello, I will take over this issue if no one is working on it. Please assign to me, thanks!
Author
Owner

@zadjii-msft commented on GitHub (Nov 1, 2023):

Y'all can just go for it - we don't really utilize the "assigned to" field. There's very rarely multiple people who are trying to work on the same issue at the same time.

@zadjii-msft commented on GitHub (Nov 1, 2023): Y'all can just go for it - we don't _really_ utilize the "assigned to" field. There's very rarely multiple people who are trying to work on the same issue at the same time.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16039