starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Re-enable TerminalApp tests SettingsTests and TabsTests #1609

New Issue
Closed
opened 2026-01-30 22:31:54 +00:00 by claunia · 1 comment
claunia commented 2026-01-30 22:31:54 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jun 11, 2019).

This is a follow up from #1164.

Right now our CI isn't running a windows version high enough to be able to run these tests, so they're commented out.

Once #1012 is checked in, we can re-enable those tests.

Originally created by @zadjii-msft on GitHub (Jun 11, 2019). This is a follow up from #1164. Right now our CI isn't running a windows version high enough to be able to run these tests, so they're commented out. Once #1012 is checked in, we can re-enable those tests.
claunia commented 2026-01-30 22:31:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 25, 2019):

We might be able to re-enable the SettingsTests without re-enabling the TabTests. The TabTests rely on XAML Islands, which isn't supported on the build machines. the TabTests require deploying a appx on the test machine, but we can't just skip the test if the build machine isn't a high enough version.

However, since the SettingsTests only rely on SxS activation, we might be able to check the version in the CLASS_SETUP, and skip the test if the machine isn't the right version.

@zadjii-msft commented on GitHub (Jul 25, 2019): We might be able to re-enable the SettingsTests without re-enabling the TabTests. The TabTests rely on XAML Islands, which isn't supported on the build machines. the TabTests require deploying a appx on the test machine, but we can't just skip the test if the build machine isn't a high enough version. However, since the SettingsTests only rely on SxS activation, we might be able to check the version in the CLASS_SETUP, and skip the test if the machine isn't the right version.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Task Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1609
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?