starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Figure out how to support bindings for "VK_OEM" keys #1610

New Issue
Closed
opened 2026-01-30 22:31:59 +00:00 by claunia · 6 comments
claunia commented 2026-01-30 22:31:59 +00:00
Owner
Copy Link

Originally created by @DHowett-MSFT on GitHub (Jun 12, 2019).

Originally assigned to: @DHowett-MSFT on GitHub.

ecfaa76a89/src/cascadia/TerminalApp/KeyChordSerialization.cpp (L75-L85)

Originally created by @DHowett-MSFT on GitHub (Jun 12, 2019). Originally assigned to: @DHowett-MSFT on GitHub. https://github.com/microsoft/terminal/blob/ecfaa76a895da18a2997c4e7dbd4b3fccdf2d889/src/cascadia/TerminalApp/KeyChordSerialization.cpp#L75-L85
claunia commented 2026-01-30 22:32:01 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (Jun 12, 2019):

Yanking the triage tag. This is a TODO from code.

@DHowett-MSFT commented on GitHub (Jun 12, 2019): Yanking the triage tag. This is a `TODO` from code.
claunia commented 2026-01-30 22:32:01 +00:00
Author
Owner
Copy Link

@shanselman commented on GitHub (Jun 12, 2019):

I’m looking to have CTRL+| (which is ctrl shift \ on my keyboard) split vertical. Not possible today.

For horizontal I’m using CTRL+SHIFT+- which is CTRL+_

FYI+context

@shanselman commented on GitHub (Jun 12, 2019): I’m looking to have CTRL+| (which is ctrl shift \ on my keyboard) split vertical. Not possible today. For horizontal I’m using CTRL+SHIFT+- which is CTRL+_ FYI+context
claunia commented 2026-01-30 22:32:01 +00:00
Author
Owner
Copy Link

@timheuer commented on GitHub (Jun 12, 2019):

One way maybe to be able to handle this would be to allow VK_** int values to be used in the binding 'language' to avoid a bunch of hard coding of VK and missing ones. enables you to you say "ctrl+(vk)32" ? -- just a wild idea.

I think in @shanselman use case, supporting a keybinding that already involves a modifier might be tough (I don't see cmder/conemu handle this either). But even supporting CTRL+\ (the non-shifted pipe character that maps to VK_SEPARATOR) doesn't work right now.

@timheuer commented on GitHub (Jun 12, 2019): One way maybe to be able to handle this would be to allow VK_** int values to be used in the binding 'language' to avoid a bunch of hard coding of VK and missing ones. enables you to you say "ctrl+(vk)32" ? -- just a wild idea. I think in @shanselman use case, supporting a keybinding that already involves a modifier might be tough (I don't see cmder/conemu handle this either). But even supporting CTRL+\ (the non-shifted pipe character that maps to VK_SEPARATOR) doesn't work right now.
claunia commented 2026-01-30 22:32:02 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 12, 2019):

I'd really love it if there was a way that we could just take a character and get the vkey from it. That way, if a user put ctrl+| in their json, we'd try to find the key from the char in our map, fail, then ask the OS what vkey that should be. We'd look up what the actual vkey is, find VK_OEM_5, Shift, and use that key+modifiers at runtime. There's a pretty good chance there's a relative of MapVirtualKey that might work for that purpose. However, we'd need to make sure that when we re-serialize the key, that we don't lose the original. (granted, that would be fixed by #754, so maybe we should do that one first or just live with it for now...)

@zadjii-msft commented on GitHub (Jun 12, 2019): I'd really love it if there was a way that we could just take a character and get the vkey from it. That way, if a user put `ctrl+|` in their json, we'd try to find the key from the char in our map, fail, then ask the OS what vkey that should be. We'd look up what the actual vkey is, find `VK_OEM_5, Shift`, and use that key+modifiers at runtime. There's a pretty good chance there's a relative of `MapVirtualKey` that might work for that purpose. However, we'd need to make sure that when we re-serialize the key, that we don't lose the original. (granted, that would be fixed by #754, so maybe we should do that one first or just live with it for now...)
claunia commented 2026-01-30 22:32:02 +00:00
Author
Owner
Copy Link

@binarycrusader commented on GitHub (Jun 14, 2019):

I'd really love it if there was a way that we could just take a character and get the vkey from it.

I think this is what you're looking for in this case:

https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-oemkeyscan

And then for keys on the "Main" keyboard, there's also:

https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-vkkeyscanexa

@binarycrusader commented on GitHub (Jun 14, 2019): > I'd really love it if there was a way that we could just take a character and get the vkey from it. I think this is what you're looking for in this case: https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-oemkeyscan And then for keys on the "Main" keyboard, there's also: https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-vkkeyscanexa
claunia commented 2026-01-30 22:32:02 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 3, 2019):

:tada:This issue was addressed in #2067, which has now been successfully released as Windows Terminal Preview v0.3.2142.0.🎉

Handy links:

@ghost commented on GitHub (Aug 3, 2019): :tada:This issue was addressed in #2067, which has now been successfully released as `Windows Terminal Preview v0.3.2142.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v0.3.2142.0) * [Store Download](https://www.microsoft.com/store/apps/9n0dx20hk701?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Task Needs-Tag-Fix Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1610
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?