starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

a more effective implementation of Pane::LayoutSizeNode::operator= #16164

New Issue
Closed
opened 2026-01-31 04:59:27 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 04:59:27 +00:00
Owner
Copy Link

Originally created by @ltimaginea on GitHub (Dec 16, 2021).

fb597ed304/src/cascadia/TerminalApp/Pane.LayoutSizeNode.cpp (L35-L46)

Actually, we don't need Pane::LayoutSizeNode::_AssignChildNode to help define Pane::LayoutSizeNode::operator= . It makes things more complicated. Like LayoutSizeNode's copy constructor, LayoutSizeNode's copy assignment operator can be defined more effectively as follows:

Pane::LayoutSizeNode& Pane::LayoutSizeNode::operator=(const LayoutSizeNode& other)
{
	size = other.size;
	isMinimumSize = other.isMinimumSize;

	firstChild = other.firstChild ? std::make_unique<LayoutSizeNode>(*other.firstChild) : nullptr;
	secondChild = other.secondChild ? std::make_unique<LayoutSizeNode>(*other.secondChild) : nullptr;
	nextFirstChild = other.nextFirstChild ? std::make_unique<LayoutSizeNode>(*other.nextFirstChild) : nullptr;
	nextSecondChild = other.nextSecondChild ? std::make_unique<LayoutSizeNode>(*other.nextSecondChild) : nullptr;

	return *this;
}
Originally created by @ltimaginea on GitHub (Dec 16, 2021). https://github.com/microsoft/terminal/blob/fb597ed304ec6eef245405c9652e9b8a029b821f/src/cascadia/TerminalApp/Pane.LayoutSizeNode.cpp#L35-L46 Actually, we don't need `Pane::LayoutSizeNode::_AssignChildNode` to help define `Pane::LayoutSizeNode::operator=` . It makes things more complicated. Like LayoutSizeNode's copy constructor, LayoutSizeNode's copy assignment operator can be defined more effectively as follows: ```cpp Pane::LayoutSizeNode& Pane::LayoutSizeNode::operator=(const LayoutSizeNode& other) { size = other.size; isMinimumSize = other.isMinimumSize; firstChild = other.firstChild ? std::make_unique<LayoutSizeNode>(*other.firstChild) : nullptr; secondChild = other.secondChild ? std::make_unique<LayoutSizeNode>(*other.secondChild) : nullptr; nextFirstChild = other.nextFirstChild ? std::make_unique<LayoutSizeNode>(*other.nextFirstChild) : nullptr; nextSecondChild = other.nextSecondChild ? std::make_unique<LayoutSizeNode>(*other.nextSecondChild) : nullptr; return *this; } ```
claunia added the Help WantedIssue-TaskIn-PRProduct-TerminalArea-CodeHealth labels 2026-01-31 04:59:27 +00:00
claunia commented 2026-01-31 04:59:30 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2022):

So, if we did this, would we be able to just entirely get rid of _AssignChildNode (and then not even need to do #11963)?

@zadjii-msft commented on GitHub (Jan 3, 2022): So, if we did this, would we be able to just entirely get rid of `_AssignChildNode` (and then not even need to do #11963)?
claunia commented 2026-01-31 04:59:30 +00:00
Author
Owner
Copy Link

@ltimaginea commented on GitHub (Jan 4, 2022):

So, if we did this, would we be able to just entirely get rid of _AssignChildNode (and then not even need to do #11963)?

@zadjii-msft Yes!

fb597ed304/src/cascadia/TerminalApp/Pane.LayoutSizeNode.cpp (L71)
_AssignChildNode is redundant and error-prone. Currently, at _AssignChildNode Line71, the memory leak has been occured because nodeField.release(); doesn't destroy the managed object and we lose the pointer to the managed object. The correct way is nodeField.reset(); rather than nodeField.release(); . See unique_ptr::release - (cplusplus.com) .

A more effective implementation of Pane::LayoutSizeNode::operator= is what I wrote above. If we did this, we can delete the _AssignChildNode code block.

There is a similar technique to define a class copy assignment operator in Google tensorflow source code:
3d30ef6f49/tensorflow/compiler/xla/service/spmd/spmd_partitioner_util.cc (L731-L732)

@ltimaginea commented on GitHub (Jan 4, 2022): > So, if we did this, would we be able to just entirely get rid of `_AssignChildNode` (and then not even need to do #11963)? @zadjii-msft Yes! https://github.com/microsoft/terminal/blob/fb597ed304ec6eef245405c9652e9b8a029b821f/src/cascadia/TerminalApp/Pane.LayoutSizeNode.cpp#L71 `_AssignChildNode` is redundant and error-prone. Currently, at `_AssignChildNode` Line71, the memory leak has been occured because `nodeField.release();` doesn't destroy the managed object and we lose the pointer to the managed object. The correct way is `nodeField.reset();` rather than `nodeField.release();` . See [unique_ptr::release - (cplusplus.com)](http://www.cplusplus.com/reference/memory/unique_ptr/release/) . A more effective implementation of `Pane::LayoutSizeNode::operator=` is what I wrote above. If we did this, we can delete the `_AssignChildNode` code block. There is a similar technique to define a class copy assignment operator in Google tensorflow source code: https://github.com/tensorflow/tensorflow/blob/3d30ef6f49285b9e08a7b3492a902c67678a94d7/tensorflow/compiler/xla/service/spmd/spmd_partitioner_util.cc#L731-L732
claunia commented 2026-01-31 04:59:31 +00:00
Author
Owner
Copy Link

@ltimaginea commented on GitHub (Feb 23, 2022):

@zadjii-msft @DHowett
Any update on this?

@ltimaginea commented on GitHub (Feb 23, 2022): @zadjii-msft @DHowett Any update on this?
claunia commented 2026-01-31 04:59:31 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 24, 2022):

Sorry, been quite distracted the last few weeks. If you'd like to open a PR, feel free to! We'd love to take a look.

@zadjii-msft commented on GitHub (Feb 24, 2022): Sorry, been quite distracted the last few weeks. If you'd like to open a PR, feel free to! We'd love to take a look.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Help Wanted In-PR Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16164
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?