starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Settings] : System menu pop-up doesn't open inside 'Settings' window, when user press 'Alt + Space' key. #16167

New Issue
Closed
opened 2026-01-31 04:59:32 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 04:59:32 +00:00
Owner
Copy Link

Originally created by @Saiteja341 on GitHub (Dec 16, 2021).

Originally assigned to: @carlos-zamora on GitHub.

Windows Terminal version

1.12.3472.0

Windows build number

22509.1011

Other Software

**Test Environment: **
OS: Windows 11 Version Dev (OS Build 22509.1011)
App: Windows Terminal Preview

Steps to reproduce

**Repro Steps: **

1.Open Windows Terminal.
2.Open Settings page using 'Ctr+,'
3.Now try to open the 'System menu' pop-up by pressing 'Alt + Space' key.
4.Observe the issue.

**User Experience: **
Users will not be able to 'System menu' pop-up functionalities in 'Settings' window, if System menu pop-up doesn't open inside 'Settings' window on pressing 'Alt + Space' key.

Attachment :
System menu pop-up doesn't open inside 'Settings' window, when user press 'Alt + Space' key..zip

Expected Behavior

System menu pop-up should open inside 'Settings' window, when user press 'Alt + Space' key.

Actual Behavior

System menu pop-up doesn't open inside 'Settings' window, when user press 'Alt + Space' key.

Originally created by @Saiteja341 on GitHub (Dec 16, 2021). Originally assigned to: @carlos-zamora on GitHub. ### Windows Terminal version 1.12.3472.0 ### Windows build number 22509.1011 ### Other Software **Test Environment: ** OS: Windows 11 Version Dev (OS Build 22509.1011) App: Windows Terminal Preview ### Steps to reproduce **Repro Steps: ** 1.Open Windows Terminal. 2.Open Settings page using 'Ctr+,' 3.Now try to open the 'System menu' pop-up by pressing 'Alt + Space' key. 4.Observe the issue. **User Experience: ** Users will not be able to 'System menu' pop-up functionalities in 'Settings' window, if System menu pop-up doesn't open inside 'Settings' window on pressing 'Alt + Space' key. Attachment : [System menu pop-up doesn't open inside 'Settings' window, when user press 'Alt + Space' key..zip](https://github.com/microsoft/terminal/files/7728290/System.menu.pop-up.doesn.t.open.inside.Settings.window.when.user.press.Alt.%2B.Space.key.zip) ### Expected Behavior System menu pop-up should open inside 'Settings' window, when user press 'Alt + Space' key. ### Actual Behavior System menu pop-up doesn't open inside 'Settings' window, when user press 'Alt + Space' key.
claunia commented 2026-01-31 04:59:35 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2022):

Huh. Sure doesn't. Probably should. I'm guessing there's some magic reason that Alt+Space isn't delivered to the SUI, which is causing us to never raise a OpenSystemMenu action, so it never gets to TerminalPage::_HandleOpenSystemMenu. That's where I'd start.

@zadjii-msft commented on GitHub (Jan 3, 2022): Huh. Sure doesn't. Probably should. I'm guessing there's some magic reason that Alt+Space isn't delivered to the SUI, which is causing us to never raise a `OpenSystemMenu` action, so it never gets to `TerminalPage::_HandleOpenSystemMenu`. That's where I'd start.
claunia commented 2026-01-31 04:59:36 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 2, 2022):

Note to selves: it just generally doesn't work from the command palette either. Why does it need to go through a TermControl? that's weird.

Or read-only panes. weird.

@zadjii-msft commented on GitHub (Aug 2, 2022): Note to selves: it just generally doesn't work from the command palette either. Why does it need to go through a `TermControl`? that's weird. Or read-only panes. weird.
claunia commented 2026-01-31 04:59:36 +00:00
Author
Owner
Copy Link

@ianjoneill commented on GitHub (Aug 8, 2022):

So the reason this doesn't work in the settings UI is because Alt + Space is special cased in the app's main method to delegate through to AppHost::OnDirectKeyEvent(), which in turn delegates through to AppLogic::OnDirectKeyEvent().

This method iterates through the UI tree and passes the key event through to IDirectKeyListener implementations - of which the settings UI's MainPage isn't one.

Hitting Alt + Space in the command palette doesn't work either - it does implement IDirectKeyListener, but only seems to care about the Alt key-up event and doesn't handle Alt + Space.

I've been looking at this for a while now, and can't come up with a nice way of refactoring the code so that hitting Alt + Space works in all three places. The TermControl logic below doesn't refactor out (I was thinking up to AppLogic) well - as it uses methods on ControlSettings, which AppLogic (or MainPage for that matter) doesn't know anything about.

210a98e449/src/cascadia/TerminalControl/TermControl.cpp (L963-L988)

Oddly, the "Open system menu" action does work if you click it from within the command palette - it just doesn't work if you press the enter key with it highlighted. In both cases the action does fire, and IslandWindow::OpenSystemMenu() does get called - but when enter is pressed, the call to TrackPopupMenu() doesn't seem to do anything.

@ianjoneill commented on GitHub (Aug 8, 2022): So the reason this doesn't work in the settings UI is because `Alt` + `Space` is special cased in the app's main method to delegate through to `AppHost::OnDirectKeyEvent()`, which in turn delegates through to `AppLogic::OnDirectKeyEvent()`. This method iterates through the UI tree and passes the key event through to `IDirectKeyListener` implementations - of which the settings UI's `MainPage` isn't one. Hitting `Alt` + `Space` in the command palette doesn't work either - it does implement `IDirectKeyListener`, but only seems to care about the `Alt` key-up event and doesn't handle `Alt` + `Space`. I've been looking at this for a while now, and can't come up with a nice way of refactoring the code so that hitting `Alt` + `Space` works in all three places. The `TermControl` logic below doesn't refactor out (I was thinking up to `AppLogic`) well - as it uses methods on `ControlSettings`, which `AppLogic` (or `MainPage` for that matter) doesn't know anything about. https://github.com/microsoft/terminal/blob/210a98e44940f880175436b050151fb8c1e4b45d/src/cascadia/TerminalControl/TermControl.cpp#L963-L988 Oddly, the "Open system menu" action does work if you click it from within the command palette - it just doesn't work if you press the enter key with it highlighted. In both cases the action does fire, and `IslandWindow::OpenSystemMenu()` does get called - but when enter is pressed, the call to `TrackPopupMenu()` doesn't seem to do anything.
claunia commented 2026-01-31 04:59:36 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Oct 13, 2022):

Originally filed in MSFT-41390832

@carlos-zamora commented on GitHub (Oct 13, 2022): Originally filed in MSFT-41390832
claunia commented 2026-01-31 04:59:36 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Oct 18, 2022):

:tada:This issue was addressed in #14221, which has now been successfully released as Windows Terminal v1.15.2874.🎉

Handy links:

@ghost commented on GitHub (Oct 18, 2022): :tada:This issue was addressed in #14221, which has now been successfully released as `Windows Terminal v1.15.2874`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.15.2874) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 04:59:36 +00:00
Author
Owner
Copy Link

@Shubham786786 commented on GitHub (Nov 10, 2022):

Closing the bug as issue is fixed on the latest build:
Windows Terminal Preview Version: 1.17.3052.0

@Shubham786786 commented on GitHub (Nov 10, 2022): Closing the bug as issue is fixed on the latest build: Windows Terminal Preview Version: 1.17.3052.0
claunia commented 2026-01-31 04:59:37 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Dec 14, 2022):

:tada:This issue was addressed in #14221, which has now been successfully released as Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0.🎉

Handy links:

@ghost commented on GitHub (Dec 14, 2022): :tada:This issue was addressed in #14221, which has now been successfully released as `Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.16.3464.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11yTTValidated A11yUsable Area-Accessibility HCL-E+D HCL-WindowsTerminal Help Wanted Issue-Bug Product-Terminal Resolution-Fix-Committed WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16167
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?