starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Parser] Action Execute should dispatch and go back to ground #1617

New Issue
Closed
opened 2026-01-30 22:32:07 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:32:07 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jun 12, 2019).

From MSFT:20168257

See:
(internal) Pull Request 2743337: Add support for Ctrl+Alt+char in the input state machine engine

For the string "\x1b\x03[31m", we should ActionPrint("\x1b\x03"), then actionPrint("[31m")

When we see a C0 in any state, instead of ActionExecuting it, we should PrintString the buffer we've accumulated so far

Weird cases:
"\x1b[\x0331m"
for input, should be translated to M-[, C-c, 3, 1, m. For output, should be print("\x1b["), print("\x03"), print("31m")

Test case for all C0's:

for i in range(0, 0x1f):
    write('\x1b')
    write(chr(i))
    print('[31m  This text should not be red ({:02X})'.format(i))
    sgr()

Fixing this in the context of #19407947 would be too risky for 19H1

Originally created by @zadjii-msft on GitHub (Jun 12, 2019). From MSFT:20168257 See: (internal) Pull Request 2743337: Add support for Ctrl+Alt+char in the input state machine engine For the string "\x1b\x03[31m", we should ActionPrint("\x1b\x03"), then actionPrint("[31m") When we see a C0 in any state, instead of ActionExecuting it, we should PrintString the buffer we've accumulated so far Weird cases: "\x1b[\x0331m" for input, should be translated to M-[, C-c, 3, 1, m. For output, should be print("\x1b["), print("\x03"), print("31m") Test case for all C0's: ``` python for i in range(0, 0x1f): write('\x1b') write(chr(i)) print('[31m This text should not be red ({:02X})'.format(i)) sgr() ``` Fixing this in the context of #19407947 would be too risky for 19H1
claunia added the Product-ConhostIssue-BugArea-VTNeeds-Tag-Fix labels 2026-01-30 22:32:07 +00:00
claunia commented 2026-01-30 22:32:08 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jul 17, 2019):

It's possible I'm misunderstanding what this issue is about, because it sounds like you're talking about keyboard input and the input state machine at first, but then that final test case looks like an output test, so I'm not sure. I just wanted to make it clear that the current output behaviour is actually correct, as I understand it.

Quoting from the DEC STD 070 manual:

if a control character is transmitted in the middle of an escape sequence, the control character is executed as if the escape sequence were not present (that is, as if the control character had been received immediately before the escape sequence), with the exceptions noted below.

The exceptions essentially being the Cancel and Substitute characters, which abort the sequence, and the Escape character, which starts a new sequence (and those cases are already handled correctly).

And this matches the XTerm behaviour too. For the test case script above, the text actually is red for every case except Cancel and Substitute.

@j4james commented on GitHub (Jul 17, 2019): It's possible I'm misunderstanding what this issue is about, because it sounds like you're talking about keyboard input and the input state machine at first, but then that final test case looks like an output test, so I'm not sure. I just wanted to make it clear that the current output behaviour is actually correct, as I understand it. Quoting from the DEC STD 070 manual: > if a control character is transmitted in the middle of an escape sequence, the control character is executed as if the escape sequence were not present (that is, as if the control character had been received immediately before the escape sequence), with the exceptions noted below. The exceptions essentially being the _Cancel_ and _Substitute_ characters, which abort the sequence, and the _Escape_ character, which starts a new sequence (and those cases are already handled correctly). And this matches the XTerm behaviour too. For the test case script above, the text actually is red for every case except _Cancel_ and _Substitute_.
claunia commented 2026-01-30 22:32:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 7, 2023):

Huh, I never saw @j4james's reply here 4 years ago. I'll defer to your expertise here. Sounds like we've been doing this right for some long time now 😝

@zadjii-msft commented on GitHub (Sep 7, 2023): Huh, I never saw @j4james's reply here _4 years ago_. I'll defer to your expertise here. Sounds like we've been doing this right for some long time now 😝
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-VT Issue-Bug Needs-Tag-Fix Product-Conhost
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1617
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?