starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Console Terminal "Cursor Shape" gets reset when opening "Options" propsheet #1618

New Issue
Closed
opened 2026-01-30 22:32:09 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:32:09 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jun 12, 2019).

Originally assigned to: @zadjii-msft on GitHub.

Moved from MSFT:21001042

  1. go to properties / terminal

  2. select vertical bar

  3. click ok

at this point everything is good.

  1. go to properties / terminal

  2. go to option tab

  3. go to terminal tab

at this point you'll see that the cursor shape is reset to "legacy style". this only happens if you go to the "options tab". i think this happens because the options page as the "cursor size" option that is interfering -- just a guess.

Originally created by @zadjii-msft on GitHub (Jun 12, 2019). Originally assigned to: @zadjii-msft on GitHub. Moved from MSFT:21001042 1) go to properties / terminal 2) select vertical bar 3) click ok at this point everything is good. 1) go to properties / terminal 2) go to option tab 3) go to terminal tab at this point you'll see that the cursor shape is reset to "legacy style". this only happens if you go to the "options tab". i think this happens because the options page as the "cursor size" option that is interfering -- just a guess.
claunia commented 2026-01-30 22:32:10 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 4, 2019):

So this is more painful than I thought it was going to be.

You'd think it'd be easy enough to just not select a radio button from the group of legacy cursor sizes when the cursor style is set to something other than "legacy". Unfortunately, I don't think ComCtl lets you have a group of radio buttons where one isn't selected.

When you open the "options" page, the options page gets a WM_COMMAND. This WM_COMMAND is a BN_CLICKED sent to the selected[1] radio button from that group[2]. Unfortunately, this BN_CLICKED is indistinguishable from a real click. So we can't really ignore that message. We also however can't handle that message, because our handling of a click on IDD_CURSOR_SMALL means setting the cursor style back to Legacy.

I tried ignoring the first BN_CLICKED sent to the cursor size radio buttons, but that wouldn't work if you switched tabs. There's probably a workaround I haven't thought of here. My comctl-fu is definitely not passable, so I might be able to research more and find something. Maybe I can add a fake 0 height radio button as part of the group, as a placeholder for "non-legacy"

Technically, what we're doing here is a real anti-pattern. We shouldn't have one group of radio buttons that are affected by another group like this. We especially shouldn't have them on different pages. If we wanted to re-arrange that dialog, we'd almost certainly need to wait until the next (post-20H1) release to do that, to account for localization changes.

[1]: presumably the last selected. It might also just be sent to the first button for the case where a group has no buttons selected.
[2]: Apparently this is documented behavior

@zadjii-msft commented on GitHub (Sep 4, 2019): So this is more painful than I thought it was going to be. You'd think it'd be easy enough to just _not select_ a radio button from the group of legacy cursor sizes when the cursor style is set to something other than "legacy". Unfortunately, I don't think ComCtl lets you have a group of radio buttons where one _isn't_ selected. When you open the "options" page, the options page gets a `WM_COMMAND`. This `WM_COMMAND` is a `BN_CLICKED` sent to the selected<sup>[1]</sup> radio button from that group<sup>[2]</sup>. Unfortunately, this `BN_CLICKED` is indistinguishable from a real click. So we can't really ignore that message. We also however can't _handle_ that message, because our handling of a click on `IDD_CURSOR_SMALL` means setting the cursor style back to Legacy. I tried ignoring the first `BN_CLICKED` sent to the cursor size radio buttons, but that wouldn't work if you switched tabs. There's probably a workaround I haven't thought of here. My comctl-fu is definitely not passable, so I might be able to research more and find something. Maybe I can add a fake 0 height radio button as part of the group, as a placeholder for "non-legacy" Technically, what we're doing here is a real anti-pattern. We shouldn't have one group of radio buttons that are affected by another group like this. We especially shouldn't have them on different pages. If we wanted to re-arrange that dialog, we'd almost certainly need to wait until the next (post-20H1) release to do that, to account for localization changes. [1]: presumably the last selected. It might also just be sent to the first button for the case where a group has _no_ buttons selected. [2]: Apparently this is [documented behavior](https://microsoft.public.win32.programmer.ui.narkive.com/54Prl4Mj/repeated-wm-command-bn-clicked-messages-for-the-first-radio-control#post2)
claunia commented 2026-01-30 22:32:10 +00:00
Author
Owner
Copy Link

@ExE-Boss commented on GitHub (Sep 9, 2019):

Now all we need is for https://github.com/PowerShell/PSReadLine/issues/903 to be resolved.

@ExE-Boss commented on GitHub (Sep 9, 2019): Now all we need is for https://github.com/PowerShell/PSReadLine/issues/903 to be resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Priority-2 Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1618
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?