starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Settings> Color Schemes/Actions]: Accessible name is not descriptive for 'Add New', 'Rename', 'Add new', 'Edit', 'Accept', 'Cancel' and 'Delete' buttons inside Color Schemes & Actions page. #16225

New Issue
Open
opened 2026-01-31 05:01:08 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 05:01:08 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Dec 21, 2021).

Windows Terminal version

1.12.3472.0

Windows build number

10.0.22504.1010

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 22504.1010)
App: Windows Terminal Preview
Screen Reader: Narrator
Tool: Accessibility Insights for Windows Version 1.1.1741.1

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using 'Ctr+,'.
  3. Open Narrator using 'Win+Ctrl+ Enter' key.
  4. Now navigate to 'Add New', 'Rename', 'Add new', 'Edit', 'Accept', 'Cancel' and 'Delete' buttons inside Color Schemes & Actions page and observe the issue.

User Experience:
Screen Reader users UX will not be good if control name is not descriptive.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value

Attachments:
Accessible name is not descriptive for buttons.zip

Expected Behavior

Accessible name should be descriptive i.e. 'Add New Color Schemes', 'Rename Color Schemes', 'Add new Actions', 'Edit Copy Text Actions', 'Accept Actions', 'Cancel Actions' and 'Delete Actions' buttons inside Color Schemes & Actions page.

Actual Behavior

Accessible name is not descriptive for 'Add New', 'Rename', 'Add new', 'Edit', 'Accept', 'Cancel' and 'Delete' buttons inside Color Schemes & Actions page.
i.e. For 'Edit' button Screen Reader is only announcing 'Edit' button.

Observation: Same issue repro with NVDA Screen Reader.

Originally created by @ghost on GitHub (Dec 21, 2021). ### Windows Terminal version 1.12.3472.0 ### Windows build number 10.0.22504.1010 ### Other Software Test Environment: OS: Windows 11 Version Dev (OS Build 22504.1010) App: Windows Terminal Preview Screen Reader: Narrator Tool: Accessibility Insights for Windows Version 1.1.1741.1 ### Steps to reproduce **Repro Steps:** 1. Open Windows Terminal. 2. Open Settings page using 'Ctr+,'. 3. Open Narrator using 'Win+Ctrl+ Enter' key. 4. Now navigate to 'Add New', 'Rename', 'Add new', 'Edit', 'Accept', 'Cancel' and 'Delete' buttons inside Color Schemes & Actions page and observe the issue. **User Experience:** Screen Reader users UX will not be good if control name is not descriptive. **Guideline Reference:** https://www.w3.org/WAI/WCAG21/Understanding/name-role-value **Attachments:** [Accessible name is not descriptive for buttons.zip](https://github.com/microsoft/terminal/files/7751151/Accessible.name.is.not.descriptive.for.buttons.zip) ### Expected Behavior Accessible name should be descriptive i.e. 'Add New Color Schemes', 'Rename Color Schemes', 'Add new Actions', 'Edit Copy Text Actions', 'Accept Actions', 'Cancel Actions' and 'Delete Actions' buttons inside Color Schemes & Actions page. ### Actual Behavior Accessible name is not descriptive for 'Add New', 'Rename', 'Add new', 'Edit', 'Accept', 'Cancel' and 'Delete' buttons inside Color Schemes & Actions page. i.e. For 'Edit' button Screen Reader is only announcing 'Edit' button. **Observation:** Same issue repro with NVDA Screen Reader.
claunia commented 2026-01-31 05:01:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 2, 2022):

Hey @PankajBhojwani, does your entire rewrite of the color schemes page address this? (out of curiosity).

This also applies to the actions page, but I just wanted to check the schemes page.

@zadjii-msft commented on GitHub (Aug 2, 2022): Hey @PankajBhojwani, does your entire rewrite of the color schemes page address this? (out of curiosity). This also applies to the actions page, but I just wanted to check the schemes page.
claunia commented 2026-01-31 05:01:10 +00:00
Author
Owner
Copy Link

@PankajBhojwani commented on GitHub (Aug 2, 2022):

Hey @PankajBhojwani, does your entire rewrite of the color schemes page address this? (out of curiosity).

Not as of now!

@PankajBhojwani commented on GitHub (Aug 2, 2022): > Hey @PankajBhojwani, does your entire rewrite of the color schemes page address this? (out of curiosity). Not as of now!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11ySev3 A11yWCAG Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Bug Priority-3 Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16225
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?