starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Hidden cursor becomes visible on resize #16253

New Issue
Closed
opened 2026-01-31 05:01:48 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 05:01:48 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Dec 23, 2021).

Windows Terminal version

n/a

Windows build number

10.0.19041.1348

Other Software

No response

Steps to reproduce

  1. Open a WSL bash shell in conhost.
  2. Hide the cursor with printf "\e[?25l"
  3. Resize the window.

Expected Behavior

The cursor should remain hidden.

Actual Behavior

The cursor becomes visible after the window is resized.

The source of the problem is the SCREEN_INFORMATION::_AdjustScreenBuffer method, where the cursor is temporarily hidden while the buffer is resizing. The problem is that it doesn't check whether the cursor was already hidden to start with, so it mistakenly sets it visible when the resize is finished.

bb71179a24/src/host/screenInfo.cpp (L1023-L1031)

Originally created by @j4james on GitHub (Dec 23, 2021). ### Windows Terminal version n/a ### Windows build number 10.0.19041.1348 ### Other Software _No response_ ### Steps to reproduce 1. Open a WSL bash shell in conhost. 2. Hide the cursor with `printf "\e[?25l"` 3. Resize the window. ### Expected Behavior The cursor should remain hidden. ### Actual Behavior The cursor becomes visible after the window is resized. The source of the problem is the `SCREEN_INFORMATION::_AdjustScreenBuffer` method, where the cursor is temporarily hidden while the buffer is resizing. The problem is that it doesn't check whether the cursor was already hidden to start with, so it mistakenly sets it visible when the resize is finished. https://github.com/microsoft/terminal/blob/bb71179a24ff186eab999676732afff8a345cc12/src/host/screenInfo.cpp#L1023-L1031
claunia commented 2026-01-31 05:01:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Dec 24, 2021):

Great catch! Sorry, may take a bit to get to your PR :)

@DHowett commented on GitHub (Dec 24, 2021): Great catch! Sorry, may take a bit to get to your PR :)
claunia commented 2026-01-31 05:01:50 +00:00
Author
Owner
Copy Link

@elsaco commented on GitHub (Dec 24, 2021):

@j4james after hiding the cursor, resizing vertically only (grab top or bottom edge) keeps the cursor hidden. Horizontal resize unhides the cursor. Any pointers on why the vertical resize keeps the cursor hidden? Thx!

@elsaco commented on GitHub (Dec 24, 2021): @j4james after hiding the cursor, resizing vertically only (grab top or bottom edge) keeps the cursor hidden. Horizontal resize unhides the cursor. Any pointers on why the vertical resize keeps the cursor hidden? Thx!
claunia commented 2026-01-31 05:01:50 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Dec 27, 2021):

@elsaco I didn't notice that, but that does make sense. Resizing the window vertically wouldn't usually lead to the buffer being resized (unless the buffer was the exact height of the window). And if the buffer isn't being resized, then this code path is skipped. The test is a few lines up from the initial code I quoted:

bb71179a24/src/host/screenInfo.cpp (L1014-L1016)

@j4james commented on GitHub (Dec 27, 2021): @elsaco I didn't notice that, but that does make sense. Resizing the window vertically wouldn't usually lead to the buffer being resized (unless the buffer was the exact height of the window). And if the buffer isn't being resized, then this code path is skipped. The test is a few lines up from the initial code I quoted: https://github.com/microsoft/terminal/blob/bb71179a24ff186eab999676732afff8a345cc12/src/host/screenInfo.cpp#L1014-L1016
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Issue-Bug Priority-2 Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16253
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?