starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Settings> Save]: Shortcut key should be defined for 'Save' and 'Discard Changes' control inside Settings page. #16255

New Issue
Open
opened 2026-01-31 05:01:51 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 05:01:51 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Dec 24, 2021).

Windows Terminal version

1.12.3472.0

Windows build number

10.0.22504.1010

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 22504.1010)
App: Windows Terminal Preview
Screen Reader: Narrator
Tool: Accessibility Insights for Windows Version 1.1.1741.1

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using 'Ctr+,'.
  3. Make some changes inside given tabs.
  4. Verify that whether shortcuts is given to save or discard changes.

User Experience:
UX will not be good if Users like Keyboard only, Screen Reader users are not able Save or Discard changes fast.

Attachments:
Shortcut key should be defined for 'Save' and 'Discard Changes' control inside Settings page..zip

Expected Behavior

Shortcut keys should be defined for 'Save' and 'Discard Changes' control inside Settings page. Shortcut keys should also be included with 'Save' or Discard' button Accessible Name & Tooltip.
i.e. 'Ctrl+ S' to Save Changes and 'Ctrl + D' to Discard changes.

Actual Behavior

Shortcut key is not defined for 'Save' and 'Discard Changes' control inside Settings page. Users have to navigate to Save or Discard button in order to save or discard changes.

Originally created by @ghost on GitHub (Dec 24, 2021). ### Windows Terminal version 1.12.3472.0 ### Windows build number 10.0.22504.1010 ### Other Software **Test Environment:** OS: Windows 11 Version Dev (OS Build 22504.1010) App: Windows Terminal Preview Screen Reader: Narrator Tool: Accessibility Insights for Windows Version 1.1.1741.1 ### Steps to reproduce **Repro Steps:** 1. Open Windows Terminal. 2. Open Settings page using 'Ctr+,'. 3. Make some changes inside given tabs. 4. Verify that whether shortcuts is given to save or discard changes. **User Experience:** UX will not be good if Users like Keyboard only, Screen Reader users are not able Save or Discard changes fast. **Attachments:** [Shortcut key should be defined for 'Save' and 'Discard Changes' control inside Settings page..zip](https://github.com/microsoft/terminal/files/7773208/Shortcut.key.should.be.defined.for.Save.and.Discard.Changes.control.inside.Settings.page.zip) ### Expected Behavior Shortcut keys should be defined for 'Save' and 'Discard Changes' control inside Settings page. Shortcut keys should also be included with 'Save' or Discard' button Accessible Name & Tooltip. i.e. 'Ctrl+ S' to Save Changes and 'Ctrl + D' to Discard changes. ### Actual Behavior Shortcut key is not defined for 'Save' and 'Discard Changes' control inside Settings page. Users have to navigate to Save or Discard button in order to save or discard changes.
claunia commented 2026-01-31 05:01:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2022):

This one's curious. It would involve specific keybindings that are SUI-specific. That's fine, that makes sense, there are other keybindings that are already TerminalControl-specific, so that's not unreasonable. Binding them by default does get a little dicey. Imagine that someone's got ctrl+s bound currently to "new tab with Some profile" (as example). If we bound ctrl+s as "saveSettingsUI", then their binding for newTab would override that one. That seems fine, since the explicitly added that setting. It would just be a little confusing that they couldn't have both saveSettingsUI and toggleRetroEffect (for example) bound to ctrl+s. Each only works in one context (SUI vs TermControl), but only the last one in the user's settings would get bound.

INB4 Dustin and "this is why we need contextual keybindings"

In general, this doesn't seem totally impossible, so let's just go for it.

@zadjii-msft commented on GitHub (Jan 3, 2022): This one's curious. It would involve specific keybindings that are SUI-specific. That's fine, that makes sense, there are other keybindings that are already TerminalControl-specific, so that's not unreasonable. Binding them by default does get a little dicey. Imagine that someone's got <kbd>ctrl+s</kbd> bound currently to "new tab with Some profile" (as example). If we bound <kbd>ctrl+s</kbd> as `"saveSettingsUI"`, then their binding for `newTab` would override that one. That seems fine, since the explicitly added that setting. It would just be a little confusing that they couldn't have both `saveSettingsUI` and `toggleRetroEffect` (for example) bound to <kbd>ctrl+s</kbd>. Each only works in one context (SUI vs TermControl), but only the last one in the user's settings would get bound. > INB4 Dustin and "this is why we need contextual keybindings" In general, this doesn't seem totally impossible, so let's just go for it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11yUsable Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Bug Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16255
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?