starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Settings> Add New Profile]: 'Discard changes' control performing 'Delete profile' functionality inside newly created profile. #16267

New Issue
Open
opened 2026-01-31 05:02:09 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 05:02:09 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Dec 27, 2021).

Windows Terminal version

1.12.3472.0

Windows build number

10.0.22504.1010

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 22504.1010)
App: Windows Terminal Preview
Screen Reader: Narrator

Steps to reproduce

Repro Steps:
Open Windows Terminal.
Open Settings page using 'Ctr+,'.
Activate 'Add a new profile' tab, then activate 'New Empty profile' or 'Duplicate' button.
Then activate 'Discard Changes' button inside newly created profile.
Observe the issue.

User Experience:
All users UX will not be good if inappropriate functionality is performed on activating a control.

Attachments:
Profile get deleted When user activate 'Discard changes' control in newly created profile and Keyboard focus jumps to 'Discard Changes' inside Startup page..zip

Expected Behavior

'Discard changes' control should not perform 'Delete profile' functionality inside newly created profile.

Actual Behavior

'Discard changes' control performing 'Delete profile' functionality inside newly created profile. Profile get deleted When user activate 'Discard changes' control in newly created profile and Keyboard focus jumps to 'Discard Changes' inside Startup page..

Originally created by @ghost on GitHub (Dec 27, 2021). ### Windows Terminal version 1.12.3472.0 ### Windows build number 10.0.22504.1010 ### Other Software **Test Environment:** OS: Windows 11 Version Dev (OS Build 22504.1010) App: Windows Terminal Preview Screen Reader: Narrator ### Steps to reproduce **Repro Steps:** Open Windows Terminal. Open Settings page using 'Ctr+,'. Activate 'Add a new profile' tab, then activate 'New Empty profile' or 'Duplicate' button. Then activate 'Discard Changes' button inside newly created profile. Observe the issue. **User Experience:** All users UX will not be good if inappropriate functionality is performed on activating a control. **Attachments:** [Profile get deleted When user activate 'Discard changes' control in newly created profile and Keyboard focus jumps to 'Discard Changes' inside Startup page..zip](https://github.com/microsoft/terminal/files/7778817/Profile.get.deleted.When.user.activate.Discard.changes.control.in.newly.created.profile.and.Keyboard.focus.jumps.to.Discard.Changes.inside.Startup.page.zip) ### Expected Behavior 'Discard changes' control should not perform 'Delete profile' functionality inside newly created profile. ### Actual Behavior 'Discard changes' control performing 'Delete profile' functionality inside newly created profile. Profile get deleted When user activate 'Discard changes' control in newly created profile and Keyboard focus jumps to 'Discard Changes' inside Startup page..
claunia commented 2026-01-31 05:02:10 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2022):

When you've added a new profile, but haven't yet saved the settings, then "discarding" the settings makes sense to delete the profile - this new profile is part of the unsaved settings to the Terminal. Discarding the settings at this point will of course remove this newly created but yet unsaved profile, and reload the original settings. This is by design, can we get it resolved as such @v-rpundir?

@zadjii-msft commented on GitHub (Jan 3, 2022): When you've added a new profile, but haven't yet saved the settings, then "discarding" the settings makes sense to delete the profile - this new profile is part of the unsaved settings to the Terminal. Discarding the settings at this point will of course remove this newly created but yet unsaved profile, and reload the original settings. This is by design, can we get it resolved as such @v-rpundir?
claunia commented 2026-01-31 05:02:10 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 5, 2022):

@zadjii-msft I am still feeling this behavior inappropriate because when we create/Duplicate a profile, did some changes, then when we discard changes, profile get deleted.
Refer video attachment to see above use case: Use Case.zip

Suggestion Fix: New Profile gets automatically saved when we create/duplicate a profile.

@ghost commented on GitHub (Jan 5, 2022): @zadjii-msft I am still feeling this behavior inappropriate because when we create/Duplicate a profile, did some changes, then when we discard changes, profile get deleted. Refer video attachment to see above use case: [Use Case.zip](https://github.com/microsoft/terminal/files/7814857/Use.Case.zip) Suggestion Fix: New Profile gets automatically saved when we create/duplicate a profile.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11yUsable Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Bug Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16267
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?