starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Terminal >Set tab color]: Screen Reader is not announcing role as 'On/Off' for Selected/Non-selected Colors button. #16274

New Issue
Closed
opened 2026-01-31 05:02:22 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 05:02:22 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Dec 27, 2021).

Windows Terminal version

1.12.3472.0

Windows build number

10.0.22504.1010

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 22504.1010)
App: Windows Terminal Preview
Screen Reader: Narrator
Tool: Accessibility Insights for Windows Version 1.1.1741.1

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using 'Ctr+,'.
  3. Activate 'Actions' tab and then Add a new actions 'Set tab color' with shortcut key 'Ctrl + Shift + c'.
  4. Open Narrator using 'Win + Ctrl + Enter' keys.
  5. navigate inside Terminal window.
  6. Press 'Ctrl + Shift + c' keys, then navigate to colors control inside Set tab color pop-up using tab key.
  7. Observe the issues.

User Experience:
Screen Reader users UX will not be good as they will get full control info as role properties not announced to them.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value

Attachments:
Screen Reader is not announcing role as 'OnOff' for SelectedNon-selected Colors button..zip

Expected Behavior

Screen Reader should announce role as 'On/Off' for Selected/Non-selected Colors button.
i.e. For the Selected 'Steel blue' button Screen Reader should announce 'Steel blue button On' and for non-selected 'Medium Sea Green' button Screen Reader should announce 'Medium Sea Green button Off'.

Actual Behavior

Screen Reader is not announcing role as 'On/Off' for Selected/Non-selected Colors button.
i.e. For Selected 'Steel blue' button Screen Reader is only announcing 'Steel blue button' and for non-selected 'Medium Sea Green' button Screne Reader is only announcing 'Medium Sea Green button'.

Observation: Issue repro with NVDA and JAWS Screen Reader.

Originally created by @ghost on GitHub (Dec 27, 2021). ### Windows Terminal version 1.12.3472.0 ### Windows build number 10.0.22504.1010 ### Other Software **Test Environment:** OS: Windows 11 Version Dev (OS Build 22504.1010) App: Windows Terminal Preview Screen Reader: Narrator Tool: Accessibility Insights for Windows Version 1.1.1741.1 ### Steps to reproduce **Repro Steps:** 1. Open Windows Terminal. 2. Open Settings page using 'Ctr+,'. 3. Activate 'Actions' tab and then Add a new actions 'Set tab color' with shortcut key 'Ctrl + Shift + c'. 4. Open Narrator using 'Win + Ctrl + Enter' keys. 5. navigate inside Terminal window. 6. Press 'Ctrl + Shift + c' keys, then navigate to colors control inside Set tab color pop-up using tab key. 7. Observe the issues. **User Experience:** Screen Reader users UX will not be good as they will get full control info as role properties not announced to them. **Guideline Reference:** https://www.w3.org/WAI/WCAG21/Understanding/name-role-value **Attachments:** [Screen Reader is not announcing role as 'OnOff' for SelectedNon-selected Colors button..zip](https://github.com/microsoft/terminal/files/7779518/Screen.Reader.is.not.announcing.role.as.OnOff.for.SelectedNon-selected.Colors.button.zip) ### Expected Behavior Screen Reader should announce role as 'On/Off' for Selected/Non-selected Colors button. i.e. For the Selected 'Steel blue' button Screen Reader should announce 'Steel blue button On' and for non-selected 'Medium Sea Green' button Screen Reader should announce 'Medium Sea Green button Off'. ### Actual Behavior Screen Reader is not announcing role as 'On/Off' for Selected/Non-selected Colors button. i.e. For Selected 'Steel blue' button Screen Reader is only announcing 'Steel blue button' and for non-selected 'Medium Sea Green' button Screne Reader is only announcing 'Medium Sea Green button'. **Observation:** Issue repro with NVDA and JAWS Screen Reader.
claunia commented 2026-01-31 05:02:25 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jul 22, 2022):

I'm not sure about this one. @DHowett and @zadjii-msft for thoughts if I'm missing anything.

So, the short version of the bug is:

  1. set tab color to "Steel blue"
  2. open tab color picker again

Expected: "Steel blue" button should be "on", but other color buttons should be "off"
Actual: all buttons are just buttons. No state of "on"/"off".

This is by design. Setting the color is a one-directional scenario. By that, I mean that selecting a color is a "set" operation with no relationship with the existing color of the tab. This is important to retain because there are several other ways to set the tab color (i.e. VT escape sequences, theming, profile setting, etc...). Using the color picker overrides the existing color.

Thus, I'm closing this as "by design".

@carlos-zamora commented on GitHub (Jul 22, 2022): I'm not sure about this one. @DHowett and @zadjii-msft for thoughts if I'm missing anything. So, the short version of the bug is: 1. set tab color to "Steel blue" 2. open tab color picker _again_ Expected: "Steel blue" button should be "on", but other color buttons should be "off" Actual: all buttons are just buttons. No state of "on"/"off". This is by design. Setting the color is a one-directional scenario. By that, I mean that selecting a color is a "set" operation with no relationship with the existing color of the tab. This is important to retain because there are several other ways to set the tab color (i.e. VT escape sequences, theming, profile setting, etc...). Using the color picker overrides the existing color. Thus, I'm closing this as "by design".
claunia commented 2026-01-31 05:02:26 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jul 23, 2022):

This sounds right to me. Tab color is not selected... each button performs an immediate action, and there is no toggle aspect to it -- by design, because there is no capacity for us to track "the application set its own tab color, we must represent it differently in the UI".

@DHowett commented on GitHub (Jul 23, 2022): This sounds right to me. Tab color is not _selected_... each button performs an immediate action, and there is no toggle aspect to it -- by design, because there is no capacity for us to track "the application set its own tab color, we must represent it differently in the UI".
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11ySev3 A11yWCAG Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16274
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?