starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Terminal >Set tab color]: Both label name and role is changing for 'More /Less' control. #16278

New Issue
Closed
opened 2026-01-31 05:02:31 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 05:02:31 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Dec 27, 2021).

Windows Terminal version

1.12.3472.0

Windows build number

10.0.22504.1010

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 22504.1010)
App: Windows Terminal Preview
Screen Reader: Narrator
Tool: Accessibility Insights for Windows Version 1.1.1741.1

Steps to reproduce

Repro Steps:

  1. Open Windows Terminal.
  2. Open Settings page using 'Ctr+,'.
  3. Activate 'Actions' tab and then Add a new actions 'Set tab color' with shortcut key 'Ctrl + Shift + c'.
  4. Open Narrator using 'Win + Ctrl + Enter' keys.
  5. navigate inside Terminal window.
  6. Press 'Ctrl + Shift + c' keys, then navigate to 'More/Less' control inside Set tab color pop-up using tab key.
  7. Observe the issues.

User Experience:
Screen Reader users UX will not be good as they will get confused if control properties are not defined properly.

Guideline Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value

Attachments:
Both label name and role is changing for 'More Less' control..zip

Expected Behavior

For 'More' button Screen Reader should announce 'More button, invoke to show the text entry fields' and for 'Less' button Screen Reader should announce 'Less button, invoke to hide the text entry fields'

Actual Behavior

Both label name and role is changing for 'More /Less' control.
i.e. For 'More' button Screen Reader is announcing 'More button Off, Invoke to show or hide the text entry fields' and For 'Less' button Screen Reader is announcing 'Less button On, Invoke to show or hide the text entry fields'

Observation: Issue repro with NVDA and JAWS Screen Readers.

Originally created by @ghost on GitHub (Dec 27, 2021). ### Windows Terminal version 1.12.3472.0 ### Windows build number 10.0.22504.1010 ### Other Software **Test Environment:** OS: Windows 11 Version Dev (OS Build 22504.1010) App: Windows Terminal Preview Screen Reader: Narrator Tool: Accessibility Insights for Windows Version 1.1.1741.1 ### Steps to reproduce **Repro Steps:** 1. Open Windows Terminal. 2. Open Settings page using 'Ctr+,'. 3. Activate 'Actions' tab and then Add a new actions 'Set tab color' with shortcut key 'Ctrl + Shift + c'. 4. Open Narrator using 'Win + Ctrl + Enter' keys. 5. navigate inside Terminal window. 6. Press 'Ctrl + Shift + c' keys, then navigate to 'More/Less' control inside Set tab color pop-up using tab key. 7. Observe the issues. **User Experience:** Screen Reader users UX will not be good as they will get confused if control properties are not defined properly. **Guideline Reference:** https://www.w3.org/WAI/WCAG21/Understanding/name-role-value **Attachments:** [Both label name and role is changing for 'More Less' control..zip](https://github.com/microsoft/terminal/files/7779898/Both.label.name.and.role.is.changing.for.More.Less.control.zip) ### Expected Behavior For 'More' button Screen Reader should announce 'More button, invoke to show the text entry fields' and for 'Less' button Screen Reader should announce 'Less button, invoke to hide the text entry fields' ### Actual Behavior Both label name and role is changing for 'More /Less' control. i.e. For 'More' button Screen Reader is announcing 'More button Off, Invoke to show or hide the text entry fields' and For 'Less' button Screen Reader is announcing 'Less button On, Invoke to show or hide the text entry fields' **Observation:** Issue repro with NVDA and JAWS Screen Readers.
claunia commented 2026-01-31 05:02:34 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jun 28, 2022):

Should be relatively easy. Sounds like a matter of defining help text and name to some controls in the tab color picker.

@carlos-zamora commented on GitHub (Jun 28, 2022): Should be relatively easy. Sounds like a matter of defining help text and name to some controls in the tab color picker.
claunia commented 2026-01-31 05:02:35 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jul 18, 2022):

@v-rpundir this is a bug on WinUI 2: https://github.com/microsoft/microsoft-ui-xaml/issues/7395

@carlos-zamora commented on GitHub (Jul 18, 2022): @v-rpundir this is a bug on WinUI 2: https://github.com/microsoft/microsoft-ui-xaml/issues/7395
claunia commented 2026-01-31 05:02:35 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 19, 2022):

In Discussion with WinUI Testing team.

@ghost commented on GitHub (Jul 19, 2022): In Discussion with WinUI Testing team.
claunia commented 2026-01-31 05:02:35 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jul 19, 2022):

Hi @carlos-zamora We are tracking this WinUI Bug here in their ADO https://microsoft.visualstudio.com/DefaultCollection/OS/_workitems/edit/40517763 as WinUI team does not track issue in GitHub.

Thanks:):

@ghost commented on GitHub (Jul 19, 2022): Hi @carlos-zamora We are tracking this WinUI Bug here in their ADO https://microsoft.visualstudio.com/DefaultCollection/OS/_workitems/edit/40517763 as WinUI team does not track issue in GitHub. Thanks:):
claunia commented 2026-01-31 05:02:35 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Oct 19, 2022):

Closing now that the bug has been accepted.

zadjii-msft edit, 2023-02-08: WinUI ended up rejecting MSFT:40517763. Ultimately it's their bug, so if this comes up again, we should re-escalate with them.

@carlos-zamora commented on GitHub (Oct 19, 2022): Closing now that the bug has been accepted. zadjii-msft edit, 2023-02-08: WinUI ended up rejecting MSFT:40517763. Ultimately it's their bug, so if this comes up again, we should re-escalate with them.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11ySev3 A11yWCAG Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Bug Priority-3 Product-Terminal Resolution-External Tracking-External WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16278
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?