starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

vim Background Color Not Always Displaying Correctly (but works in conhost.exe) #16283

New Issue
Closed
opened 2026-01-31 05:02:43 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 05:02:43 +00:00
Owner
Copy Link

Originally created by @matrdr on GitHub (Dec 27, 2021).

Windows Terminal version

1.11.3471.0

Windows build number

10.0.19044.0

Other Software

vim 8.1 (inside WSL)

Steps to reproduce

Open vim in WSL. A background color different to the terminal's background color shall be set (e.g. by using a colorscheme).
When trying the command :ls or :hi it is visible that the terminal's background color is visible in places where it should not be.

When trying to reproduce this using conhost.exe (the good old terminal) instead of Windows Terminal you may notice that the background works as expected there. Therefore it seems that something is handled differently in Windows Terminal.

Expected Behavior

image

Actual Behavior

image

Originally created by @matrdr on GitHub (Dec 27, 2021). ### Windows Terminal version 1.11.3471.0 ### Windows build number 10.0.19044.0 ### Other Software vim 8.1 (inside WSL) ### Steps to reproduce Open `vim` in WSL. A background color different to the terminal's background color shall be set (e.g. by using a colorscheme). When trying the command `:ls` or `:hi` it is visible that the terminal's background color is visible in places where it should not be. When trying to reproduce this using `conhost.exe` (the good old terminal) instead of Windows Terminal you may notice that the background works as expected there. Therefore it seems that something is handled differently in Windows Terminal. ### Expected Behavior ![image](https://user-images.githubusercontent.com/45005058/147497687-fc67d7c1-b7e4-4bde-b64c-bf41a92b441d.png) ### Actual Behavior ![image](https://user-images.githubusercontent.com/45005058/147497707-b1d47d28-7c7e-445f-988b-b29d3e23256f.png)
claunia commented 2026-01-31 05:02:45 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2022):

Hmmmm. I'm guessing that you've got the background color in conhost set to the white color scheme entry, right? Conhost (traditionally) only allowed users to set the background color to one of the 16 colors of the color scheme. The Terminal however, more correctly emulates a real terminal, and has a separate color entry for the "default background color", which is defaulted to a black color.

You can probably get the Terminal to look like you're old conhost window by setting defaultBackground to #ffffff or something similar. Either set it just for your WSL profile, or in the profiles.defaults block

@zadjii-msft commented on GitHub (Jan 3, 2022): Hmmmm. I'm guessing that you've got the background color in conhost set to the white color scheme entry, right? Conhost (traditionally) only allowed users to set the background color to one of the 16 colors of the color scheme. The Terminal however, more correctly emulates a real terminal, and has a separate color entry for the "default background color", which is defaulted to a black color. You can probably get the Terminal to look like you're old conhost window by setting `defaultBackground` to `#ffffff` or something similar. Either set it just for your WSL profile, or in the `profiles.defaults` block
claunia commented 2026-01-31 05:02:45 +00:00
Author
Owner
Copy Link

@matrdr commented on GitHub (Jan 3, 2022):

In both cases the default background color is black. It is overridden by an option in vim, which seems to be interpreted differently in both terminals.

@matrdr commented on GitHub (Jan 3, 2022): In both cases the default background color is black. It is overridden by an option in vim, which seems to be interpreted differently in both terminals.
claunia commented 2026-01-31 05:02:45 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 3, 2022):

It is overridden by an option in vim, which seems to be interpreted differently in both terminals.

which option exactly?

@zadjii-msft commented on GitHub (Jan 3, 2022): > It is overridden by an option in vim, which seems to be interpreted differently in both terminals. which option exactly?
claunia commented 2026-01-31 05:02:46 +00:00
Author
Owner
Copy Link

@matrdr commented on GitHub (Jan 3, 2022):

For this example I used the :colorscheme morning command in vim to change its colorscheme. I do not exactly know, what this sets in the terminal.

@matrdr commented on GitHub (Jan 3, 2022): For this example I used the `:colorscheme morning` command in vim to change its colorscheme. I do not exactly know, what this sets in the terminal.
claunia commented 2026-01-31 05:02:46 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 3, 2022):

I think the is because the Windows Terminal VT implementation doesn't handle bce (background color erase) correctly for line feeds at the bottom of the screen.

If you look at the debug tap for this, it's outputting line feeds to make space for the two lines after ls, expecting them to be filled with the active background color. But Windows Terminal doesn't do that.

I'm almost sure we already have an issue for this somewhere.

@j4james commented on GitHub (Jan 3, 2022): I think the is because the Windows Terminal VT implementation doesn't handle bce (background color erase) correctly for line feeds at the bottom of the screen. If you look at the debug tap for this, it's outputting line feeds to make space for the two lines after `ls`, expecting them to be filled with the active background color. But Windows Terminal doesn't do that. I'm almost sure we already have an issue for this somewhere.
claunia commented 2026-01-31 05:02:46 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Jan 3, 2022):

The issue I was thinking of is #11867, but I suspect there are others as well. I just tried hacking an update to Terminal::_AdjustCursorPosition which fills the new line when scrolling, and that seemed to fix both #11867 and this issue.

@j4james commented on GitHub (Jan 3, 2022): The issue I was thinking of is #11867, but I suspect there are others as well. I just tried hacking an update to `Terminal::_AdjustCursorPosition` which fills the new line when scrolling, and that seemed to fix both #11867 and this issue.
claunia commented 2026-01-31 05:02:46 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 4, 2022):

I owe you all the act of going back and deduplicating all these bugs. Thanks @j4james 😄

@DHowett commented on GitHub (Jan 4, 2022): I owe you all the act of going back and deduplicating all these bugs. Thanks @j4james :smile:
claunia commented 2026-01-31 05:02:46 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 1, 2022):

We believe this was fixed in Terminal v1.13, in #11982. @matrdr would you mind confirming?

@zadjii-msft commented on GitHub (Mar 1, 2022): We believe this was fixed in Terminal v1.13, in #11982. @matrdr would you mind confirming?
claunia commented 2026-01-31 05:02:47 +00:00
Author
Owner
Copy Link

@matrdr commented on GitHub (Mar 2, 2022):

We believe this was fixed in Terminal v1.13, in #11982. @matrdr would you mind confirming?

Seems fixed! Good job, guys!

@matrdr commented on GitHub (Mar 2, 2022): > We believe this was fixed in Terminal v1.13, in #11982. @matrdr would you mind confirming? Seems fixed! Good job, guys!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Question Needs-Attention Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#16283
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?